Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 12:30:07 +0530
From:   Raag Jadav <raagjadav@gmail.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: act8945a: rely on hardware for operating
 mode
Message-ID: <20230606070007.GA4691@pc>
References: <20230605104830.68552-1-raagjadav@gmail.com>
 <04b8fa24-e5a8-4871-a397-f1c0c886449a@sirena.org.uk>
 <20230605143103.GA3068@pc>
 <545d3463-ce56-41d5-9d95-55764c448c09@sirena.org.uk>
 <20230605161614.GA6548@pc>
 <42423085-2c9c-47f6-9588-3e2260da7cfa@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <42423085-2c9c-47f6-9588-3e2260da7cfa@sirena.org.uk>
Precedence: bulk

On Mon, Jun 05, 2023 at 05:30:36PM +0100, Mark Brown wrote:
> On Mon, Jun 05, 2023 at 09:46:14PM +0530, Raag Jadav wrote:
> > On Mon, Jun 05, 2023 at 03:44:37PM +0100, Mark Brown wrote:
> 
> > > It's also removing a cache so we need to talk to the hardware more often
> > > which doesn't seem like a win.  If there's a bootstapping problem then
> > > shouldn't we just read once at startup?  If there's no problem what's
> > > the advantage?
> 
> > Well, there could be cases of access which are done
> > outside of driver context or hardware failure,
> > which are not really ideal but I've faced such problems
> > a while back, so just decided to share it.
> 
> If we have those then we've got a bigger problem, for example we might
> switch to a lower power mode which can't support the load we're trying
> to get the consumer to run.

Yes, but in such cases it will atleast report whatever mode currently
set in the hardware and not the incorrect one stored locally in the memory,
and this way I think we have a better chance of finding out that
there indeed is a problem.

Cheers,
Raag