Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e099e2c1-322c-0a64-0f5b-5da621fedca1@redhat.com>
Date:   Tue, 6 Jun 2023 09:10:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v1 2/3] selftests/mm: gup_longterm: new functional test
 for FOLL_LONGTERM
To:     John Hubbard <jhubbard@nvidia.com>, linux-kernel@vger.kernel.org
Cc:     linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Jens Axboe <axboe@kernel.dk>, Peter Xu <peterx@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>, Jan Kara <jack@suse.cz>
References: <20230519102723.185721-1-david@redhat.com>
 <20230519102723.185721-3-david@redhat.com>
 <ea3548ae-de27-fb67-5b2a-34aca006005c@nvidia.com>
Content-Language: en-US
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <ea3548ae-de27-fb67-5b2a-34aca006005c@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06.06.23 08:23, John Hubbard wrote:
> On 5/19/23 03:27, David Hildenbrand wrote:
> ...
>> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
>> index 23af4633f0f4..95acb099315e 100644
>> --- a/tools/testing/selftests/mm/Makefile
>> +++ b/tools/testing/selftests/mm/Makefile
>> @@ -34,6 +34,7 @@ LDLIBS = -lrt -lpthread
>>   
>>   TEST_GEN_PROGS = cow
>>   TEST_GEN_PROGS += compaction_test
>> +TEST_GEN_PROGS += gup_longterm
> 
> Hi David,
> 
> Peter Xu just pointed out that we need a .gitignore entry for
> gup_longterm [1]. That logically belongs in this patch, I think.

Yes, although I don't care if it's in a follow-up patch (we're talking 
testcases after all).

@Andrew can you include that hunk in that patch or do you want a resend?

-- 
Cheers,

David / dhildenb