Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v12 12/31] LoongArch: KVM: Implement vcpu interrupt
 operations
To:     Tianrui Zhao <zhaotianrui@loongson.cn>
References: <20230530015223.147755-1-zhaotianrui@loongson.cn>
 <20230530015223.147755-13-zhaotianrui@loongson.cn>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Huacai Chen <chenhuacai@kernel.org>,
        WANG Xuerui <kernel@xen0n.name>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        loongarch@lists.linux.dev, Jens Axboe <axboe@kernel.dk>,
        Mark Brown <broonie@kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Oliver Upton <oliver.upton@linux.dev>, maobibo@loongson.cn,
        Xi Ruoyao <xry111@xry111.site>
From:   Youling Tang <tangyouling@loongson.cn>
Message-ID: <0fc1f879-f7d9-2891-6169-b78593386cc1@loongson.cn>
Date:   Tue, 6 Jun 2023 14:49:10 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20230530015223.147755-13-zhaotianrui@loongson.cn>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 05/30/2023 09:52 AM, Tianrui Zhao wrote:
> Implement vcpu interrupt operations such as vcpu set irq and
> vcpu clear irq, using set_gcsr_estat to set irq which is
> parsed by the irq bitmap.
>
> Signed-off-by: Tianrui Zhao <zhaotianrui@loongson.cn>
> ---
>  arch/loongarch/kvm/interrupt.c | 127 +++++++++++++++++++++++++++++++++
>  arch/loongarch/kvm/vcpu.c      |  45 ++++++++++++
>  2 files changed, 172 insertions(+)
>  create mode 100644 arch/loongarch/kvm/interrupt.c
>
> diff --git a/arch/loongarch/kvm/interrupt.c b/arch/loongarch/kvm/interrupt.c
> new file mode 100644
> index 000000000000..243bb19b387e
> --- /dev/null
> +++ b/arch/loongarch/kvm/interrupt.c
> @@ -0,0 +1,127 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2020-2023 Loongson Technology Corporation Limited
> + */
> +
> +#include <linux/errno.h>
> +#include <linux/err.h>
> +#include <asm/kvm_vcpu.h>
> +#include <asm/kvm_csr.h>
> +
> +static unsigned int int_to_coreint[EXCCODE_INT_NUM] = {
> +	[INT_TI]	= CPU_TIMER,
> +	[INT_IPI]	= CPU_IPI,
> +	[INT_SWI0]	= CPU_SIP0,
> +	[INT_SWI1]	= CPU_SIP1,
> +	[INT_HWI0]	= CPU_IP0,
> +	[INT_HWI1]	= CPU_IP1,
> +	[INT_HWI2]	= CPU_IP2,
> +	[INT_HWI3]	= CPU_IP3,
> +	[INT_HWI4]	= CPU_IP4,
> +	[INT_HWI5]	= CPU_IP5,
> +	[INT_HWI6]	= CPU_IP6,
> +	[INT_HWI7]	= CPU_IP7,
> +};
> +
> +static int _kvm_irq_deliver(struct kvm_vcpu *vcpu, unsigned int priority)
> +{
> +	unsigned int irq = 0;
> +
> +	clear_bit(priority, &vcpu->arch.irq_pending);
> +	if (priority < EXCCODE_INT_NUM)
> +		irq = int_to_coreint[priority];
> +
> +	switch (priority) {
> +	case INT_TI:
> +	case INT_IPI:
> +	case INT_SWI0:
> +	case INT_SWI1:
> +		set_gcsr_estat(irq);
> +		break;
> +
> +	case INT_HWI0:
> +	case INT_HWI1:
> +	case INT_HWI2:
> +	case INT_HWI3:
> +	case INT_HWI4:
> +	case INT_HWI5:
> +	case INT_HWI6:
> +	case INT_HWI7:
It can be simplified to,
case INT_HWI0 ... INT_HWI7:

> +		set_csr_gintc(irq);
> +		break;
> +
> +	default:
> +		break;
> +	}
> +
> +	return 1;
> +}
> +
> +static int _kvm_irq_clear(struct kvm_vcpu *vcpu, unsigned int priority)
> +{
> +	unsigned int irq = 0;
> +
> +	clear_bit(priority, &vcpu->arch.irq_clear);
> +	if (priority < EXCCODE_INT_NUM)
> +		irq = int_to_coreint[priority];
> +
> +	switch (priority) {
> +	case INT_TI:
> +	case INT_IPI:
> +	case INT_SWI0:
> +	case INT_SWI1:
> +		clear_gcsr_estat(irq);
> +		break;
> +
> +	case INT_HWI0:
> +	case INT_HWI1:
> +	case INT_HWI2:
> +	case INT_HWI3:
> +	case INT_HWI4:
> +	case INT_HWI5:
> +	case INT_HWI6:
> +	case INT_HWI7:
ditto.

Thanks,
Youling
> +		clear_csr_gintc(irq);
> +		break;
> +
> +	default:
> +		break;
> +	}
> +
> +	return 1;
> +}