Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Chester Lin <clin@suse.com>, NXP S32 Linux Team <s32@nxp.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio@vger.kernel.org (open list:PIN CONTROLLER - NXP S32),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] pinctrl: nxp: Fix resource leaks in for_each_child_of_node() loops
Date:   Tue,  6 Jun 2023 15:02:01 +0800
Message-Id: <20230606070201.14249-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uT4cn0Whw0mhQ7mBS2QRsJOHh8lDJFuMbU5NuG+sWigxG13jsfvTTrXXIm9c?=
 =?us-ascii?Q?Zsfh5bH2WKLYnTScundb+lNSoCMtDpuZVPOK8t4oJ99RRUpwaX6f4mD+q2uJ?=
 =?us-ascii?Q?iiXdzSu6veDg5IVb4FuAZeNb3ts/y2EGzdvaDm02iOklAGBqrTJ0eNg2x2zt?=
 =?us-ascii?Q?TVb/JBMM5WFltnQIE3iKAaBjlHKdpIVAGaMEcidyLv2lDIaXgJJfVEewCC/9?=
 =?us-ascii?Q?ooqgCawFSVZpVfyAKTrblNmQPPQ5YHHI5E8gNwWel+uhtYmaZQaJ4M6Lig/p?=
 =?us-ascii?Q?Wu6ueVfXYH4+rqqLyyCWNiIjh59Vwml/TsRX82oBdStYK/66GR6ow/H+cfqh?=
 =?us-ascii?Q?KTR6Zp+McScj4ylqoR1PkmKVhVxpudODRN3hwhS+UrmLVC/p4DUa7xkdklHp?=
 =?us-ascii?Q?jbUXFvMRZNEuDrFG3Mi45/36dRSjznHo9YclmDNUVbP8SsmQak8HsijnOFVu?=
 =?us-ascii?Q?r6I0o0Tvmf3AtEI7mLj9oj7215ztWAVpUrXoNnfhKaadfAVtnKQc2aVjPDHh?=
 =?us-ascii?Q?aQtCHblHKYUDu98dofiK7MEoNkTOVCb/YgutKmgMqqrmP9HNIzKVPHrS4xSv?=
 =?us-ascii?Q?dCvETMjr9rHvd8S4FIxThDkF4+J8/5vAHnQeca+/73fMzEJ9xLXedMd5H0NM?=
 =?us-ascii?Q?qx792nR3OrKYvID2yZBwnKxJ9kVf57yPlQKk0PS4CpyoVvC4SXvYxZXrAKsY?=
 =?us-ascii?Q?6NCgSBUTkJbfleFaxf656k4xZeMl5qGI7BkOx16pAgyuPHe4DCwpaPrLF3Gb?=
 =?us-ascii?Q?TIp7X8Rs4EM+s7qIClx6RcMMIvj9dcvZtt8IbS9uoKjcofOUUhrtQQLLvIuK?=
 =?us-ascii?Q?p78F/ozuv8BOEjbCxoDuSXcHcZhvX4MW8+C9HbRkb/HgRPlKebGxHvQQ5u6J?=
 =?us-ascii?Q?W//5cU2S8qkPIFe7zd2ZeghyFEwkbj1AdiGOFOHuj9HSYo/NjscKjwQldnHf?=
 =?us-ascii?Q?vQmzYSEuxutBEtv81TpPB/HdnKWrcT2WzGaXlyX6A58S+2u5vL1vzPJfKudS?=
 =?us-ascii?Q?1UPw9BO3lG1wQubMpO7WtNpoddajqwtPCYqvi67x4/qAcG38GWtchbrKdmD5?=
 =?us-ascii?Q?4iYJVoOuhUmxSxXAYIWXlB4Q2YI+xmYjCDqVLZie4e27t9wzKvtRGfwxcWPE?=
 =?us-ascii?Q?l3TFTPkYu4MsCSwiP4ACn1zp9v329AT+zPETTBCg2dV3NHiE+pbbpTb/c30U?=
 =?us-ascii?Q?y1gTrcX5+Ts5NXpFpXdyPICJffuIpNC7vPzSyTZCEvodmaaLrRKru6NdGi9/?=
 =?us-ascii?Q?ivin7m3xohWtY9z9Dtixj+sDbO98oHzcTh4W25jzaMMuAgcRTaEw9Cv/YNLJ?=
 =?us-ascii?Q?cm5xz/FsgsNqDjK0ylWmvzzY37heVNHe4FbIghKBVm3sIbzTB8kCu/XFVgA8?=
 =?us-ascii?Q?xIBp7bO/Q/hdcskIdBTojrOr6UYSZ1gzDbToVwrtT9HmCzrRqlVFfUWV75lP?=
 =?us-ascii?Q?QEEmAK8vx+sI7CqMJce8XmaV7m8VZRpU4fb9jU2UnloNFc3pbcneY0kHkLHU?=
 =?us-ascii?Q?lKHDCta9d6kU6fZzMZ+OAhE8R3f+lvNxGUOIpHjvHauGZCmW4qHcZyqMlHwt?=
 =?us-ascii?Q?lZhs7HBXxfoXm18NL2YPcgE6F61GeIzH+MWMINSo?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 601a781a-9099-4fd6-800a-08db665bf39b
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 07:02:12.0335
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /w/Kt3JzaiMeD/G7rgNAgPpWmACdLmB3/cPAbwtVp/f9gEjgsUpLmXrHUauyQkeXmxtr/0Y/zO2XPH5VzU3vUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6151
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ensure child node references are decremented properly in the error path.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/pinctrl/nxp/pinctrl-s32cc.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/nxp/pinctrl-s32cc.c b/drivers/pinctrl/nxp/pinctrl-s32cc.c
index 41e024160f36..3ae043b27463
--- a/drivers/pinctrl/nxp/pinctrl-s32cc.c
+++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c
@@ -279,8 +279,10 @@ static int s32_dt_node_to_map(struct pinctrl_dev *pctldev,
 		ret = s32_dt_group_node_to_map(pctldev, np, map,
 					       &reserved_maps, num_maps,
 					       np_config->name);
-		if (ret < 0)
+		if (ret < 0) {
+			of_node_put(np);
 			break;
+		}
 	}
 
 	if (ret)
@@ -812,8 +814,10 @@ static int s32_pinctrl_parse_functions(struct device_node *np,
 		groups[i] = child->name;
 		grp = &info->groups[info->grp_index++];
 		ret = s32_pinctrl_parse_groups(child, grp, info);
-		if (ret)
+		if (ret) {
+			of_node_put(child);
 			return ret;
+		}
 		i++;
 	}
 
@@ -896,8 +900,10 @@ static int s32_pinctrl_probe_dt(struct platform_device *pdev,
 	i = 0;
 	for_each_child_of_node(np, child) {
 		ret = s32_pinctrl_parse_functions(child, info, i++);
-		if (ret)
+		if (ret) {
+			of_node_put(child);
 			return ret;
+		}
 	}
 
 	return 0;
-- 
2.39.0