Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0d2a3964-8011-d8d6-8017-1f64bb117ac7@kernel.org>
Date:   Tue, 6 Jun 2023 08:52:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: make localmodconfig doesn't work for thunderbolt
Content-Language: en-US
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        andreas.noever@gmail.com, michael.jamet@intel.com,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        YehezkelShB@gmail.com, USB list <linux-usb@vger.kernel.org>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>
References: <4cb758c7-f4f5-820c-c7e7-5b900ccc2534@kernel.org>
 <CAK7LNATn=8a0F=4Rq2q3vz6-eupkVy6LvYUBLSiGeshujEu0zw@mail.gmail.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <CAK7LNATn=8a0F=4Rq2q3vz6-eupkVy6LvYUBLSiGeshujEu0zw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 06. 06. 23, 6:16, Masahiro Yamada wrote:
> On Wed, May 10, 2023 at 8:01 PM Jiri Slaby <jirislaby@kernel.org> wrote:
>>
>> Hi,
>>
>> if I use localmodconfig for example like this:
>> mkdir /tmp/tb/
>> echo thunderbolt >/tmp/tb/lsmod
>> make O=/tmp/tb LSMOD=/tmp/tb/lsmod localmodconfig
>>
>> I get:
>> using config: '.config'
>> thunderbolt config not found!!
>>
>> $ grep 'USB4\>' /tmp/tb/.config
>> # CONFIG_USB4 is not set
>>
>> I believe it's due to:
>>     obj-${CONFIG_USB4} := thunderbolt.o
>> in drivers/thunderbolt/Makefile. I.e. ${} used instead of more common $().
>>
>> But even if I change the parser:
>>
>> --- a/scripts/kconfig/streamline_config.pl
>> +++ b/scripts/kconfig/streamline_config.pl
>> @@ -317,7 +317,7 @@ foreach my $makefile (@makefiles) {
>>           $_ = convert_vars($_, %make_vars);
>>
>>           # collect objects after obj-$(CONFIG_FOO_BAR)
>> -       if (/obj-\$\((CONFIG_[^\)]*)\)\s*[+:]?=\s*(.*)/) {
>> +       if (/obj-\$[({](CONFIG_[^})]*)[)}]\s*[+:]?=\s*(.*)/) {
>>               $var = $1;
>>               $objs = $2;
>>
> 
> 
> Will you send this fix as a patch?

Hi,

ah, yes, sorry, I forgot. Today or tomorrow.

thanks for pinging me,
-- 
js
suse labs