Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 09:32:48 +0200
From:   Nicolas Schier <n.schier@avm.de>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/kallsyms: constify long_options
Message-ID: <ZH7hIDQcp8pDSpwJ@buildd.core.avm.de>
References: <20230605120400.1775196-1-masahiroy@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230605120400.1775196-1-masahiroy@kernel.org>
Precedence: bulk

On Mon, Jun 05, 2023 at 09:04:00PM +0900, Masahiro Yamada wrote:
> getopt_long() does not modify this.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---

Reviewed-by: Nicolas Schier <n.schier@avm.de>

> 
>  scripts/kallsyms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 0d2db41177b2..8e97ac7b38a6 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -806,7 +806,7 @@ static void record_relative_base(void)
>  int main(int argc, char **argv)
>  {
>  	while (1) {
> -		static struct option long_options[] = {
> +		static const struct option long_options[] = {
>  			{"all-symbols",     no_argument, &all_symbols,     1},
>  			{"absolute-percpu", no_argument, &absolute_percpu, 1},
>  			{"base-relative",   no_argument, &base_relative,   1},
> -- 
> 2.39.2
>