Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 03:29:26 -0400
From:   Kent Overstreet <kent.overstreet@linux.dev>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     axboe@kernel.dk, linux-kernel@vger.kernel.org,
        linux-block@vger.kernel.org,
        Phillip Lougher <phillip@squashfs.org.uk>
Subject: Re: [PATCH v2 1/5] block: Rework bio_for_each_segment_all()
Message-ID: <ZH7gVpuTy445jaYW@moria.home.lan>
References: <20230605212717.2570570-1-kent.overstreet@linux.dev>
 <ZH6UAU5d0fiBB/OI@ovpn-8-17.pek2.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZH6UAU5d0fiBB/OI@ovpn-8-17.pek2.redhat.com>
Precedence: bulk

On Tue, Jun 06, 2023 at 10:03:45AM +0800, Ming Lei wrote:
> On Mon, Jun 05, 2023 at 05:27:13PM -0400, Kent Overstreet wrote:
> > This patch reworks bio_for_each_segment_all() to be more inline with how
> > the other bio iterators work:
> > 
> >  - bio_iter_all_peek() now returns a synthesized bio_vec; we don't stash
> >    one in the iterator and pass a pointer to it - bad. This way makes it
> >    clearer what's a constructed value vs. a reference to something
> >    pre-existing, and it also will help with cleaning up and
> >    consolidating code with bio_for_each_folio_all().
> 
> by-value is more readable & clean, the current by-reference is just for aligning
> with original interface.

This is the fourth or fifth time this patch set has been out on the
list, and I specifically asked you to review it awhile back, and you're
just now looking at it?