Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 16:38:11 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Yang Weijiang <weijiang.yang@intel.com>
CC:     <seanjc@google.com>, <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
        <rppt@kernel.org>, <binbin.wu@linux.intel.com>,
        <rick.p.edgecombe@intel.com>, <john.allen@amd.com>
Subject: Re: [PATCH v3 08/21] KVM:x86: Init kvm_caps.supported_xss with
 supported feature bits
Message-ID: <ZH7wc4NX66HNqMl9@chao-email>
References: <20230511040857.6094-1-weijiang.yang@intel.com>
 <20230511040857.6094-9-weijiang.yang@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230511040857.6094-9-weijiang.yang@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r1XxZ/3KVcg0L4YrcUOZmCj2tvxtR0rtGhmIwlVPNbq5YCBDeIg56TonJFTT?=
 =?us-ascii?Q?BNPDm087QRyPb//8aclfTxfutOSt0jksRb9RbmiAazCc9Vqau8FuJ6FfkAJw?=
 =?us-ascii?Q?KCz1iuM2rKPkYENdFN9K5YNzwAutTtp9FR8hL21iKJN5tQh3HZrqZQ/qQ6Tv?=
 =?us-ascii?Q?627JVqq+tdxl6z3Hxbcy0W6V3t3QsUN9qFdYBLoN+iCgU+hPziQ4Y9C3ir00?=
 =?us-ascii?Q?3YUWyaQEcPB0UKY6dxVaQW2OWEgXPujKUZ1EirGbCYDQFuQbQCRFOp9uk2+9?=
 =?us-ascii?Q?UaL2P3vCQWCRCuTv7RXj2S8Og0SJpE8U8i0H30j7U2CK1V5LRdkmOhgly/ce?=
 =?us-ascii?Q?LwMndtBSvSLF4wmoFgQ1jVJ0aAx7qyhN/uoCsZj4KMe+oE7tXQC9aHXAttBL?=
 =?us-ascii?Q?bgdkJkG3yYC2YPG+RTqfznb5mNBVKGp+LVUzNWLfW6Hy8IBMX+eh/juC5jmZ?=
 =?us-ascii?Q?kMQxDBF35/c9YFrPXUzm6pRXIw8aQbJC8udN08jasAuX/9eHxifxWmMZhjvk?=
 =?us-ascii?Q?tGRZ/JDMW/DYBS/VvpsRekbEd4OchsX+oEsQmPvozccIc4VI4sC8WYy+QTbm?=
 =?us-ascii?Q?7RgqIMQZYpNBtp40oVkkcfuaeNdWiZdlzfbJKtsGN9AlFke8tH7X71TDk3w9?=
 =?us-ascii?Q?mIk41m7pRLgJ25CpusuQ7KPFiGz8/GU+qHLp1IQbM6NS9yqOM28RJnfAaoSw?=
 =?us-ascii?Q?/pF+eLewK8O8UiupZsejsGw/j0Ng3bYo9gBabfSMJOcyC1Gl3f4APIJlpzRF?=
 =?us-ascii?Q?7zeDl2iALlHjZmvGCNbkcvJEdQPbabVPeLufvk3ZNmL+6KyNz+oy4RU4Tjog?=
 =?us-ascii?Q?4N9//QQQoU6tOM7GSu1klLSxV0jwy9/AAx67oAYGNFXgkNYCp5xdPxjPUw7W?=
 =?us-ascii?Q?FMBmhQRfM3PgSNYXPlk/rDB7VoZFRYSi760aqTllp8oG2USNN0ntGq1/iR58?=
 =?us-ascii?Q?ge6cBjPObVnTdzIaQo8tfAtK9rwA2yVYVpmdovqTVpqk4QfoLItaKAGBVUKz?=
 =?us-ascii?Q?QPMFOEJTOcOoWURx+jR0uD7KcDhQTWPO9bAFOYqQ8ac0I73uHirs36eoXiWC?=
 =?us-ascii?Q?x4llwaifsFAA2HQ98kTD2yXEMVXJJk3nCYT3VOiiGqcrXDEQTcehsK3QCT5Z?=
 =?us-ascii?Q?7qRloSLYtjXZCjObNO+r7C8xOcYBRWl7KsojQJ4rA0EsIQIQK18JEqzqM1S6?=
 =?us-ascii?Q?LEOUkvQUYzju/EEawsi9YwWmIi0V9gSWeaffepTZtNYp7YfLddf4FSdF6NiY?=
 =?us-ascii?Q?GQDqtmRfgNoBL9nJsSstSf3vyXrehZGv4CcONYdo9qb7zE0YUDior8hsuzWd?=
 =?us-ascii?Q?YtLKBreJlr5ifq0zwloq0krybC1zM+FT0jK9jcv7yTSFR/28ImUbwMxBTuEE?=
 =?us-ascii?Q?wBfCehue+SfyxkAFvCqO/HRpoYEdqwhSJc7St73CoblnMOX6R2yeaTSKgcVl?=
 =?us-ascii?Q?V09ANCLfewLDScabQNecxscN8QdsXXJ8j6OGij49TOfkWHdu6R6SdmNckf+g?=
 =?us-ascii?Q?HOCD3aTx9nZRpW1Ql2huBKvc72g89EzuNDIaXEGZbGcMGxsdcMYIjl1vkRQT?=
 =?us-ascii?Q?OUPPABF/pzXUNOmQCwaLPZSihq9peCnKXk4HM7my?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eddd8bfb-ce77-489a-e36b-08db666962e9
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 08:38:22.1607
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z+wPUgoDpaE5V3SWg3LdefsgsRsZQu3MAa9jJahSCncMt2rECqXFh2X+1jud7EmLBM0i2Gjb144CjGUVl9bVIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6229
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 11, 2023 at 12:08:44AM -0400, Yang Weijiang wrote:
>Initialize kvm_caps.supported_xss with host XSS msr value AND XSS mask.
>KVM_SUPPORTED_XSS holds all potential supported feature bits,

>the result
>represents all KVM supported feature bits which is used for swapping guest
>and host FPU contents.

do you mean kvm_caps.supported_xss by "the result"? I don't see how
fpu_swap_kvm_fpstate() uses kvm_caps.supported_xss.

>
>Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>---
> arch/x86/kvm/vmx/vmx.c | 1 -
> arch/x86/kvm/x86.c     | 6 +++++-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>index 44fb619803b8..c872a5aafa50 100644
>--- a/arch/x86/kvm/vmx/vmx.c
>+++ b/arch/x86/kvm/vmx/vmx.c
>@@ -7806,7 +7806,6 @@ static __init void vmx_set_cpu_caps(void)
> 		kvm_cpu_cap_set(X86_FEATURE_UMIP);
> 
> 	/* CPUID 0xD.1 */
>-	kvm_caps.supported_xss = 0;

AMD has the same statement. Do you need to remove that one?

> 	if (!cpu_has_vmx_xsaves())
> 		kvm_cpu_cap_clear(X86_FEATURE_XSAVES);
> 
>diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>index ab3360a10933..d2975ca96ac5 100644
>--- a/arch/x86/kvm/x86.c
>+++ b/arch/x86/kvm/x86.c
>@@ -223,6 +223,8 @@ static struct kvm_user_return_msrs __percpu *user_return_msrs;
> 				| XFEATURE_MASK_BNDCSR | XFEATURE_MASK_AVX512 \
> 				| XFEATURE_MASK_PKRU | XFEATURE_MASK_XTILE)
> 
>+#define KVM_SUPPORTED_XSS     0
>+
> u64 __read_mostly host_efer;
> EXPORT_SYMBOL_GPL(host_efer);
> 
>@@ -9472,8 +9474,10 @@ static int __kvm_x86_vendor_init(struct kvm_x86_init_ops *ops)
> 
> 	rdmsrl_safe(MSR_EFER, &host_efer);
> 
>-	if (boot_cpu_has(X86_FEATURE_XSAVES))
>+	if (boot_cpu_has(X86_FEATURE_XSAVES)) {
> 		rdmsrl(MSR_IA32_XSS, host_xss);
>+		kvm_caps.supported_xss = host_xss & KVM_SUPPORTED_XSS;
>+	}
> 
> 	kvm_init_pmu_capability(ops->pmu_ops);
> 
>-- 
>2.27.0
>