Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 10:55:32 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Jakub Kicinski <kuba@kernel.org>,
        "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Derek Chickles <dchickles@marvell.com>,
        Satanand Burla <sburla@marvell.com>,
        Felix Manlunas <fmanlunas@marvell.com>,
        Eric Dumazet <edumazet@google.com>,
        Nick Terrell <terrelln@fb.com>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH] net: liquidio: fix mixed module-builtin object
Message-ID: <ZH70hGgOVQ89APjk@corigine.com>
References: <20230604043213.901341-1-masahiroy@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230604043213.901341-1-masahiroy@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?esr7QGqAs8cQEhFsPvu8MPH9ul6iRUzXvnLmUUNHQjZ0znYsCIC+RcqNRqfu?=
 =?us-ascii?Q?1SGwL+IYjSvYaZvc4gAkJ0OEiLT4WYaqilOlXB2jL7GKT/vvZF38r5m53Zp1?=
 =?us-ascii?Q?3HNm1O1vraDI3kxHTD8DbaRMOVpRdP3GSJv4ENdHgdsyIeM2Cdmc5eS4kZxN?=
 =?us-ascii?Q?h32cdxrS4ny6KBOk2ZOtRbWwBuBis8r40Wn37kYS/SsIH8sUSK0GNvTYAGbq?=
 =?us-ascii?Q?pnqxK43lfaW2pOVXKZQhQuIzUt6fRXl6TWBNUzB1GQNC/DwhFFmTwpKVICCY?=
 =?us-ascii?Q?AgMHYkiioqLIXstjOAOy+PcB5JZbbDQv5aD/TlkuQ6oDZVn4Hf8JsDuhX+vu?=
 =?us-ascii?Q?mfeJWBarB6OCcPQw5ONh2IN7D6jSjxSNdmPBeXI0Q+e6HmBxuOg0aRI4g7i+?=
 =?us-ascii?Q?Nh/W9i2lWGnKrZUlab/hAFUncDWBd4Kc7Fs8Gr9WQbkU4Cq3DUeGEVMLRnyg?=
 =?us-ascii?Q?jJAkeM716OAwFKAtZBWPHRfXQ55Cetsd86SE9xZFWeAddk5PYXVy8oI8RRO7?=
 =?us-ascii?Q?ZFm5mssLlso1MDIsPmxDQICGqm2s/CILG1jbxpy3GZSsxMj/+21LPlbdeFp3?=
 =?us-ascii?Q?75vXTecgXZbhPGpiHf8d0cG3jcyTdaPZG7JoGJBr7L+6PXzfHa2iUzPcQq47?=
 =?us-ascii?Q?GKpgVJlL8xZ1tmf2/atbsGESybqs+KETXP+pe49QiMzPvPYZcTwUJLILgc0k?=
 =?us-ascii?Q?RJBfCqSD/4nyzfKkYJ4OMJxW28dLtIQx5jR6gxp/C+VAGnNt0EtN/0Zbzeg9?=
 =?us-ascii?Q?2hsBLlrkiYVpD1BJ+cQo0BroTE0ppbTxTodsncuGkqyloEaeneDBGaHEsAm+?=
 =?us-ascii?Q?XP+cjqxWTB4bJQ3p3HGQeEIiOf9c+elGVSu41Guu4t83O+CmhTFGyCdwfj9q?=
 =?us-ascii?Q?9OJyAoSueN53H/mR+Wv7fQREU1c/8Kodk/wAkrfXqGfQsq4nv08hDw5zr91+?=
 =?us-ascii?Q?7jCPtTnYx1dqx/WdsxpVLhTsVYXvfAGzc0505qi4Asu1SczX7kVJ+d/e9HaK?=
 =?us-ascii?Q?F6XsU+NKuysL0iuftQvD/sMBZBgMVRTK9GVsSSv4tF6qtN91HAiG4NxMvhI5?=
 =?us-ascii?Q?1fzdWU2yVFEYGIVcknSW93bCp1lSha8uix8hKvuT6Byv3SD6GS/owsNRcd/c?=
 =?us-ascii?Q?uVqgntkSsfmk4M0ME8xR3ZTsfpJ0NpcuIVv7nVVDPUelJxF9Eul2KlZq7Vbe?=
 =?us-ascii?Q?+gPjT2bVB5K6UrKjPyj3MrvtMUoQlHJIE67k8jYS14+Z0XDQISSdZ2N+9xDg?=
 =?us-ascii?Q?Vpb/EeG/PW/YDzSSBDLaU/1vXE7f7qsuUIrHfpIrr38qNgr4XLOwA1tXXE9p?=
 =?us-ascii?Q?rDLlVNLirq13o1f6d7LK3MNdtpIRHAVnyPam2zP2nhg/qftZpPnZWgGNt66k?=
 =?us-ascii?Q?B7qUy6G+TLnAhCRtpv+rc1mb/rLzt3JSR8vB7OIgL9dB0nlpE4Kvn2ZyzvWH?=
 =?us-ascii?Q?GxZ1JWTzgKKGNnP3RSOXoXxhMPdl+2Cn7coudXxTyE79xh+udmp22OZkeKDQ?=
 =?us-ascii?Q?tCt62ntXydynr3U57L96XJhtQptPE/4a+HKftRFGycFqNWF0f9dfDoh1G7/3?=
 =?us-ascii?Q?3p8GisabOyotXS1wTVp3hQCM1S1rpgrNP+fZILOpxVm7mIUfwqttFLbUpCkg?=
 =?us-ascii?Q?O0PTrGzV5OLoZAPw859GuUADabvyoD1c+PGKcYb9VaWC+zcRB3qEscpZ6LD+?=
 =?us-ascii?Q?vkO40Q=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3b10b50-446c-416b-433f-08db666bd15a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 08:55:46.4369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TSWJHejOVW5IJ1Vrf9/E/MtmG0DwotWplUrSwUjAb3yoVZ5PuWayZE9wGssVlrn5qtMPV/YN+alzTt30Rq+kwevSD4JmASe8wH72pmHpjAA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB4813
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jun 04, 2023 at 01:32:13PM +0900, Masahiro Yamada wrote:
> With CONFIG_LIQUIDIO=m and CONFIG_LIQUIDIO_VF=y (or vice versa),
> $(common-objs) are linked to a module and also to vmlinux even though
> the expected CFLAGS are different between builtins and modules.
> 
> This is the same situation as fixed by commit 637a642f5ca5 ("zstd:
> Fixing mixed module-builtin objects").
> 
> Introduce the new module, liquidio-core, to provide the common functions
> to liquidio and liquidio-vf.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>