Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lorenzo Pieralisi <lpieralisi@kernel.org>
To:     kw@linux.com, Manivannan Sadhasivam <mani@kernel.org>
Cc:     Lorenzo Pieralisi <lpieralisi@kernel.org>, kishon@kernel.org,
        bhelgaas@google.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] PCI: endpoint: epf-mhi: Fix the outbound window offset handling
Date:   Tue,  6 Jun 2023 10:33:04 +0200
Message-Id: <168604028639.57025.13332670969969616995.b4-ty@kernel.org>
In-Reply-To: <20230606074657.31622-1-manivannan.sadhasivam@linaro.org>
References: <20230606074657.31622-1-manivannan.sadhasivam@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 06 Jun 2023 13:16:57 +0530, Manivannan Sadhasivam wrote:
> __pci_epf_mhi_alloc_map() allocates and maps the PCI outbound window memory
> to endpoint local memory. For taking care of alignment restrictions, the
> caller needs to specify the address alignment offset. Currently, this
> offset is not added to the allocated physical and virtual addresses before
> returning from the function.
> 
> But __pci_epf_mhi_unmap_free() function substracts the offset before
> unmapping and freeing the memory, leading to incorrect unmap and free.
> 
> [...]

Squashed it with the commit it was fixing.

Thanks,
Lorenzo