Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 11:51:59 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Shradha Gupta <shradhagupta@linux.microsoft.com>
Cc:     linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
        netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        Long Li <longli@microsoft.com>,
        Michael Kelley <mikelley@microsoft.com>,
        "David S. Miller" <davem@davemloft.net>,
        Steen Hegelund <steen.hegelund@microchip.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH v6] hv_netvsc: Allocate rx indirection table size
 dynamically
Message-ID: <ZH8Bv624GxCf1PKq@corigine.com>
References: <1685964606-24690-1-git-send-email-shradhagupta@linux.microsoft.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1685964606-24690-1-git-send-email-shradhagupta@linux.microsoft.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Weqm80Q4snuSZ79NDOeVEp0BfwZJFW7Uzz726tPm7FhGaQoGQ7MGzCxdBgbL?=
 =?us-ascii?Q?3l1YlBH0v+OS1U72Wj96yxN1DlTWjyARju94eh0Mf9JRFuX4DR3pBKoM3aLe?=
 =?us-ascii?Q?ps42uaNKCjKy+Us3Atnx5N3jdUXc9YL/r9pM3aAn2BiSA+2+AhqL2iDAp5jo?=
 =?us-ascii?Q?p+2ROFMDV9ei/zrB4uvbDzkcZIFcYqPZ3rBqfBtxCEOtKnrK4LSx+pES8EpZ?=
 =?us-ascii?Q?6jKNN9ojfzJeXHJdiPaUg+mWtH24epuQXNQBD4/yEi9xpd1wtCAbk6DFnAMH?=
 =?us-ascii?Q?vq9pA3/2wByCs80P8A+Z/+lOzMSgVrUEgAVFL/1h8hcjfOUIywbRxkZfksI6?=
 =?us-ascii?Q?w85Ss4ywIlgS5CILifxvhwmUI2gbaJAqgJY3Kc6dS9LkX5Y0Skv8p2RWpFYc?=
 =?us-ascii?Q?IQHRi2wxYqqu4nUeqemsP0WUsq/xmrPnZLBy8KQvvf4s+dBdlGrpUoFvp512?=
 =?us-ascii?Q?6mGT+4C5ufWiwCozaZe9MKhwPldHig3EDScXzcC68qhmrd0K6QELcBJzLZrR?=
 =?us-ascii?Q?WExbOso/ksE+0ZcFcJzXs3JKV0vH69YAuyksYnCS5WrMY5mhdwcgQmOaj7+y?=
 =?us-ascii?Q?YCDyqVTmjkZ1RG4Zd7SxzTL1tgUrQvTwDw475XHP6AkSr8rFm4T7fKwLHqM+?=
 =?us-ascii?Q?uIocaiRya7pLjQdVakIWjQVNPyhyF8vhkt/xAt3ETPO/umL6/MSM+88MRttF?=
 =?us-ascii?Q?rDUlz+OHBpgMgg9OhXEkm8snQqUDy7td/NSdRdLmf5qJLFlDuT+qMUDYlNOp?=
 =?us-ascii?Q?1QvPUf49+d5opikqQMIu6V25NaJwrkKBjxrxjzOup3X5DNpV7NYGaCzi2cjc?=
 =?us-ascii?Q?tvV5qXXrAe39/P9+cqhcQ1pAcSLorfNAEFCrwXSC16fJQTKxukl3fPIaWHnm?=
 =?us-ascii?Q?X/5MxLYttt+AhDXl1K3lo/pN8Di00CBsAiYlgs8gXYwu6I/KMAaoHsILq0Tp?=
 =?us-ascii?Q?RhNOIaRR+61UAaV49iha0BRyX+ANhOaxzvq7EvI+xlNW0llLMiwm8Vk3rB21?=
 =?us-ascii?Q?BDQT9abDfqDTXNoTChnoMjakaXPUeg35q3+xOVYqtRadZ4CvGHd/6NAKUbGI?=
 =?us-ascii?Q?ELPC3LQQNsOXo500P5fEpAUwea5xalanzCOP8XwYRRULXkjsrsUqt7lVref8?=
 =?us-ascii?Q?xb2cMbJiXcNZlErUVoL0CAdu0Ojd92Qi2abwvaZKHEQ/ccd5MZJNJP9xnolV?=
 =?us-ascii?Q?oIaoRTX+MzufQ9I3ynJgKzUHODMOs7k3QlmWLc9Y1T3Y8rpQO/kklfu6jrCR?=
 =?us-ascii?Q?jbugqw/Gh4RtHIMvt8xboTRQX209cXG9oTE+lbPhd/Rk5Mn9WVqMrdgg18Iu?=
 =?us-ascii?Q?f9Nj+tgSw6j6rA2KC1TXv4pLCdyeufzfuZIJR37raO8eHrqIMNVtZoW13TAh?=
 =?us-ascii?Q?vQjHVVa5RWLBdGJkXI4CrDu2YMrjRWeacW8z6V/JPAfuvw7gN1A6JqiB3EBE?=
 =?us-ascii?Q?qaWmGJrgretOMWBXNCYY53b4l/rFc3W0kfHd2KwQfr8bE4bfkv5G8gbySmli?=
 =?us-ascii?Q?qEXxhlFdQqtkHdU0djc4YOomTZ8oAdxraevaA2LigL+ZjlhmKzDLnbS/NgTc?=
 =?us-ascii?Q?LzpZJUYFt73PJUIrZ/HQcSJSTYJZnyhGHH+W9IXSi0xXUjSVWyeu0eakvF4b?=
 =?us-ascii?Q?J9JZkmTvUJ8jve7hnzvTYwLLsJdtwWmL7b/Gkrj653vArgrYLYTjPMBAsrvm?=
 =?us-ascii?Q?Mg2niw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3236244-8913-4f44-0088-08db6673b03b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 09:52:06.8029
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wdMEEWxTgu6G4bo/lFgrSEKI9kXUZdNX9cLAnurU8Gx/lgytt01u1fcIGrL2VyfTwowP5AC4TTbltrjeitWfOjcHFga3lDyO3Ztfh1UV6bY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3928
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+ Praveen Kumar

On Mon, Jun 05, 2023 at 04:30:06AM -0700, Shradha Gupta wrote:
> Allocate the size of rx indirection table dynamically in netvsc
> from the value of size provided by OID_GEN_RECEIVE_SCALE_CAPABILITIES
> query instead of using a constant value of ITAB_NUM.
> 
> Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
> Tested-on: Ubuntu22 (azure VM, SKU size: Standard_F72s_v2)
> Testcases:
> 1. ethtool -x eth0 output
> 2. LISA testcase:PERF-NETWORK-TCP-THROUGHPUT-MULTICONNECTION-NTTTCP-Synthetic
> 3. LISA testcase:PERF-NETWORK-TCP-THROUGHPUT-MULTICONNECTION-NTTTCP-SRIOV

Hi Praveen, all,

it seems that there has not been any non-trivial review of this
patchset since v3. But at that point there was some feedback
from you. So I'd like to ask if you have any feedback on v6 [1].

[1] https://lore.kernel.org/all/1685964606-24690-1-git-send-email-shradhagupta@linux.microsoft.com/