Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 12:59:58 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Geert Uytterhoeven <geert+renesas@glider.be>
cc:     Philipp Zabel <p.zabel@pengutronix.de>,
        Arnd Bergmann <arnd@arndb.de>,
        Jacky Huang <ychuang3@nuvoton.com>,
        linux-arm-kernel@lists.infradead.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] reset: RESET_NUVOTON_MA35D1 should depend on ARCH_MA35
In-Reply-To: <011578db5fc4426d7df5d8ce2cf5ac09b7080531.1686045287.git.geert+renesas@glider.be>
Message-ID: <6f9587b0-85df-6f80-8dc5-b27fbf11645@linux.intel.com>
References: <011578db5fc4426d7df5d8ce2cf5ac09b7080531.1686045287.git.geert+renesas@glider.be>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1201266873-1686045602=:2339"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1201266873-1686045602=:2339
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 8BIT

On Tue, 6 Jun 2023, Geert Uytterhoeven wrote:

> The Nuvoton MA35D1 reset controller is only present on Nuvoton MA35
> SoCs.  Hence add a dependency on ARCH_MA35, to prevent asking the user
> about this driver when configuring a kernel without MA35 SoC support.
> Also, do not enable the driver by default when merely compile-testing.
> 
> While at it, fix a misspelling of "Nuvoton".
> 
> Fixes: e4bb55d6ccf0f774 ("reset: Add Nuvoton ma35d1 reset driver support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/reset/Kconfig | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 0cdf9d64c2185c89..ccd59ddd76100a51 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -144,8 +144,9 @@ config RESET_NPCM
>  	  BMC SoCs.
>  
>  config RESET_NUVOTON_MA35D1
> -	bool "Nuvton MA35D1 Reset Driver"
> -	default ARCH_MA35 || COMPILE_TEST
> +	bool "Nuvoton MA35D1 Reset Driver"
> +	depends on ARCH_MA35 || COMPILE_TEST
> +	default ARCH_MA35
>  	help
>  	  This enables the reset controller driver for Nuvoton MA35D1 SoC.

All adjustments make sense.

Reviewed-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>


-- 
 i.

--8323329-1201266873-1686045602=:2339--