Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 12:46:39 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Tom Lendacky <thomas.lendacky@amd.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Michael Roth <michael.roth@amd.com>,
        Joerg Roedel <jroedel@suse.de>,
        Dionna Glaze <dionnaglaze@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RESEND PATCH v8 4/6] x86/sev: Use large PSC requests if
 applicable
Message-ID: <20230606104639.GMZH8Oj+84CvdXzAIW@fat_crate.local>
References: <20230518231434.26080-1-kirill.shutemov@linux.intel.com>
 <cover.1684513813.git.thomas.lendacky@amd.com>
 <c5448163eea57a878d9aeae504bf46ad52f9a879.1684513813.git.thomas.lendacky@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c5448163eea57a878d9aeae504bf46ad52f9a879.1684513813.git.thomas.lendacky@amd.com>
Precedence: bulk

On Fri, May 19, 2023 at 11:30:11AM -0500, Tom Lendacky wrote:
> diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c
> index 973756c89dac..8802a75e1c20 100644
> --- a/arch/x86/kernel/sev.c
> +++ b/arch/x86/kernel/sev.c
> @@ -657,32 +657,58 @@ static u64 __init get_jump_table_addr(void)
>  	return ret;
>  }
>  
> -static void pvalidate_pages(unsigned long vaddr, unsigned long npages, bool validate)
> +static void pvalidate_pages(struct snp_psc_desc *desc)
>  {
> -	unsigned long vaddr_end;
> +	struct psc_entry *e;
> +	unsigned long vaddr;
> +	unsigned int size;
> +	unsigned int i;
> +	bool validate;
>  	int rc;
>  
> -	vaddr = vaddr & PAGE_MASK;
> -	vaddr_end = vaddr + (npages << PAGE_SHIFT);
> +	for (i = 0; i <= desc->hdr.end_entry; i++) {
> +		e = &desc->entries[i];
> +
> +		vaddr = (unsigned long)pfn_to_kaddr(e->gfn);
> +		size = e->pagesize ? RMP_PG_SIZE_2M : RMP_PG_SIZE_4K;
> +		validate = (e->operation == SNP_PAGE_STATE_PRIVATE) ? true : false;

		validate = e->operation == SNP_PAGE_STATE_PRIVATE;

is enough :)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette