Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bedca9be6c496bbe9e124eda7ce13cf15bf7ca54.camel@redhat.com>
Subject: Re: [PATCH net] lib: cpu_rmap: Fix potential use-after-free in
 irq_cpu_rmap_release()
From:   Paolo Abeni <pabeni@redhat.com>
To:     Ben Hutchings <ben@decadent.org.uk>, netdev@vger.kernel.org
Cc:     Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
        Eli Cohen <elic@nvidia.com>, jacob.e.keller@intel.com,
        saeedm@nvidia.com
Date:   Tue, 06 Jun 2023 12:59:17 +0200
In-Reply-To: <ZHo0vwquhOy3FaXc@decadent.org.uk>
References: <ZHo0vwquhOy3FaXc@decadent.org.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

Hi,

On Fri, 2023-06-02 at 20:28 +0200, Ben Hutchings wrote:
> irq_cpu_rmap_release() calls cpu_rmap_put(), which may free the rmap.
> So we need to clear the pointer to our glue structure in rmap before
> doing that, not after.
>=20
> Fixes: 4e0473f1060a ("lib: cpu_rmap: Avoid use after free on rmap->obj ..=
.")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

The patch LGTM, but please include the full blamed commit title into
the fixes tag. A new version will be needed.

Also add Jacob and Saeed to the cc-list

Thanks,

Paolo