Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c39cfc3f3113ebc30f08ea87781e9a81b0153d94.camel@redhat.com>
Subject: Re: [PATCH] net: liquidio: fix mixed module-builtin object
From:   Paolo Abeni <pabeni@redhat.com>
To:     Masahiro Yamada <masahiroy@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Derek Chickles <dchickles@marvell.com>,
        Satanand Burla <sburla@marvell.com>,
        Felix Manlunas <fmanlunas@marvell.com>,
        Eric Dumazet <edumazet@google.com>,
        Nick Terrell <terrelln@fb.com>
Date:   Tue, 06 Jun 2023 13:15:00 +0200
In-Reply-To: <20230604043213.901341-1-masahiroy@kernel.org>
References: <20230604043213.901341-1-masahiroy@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

Hi,

On Sun, 2023-06-04 at 13:32 +0900, Masahiro Yamada wrote:
> With CONFIG_LIQUIDIO=3Dm and CONFIG_LIQUIDIO_VF=3Dy (or vice versa),
> $(common-objs) are linked to a module and also to vmlinux even though
> the expected CFLAGS are different between builtins and modules.
>=20
> This is the same situation as fixed by commit 637a642f5ca5 ("zstd:
> Fixing mixed module-builtin objects").
>=20
> Introduce the new module, liquidio-core, to provide the common functions
> to liquidio and liquidio-vf.
>=20
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

This does not build with allmodconfig:

ERROR: modpost: "lio_get_state_string" [drivers/net/ethernet/cavium/liquidi=
o/liquidio.ko] undefined!
ERROR: modpost: "lio_get_state_string" [drivers/net/ethernet/cavium/liquidi=
o/liquidio_vf.ko] undefined!

Please, when you repost include the 'net-next' tag into the subj.

Thanks!

Paolo