Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <nycvar.YFH.7.76.2306052334360.29760@cbobk.fhfr.pm>
In-Reply-To: <nycvar.YFH.7.76.2306052334360.29760@cbobk.fhfr.pm>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Tue, 6 Jun 2023 05:19:26 -0700
Message-ID: <CAHk-=wiMbF38KCNhPFiargenpSBoecSXTLQACKS2UMyo_Vu2ww@mail.gmail.com>
Subject: Re: [GIT PULL] HID regression fix
To:     Jiri Kosina <jikos@kernel.org>
Cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jun 5, 2023 at 2:39=E2=80=AFPM Jiri Kosina <jikos@kernel.org> wrote=
:
>
> - Final, confirmed fix for regression causing some devices connected via
>   Logitech HID++ Unifying receiver take too long to initialize (Benjamin
>   Tissoires)

Thanks.

The 'don't use goto' looks good, but can we simplify things further?

In particular, this kind of loop is why "do { } while ()" exists.

But also, testing "ret" in that end condition is all kinds of strange.
It smells of Pascal loops, because Pascal didn't have any sane control
flow (little known fact: in a rare show of self-reflection, "Pascal"
was named to sound like the Finnish word "paska", meaning "shit").

The *sane* thing to do is not to test "ret" in the loop condition, but
just add the obvious control flow - so the code that wants to retry
should just do 'continue' in that loop.

Then the loop itself ends up being just

        do {
                ...
        } while (--max_retries);

and we don't need any fake initialization of 'ret'.

Anyway, just a thought.

It would also simplify things a lot if that function was split up so
that you'd have that whole loop in a helper function. That way it
could just use "return ret" or whatever, with the mutex_lock/unlock in
the caller.

Btw, it does look like the code is mixing two different kinds of
return types in 'ret': regular Linux error numbers as negative
numbers, but then possibly positive "HIDPP status" values that it gets
from the report (ie

        ret =3D response->rap.params[1];

ends up being returned as a value, mixed with

        ret =3D -ETIMEDOUT;

so which is it? A negative error, or a positive HID report byte value? Or b=
oth?

             Linus