Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <97d14e4a-956c-790f-f3e3-ec8174a9f0b1@ti.com>
Date:   Tue, 6 Jun 2023 18:38:10 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
From:   "Kumar, Udit" <u-kumar1@ti.com>
Subject: Re: [PATCH 4/7] arm64: dts: ti: k3-j7200-mcu: Add mcu_secproxy
To:     Nishanth Menon <nm@ti.com>
CC:     Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Tero Kristo <kristo@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Nitin Yadav <n-yadav@ti.com>, Andrew Davis <afd@ti.com>,
        <u-kumar1@ti.com>
References: <20230530165900.47502-1-nm@ti.com>
 <20230530165900.47502-5-nm@ti.com>
 <e25936b9-d85c-dfe8-0eb1-07b51fdfff1e@ti.com>
 <20230531173906.zznrzuxfytk5feun@spied>
Content-Language: en-US
In-Reply-To: <20230531173906.zznrzuxfytk5feun@spied>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 5/31/2023 11:09 PM, Nishanth Menon wrote:
> On 22:37-20230531, Kumar, Udit wrote:
> [...]
>>> +	secure_proxy_mcu: mailbox@2a480000 {
>> I think, we should start name as  mailbox@2a380000
>>> +		compatible = "ti,am654-secure-proxy";
>>> +		#mbox-cells = <1>;
>>> +		reg-names = "target_data", "rt", "scfg";
>>> +		reg = <0x0 0x2a480000 0x0 0x80000>,
>>> +		      <0x0 0x2a380000 0x0 0x80000>,
>>> +		      <0x0 0x2a400000 0x0 0x80000>;
>> I think, we should have increasing order for reg. Unless there is some
>> strong reason to keep in this way.
> Binding is defined this way - the items section in the binding
> enforces the order. As a result the first reg entry(target_data)
> address causes the node name.


Ok thanks, u boot defined in other way but i don't see problem post sync,

As u-boot driver is getting node address based upon name instead of index.


Reviewed-by: Udit Kumar <u-kumar1@ti.com>