Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp7100243rwd; Tue, 6 Jun 2023 06:26:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70RXNpyKBGUHpt3EznhP71gDrVClEG8pyhIRP43+JzFM03qyIbtMt8hyiz2Bm8hJDAs65u X-Received: by 2002:a05:6a21:3390:b0:107:35ed:28a7 with SMTP id yy16-20020a056a21339000b0010735ed28a7mr3339908pzb.8.1686057992167; Tue, 06 Jun 2023 06:26:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686057992; cv=none; d=google.com; s=arc-20160816; b=NtOYyGlrJcEeplMDmxBt6WWILxXTFUmc9F7ZsOUpdJzWnieAfvYqowK4J8Poy4nplJ oHVBAU3WRuX5AL9TwlFbph8fHjAnUpS5NSFb/aokFOhebTwNp/t3vUJwV6aIUrDeSXz1 cx+8yNMUuAvZbrMOfFCgBU6M85FZo+22/6OPERQdMVRCBpMY8RHa8ndFaMJxibsZ3b57 MrGbkwr5cWoraqCs54CcKoxSRIvXvcoBOzwaAPN425Jm4RDEaFecprVUC+nFYuiSkhSW 6J40uWlBBrUip/8suDYFesw0Tr7FlHhf8t+mbOoSG/m9jpAusdzx5GHjCgfvPelhgMy3 31tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=c0bH27ceGBQeOp+rBhSnwDdNl9Avm2uarJuWSZghpkk=; b=QGXCVER8DNWQ0j+UYJB4RJqddWxqIiPZPaY9ZcFzm7vcb7f2mwh/V1pSgJTQwAU/3U sokYs+utPoONOIuoqD667f8IMgDFEHoEUMzvd3hso3UHgjmyZRFGS4yJI0PDnYXfjaeq mvjkSP8dpw5dK5fRdCR1frB7Gdyu4h4CmDsXVSihAn4Iz9mf9n5bWNvdsdHyc3YXDscm 01SGhZ3ZkPyC3KQ0pOfKLD0cEfckr+ON/xWNrPihoIoscA9hGNSQXtsfBJzz7C0FAWR0 Qk7pYWMugOJLnuIdOnC17WJCZYG5+pT8WO1AJpkk/HSVXjsy5PtXUIJNa9oCExnWdRKZ pRCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BQGesQUR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v13-20020aa799cd000000b0065b4e2b52c5si3199956pfi.196.2023.06.06.06.26.19; Tue, 06 Jun 2023 06:26:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BQGesQUR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238067AbjFFNQJ (ORCPT + 99 others); Tue, 6 Jun 2023 09:16:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238087AbjFFNQG (ORCPT ); Tue, 6 Jun 2023 09:16:06 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EC1D118; Tue, 6 Jun 2023 06:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686057365; x=1717593365; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=v3p7uQcRR6XNTq+yMVmDqMHwxnP2B2IkM1YvBCLYXAQ=; b=BQGesQURCgKjdfTs/Qi7bOtGrJY6Bbx7uRBJgMTgg8VJYXPNbE24TUpo EyfkV8Qt+grzIdXdIvMVqzxdwGM0RRsmZKVZQSB528ruaE8FvCKEgk2zT xliL+JpMP8ItY4dp6orxQ67IEtWwInxr2NswKaqRQ5fBsKwissyDkox3Y 1ElU1vBxzoaK6M21+DERGzuAIr8lbW4wm2xbA5WqoKB0es46aKKMMtlNW fJDRvlJZqRfvRYzK6xD/gQKbuPQwdDmQpR+eRbTdhi4FU3HYlA7xVbhQf vIzfr5SfSZeDpm9DuumZGlr6r8iDkw/8xM2sYU8NeYMbZzXXm5L3/Q+xm w==; X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="341309596" X-IronPort-AV: E=Sophos;i="6.00,221,1681196400"; d="scan'208";a="341309596" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2023 06:06:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="659524655" X-IronPort-AV: E=Sophos;i="6.00,221,1681196400"; d="scan'208";a="659524655" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 06 Jun 2023 06:06:50 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1q6WOe-001dFm-32; Tue, 06 Jun 2023 16:06:48 +0300 Date: Tue, 6 Jun 2023 16:06:48 +0300 From: Andy Shevchenko To: Mika Westerberg Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v1 1/1] pinctrl: cherryview: Return correct value if pin in push-pull mode Message-ID: References: <20230605143734.73434-1-andriy.shevchenko@linux.intel.com> <20230606051116.GU45886@black.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606051116.GU45886@black.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2023 at 08:11:16AM +0300, Mika Westerberg wrote: > On Mon, Jun 05, 2023 at 05:37:34PM +0300, Andy Shevchenko wrote: > > Currently the getter returns ENOTSUPP on pin configured in > > the push-pull mode. Fix this by adding the missed switch case. > > > > Fixes: ccdf81d08dbe ("pinctrl: cherryview: add option to set open-drain pin config") > > Fixes: 6e08d6bbebeb ("pinctrl: Add Intel Cherryview/Braswell pin controller support") > > Signed-off-by: Andy Shevchenko > > Acked-by: Mika Westerberg Pushed to my review and testing queue, thanks! -- With Best Regards, Andy Shevchenko