Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp7105084rwd; Tue, 6 Jun 2023 06:30:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Z3d8KflFQNCF9qrZpITsPAZhEAzSA6f+uhBPRRmKLfdjyptuAXE2L5GlsdvvLavh21NPV X-Received: by 2002:a17:903:444:b0:1b1:d39e:28bb with SMTP id iw4-20020a170903044400b001b1d39e28bbmr979064plb.34.1686058228872; Tue, 06 Jun 2023 06:30:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686058228; cv=none; d=google.com; s=arc-20160816; b=EOeVgBCuwJkKcl+oL8Qam5QR6n9GBoHGF9a6dQL9g7iMI8rS+RXOqvHIFzgcYJmDYV oWnuThG6f+2+cxzQO/PyVOuxREuKJwzji2AMkHfpSoXSN5N0PnCngQX4KbpLutyWJE9w SL9yCXf0qMKBZQXk1UyZ+Lpc71GzUmGdh++RAJAjBa6RxHWzVZmfrPfW3IgKo3JqpKtS 1m3PeK2D8mqexy5cueRphlFASZskcnpzY6yEQWcILN5glEevHw7SFYpwXXqk9YIyDJpC b1bS/QlumJjVbwovKWBFWmgYl7Sc+f3Yj18imG/NZdnAkNQFNtfy2f6s5uOnrFtegNKD Koew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature:dkim-signature; bh=1ry1brdsrJRfV+nz796SZljGut/o/NXUU3oxJv26Cew=; b=LuCF4LuBApyTsQ4wX1TNZ/NtViW5tib4evHmgU1zzhRUHstuqUXPpN1IIp+ukogpq3 EQHkAKltJpprLo/0NOU5M9T1O+5K0sK+P5oVWBVXqDGB+1KUgV1/jpYRWhcrEqYzIdVz T3rXf3O8EayW4Eevus2yuJP0Dwr+Sj0cJ37ZGkXfasjSXjQBmYAqlwqQX2/F68qru6Er 6/gM03ZXHC8YAfTw8fb8cZ7daneQMfh/FlpSUNb+xxi5oq6/byWmP7yVMuG2zj/beeH9 Il2hxVSfbaOdByysmrrpirKAHbO4qynvASkB1K05CJDNz7XPpWz51uIYelRrMqpCx7mk F7mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=QF6dTVen; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j19-20020a170902759300b001ae52127485si7110530pll.433.2023.06.06.06.30.15; Tue, 06 Jun 2023 06:30:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=QF6dTVen; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237899AbjFFNFU (ORCPT + 99 others); Tue, 6 Jun 2023 09:05:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237942AbjFFNEz (ORCPT ); Tue, 6 Jun 2023 09:04:55 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BCB7118 for ; Tue, 6 Jun 2023 06:04:53 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 747C21FD69; Tue, 6 Jun 2023 13:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1686056692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ry1brdsrJRfV+nz796SZljGut/o/NXUU3oxJv26Cew=; b=QF6dTVenoKaE3oiLugeB9fWdYEAXWNwx6KIFIROhy2vWBkAo216da0Bqn90PZ7G41n4JUn u8CpwKcLiTcUc9WrAB11CU/Q5+vTyICuimywlH1esRXJivfzttJenHL103ePXaVqu9YooU V5z0EwuLHLHkMll5dGKOJwQQ6gTHtIc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1686056692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ry1brdsrJRfV+nz796SZljGut/o/NXUU3oxJv26Cew=; b=r/dVZVQynAjZje8GcSsAReUBc3KUGF3xbQOvV45Ac5iroSPSfiiW61ZShHjyRV+Io6zSuK msNiJesaolwAVnAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 54AC413776; Tue, 6 Jun 2023 13:04:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pcX4E/Quf2RJTwAAMHmgww (envelope-from ); Tue, 06 Jun 2023 13:04:52 +0000 Message-ID: <45151cfc-705a-9424-01c3-c2c7746b10ed@suse.cz> Date: Tue, 6 Jun 2023 15:04:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 6/5] mm: compaction: have compaction_suitable() return bool Content-Language: en-US To: Johannes Weiner , Andrew Morton Cc: Mel Gorman , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com References: <20230519123959.77335-1-hannes@cmpxchg.org> <20230602151204.GD161817@cmpxchg.org> From: Vlastimil Babka In-Reply-To: <20230602151204.GD161817@cmpxchg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/2/23 17:12, Johannes Weiner wrote: > Since it only returns COMPACT_CONTINUE or COMPACT_SKIPPED now, a bool > return value simplifies the callsites. > > Suggested-by: Vlastimil Babka > Signed-off-by: Johannes Weiner Acked-by: Vlastimil Babka Thanks!