Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 13:56:01 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Raag Jadav <raagjadav@gmail.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: act8945a: rely on hardware for operating
 mode
Message-ID: <8fecb30c-a42a-4cf2-8ad7-6795149c2d29@sirena.org.uk>
References: <20230605104830.68552-1-raagjadav@gmail.com>
 <04b8fa24-e5a8-4871-a397-f1c0c886449a@sirena.org.uk>
 <20230605143103.GA3068@pc>
 <545d3463-ce56-41d5-9d95-55764c448c09@sirena.org.uk>
 <20230605161614.GA6548@pc>
 <42423085-2c9c-47f6-9588-3e2260da7cfa@sirena.org.uk>
 <20230606070007.GA4691@pc>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="fuHrU8yFPMu7b9nu"
Content-Disposition: inline
In-Reply-To: <20230606070007.GA4691@pc>
Precedence: bulk


--fuHrU8yFPMu7b9nu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 06, 2023 at 12:30:07PM +0530, Raag Jadav wrote:
> On Mon, Jun 05, 2023 at 05:30:36PM +0100, Mark Brown wrote:

> > If we have those then we've got a bigger problem, for example we might
> > switch to a lower power mode which can't support the load we're trying
> > to get the consumer to run.

> Yes, but in such cases it will atleast report whatever mode currently
> set in the hardware and not the incorrect one stored locally in the memory,
> and this way I think we have a better chance of finding out that
> there indeed is a problem.

If this is a concern you should add something that verifies that the
mode hasn't changed underneath the driver, this won't actually detect
any corruption - it just might silently fix it.

--fuHrU8yFPMu7b9nu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmR/LOEACgkQJNaLcl1U
h9By6wf/UAf816pXODyf69JrmhF+3TMa9gCdZxkn651HdSpPYdf0r6Jo4AQkSMB+
LgVMyRI4VcnPRgWv196BX8ydZO43DWiJ3RHh8Dw6dIsq/G32wIiS6CnXayaeBtxe
1HerFTUIVZic7ITpXzlMqK4oibbBWXaB56RfxUVRTpPE3JfnBYrmiPUQt2p5iQLW
akfqOlUHW3uHUTeZiOy0NM86p6ajuZY5K7aloE68Ss3XbdZ+I7R8VNEBCuJuAbAw
LRbU4TT774YLrafN1zNwhIB5bSx53UbiMreLSNcsMHcT2HPvro00oM+a48fBIQbx
Xqkt+PetPLIX07oTqvGlAWJu2NRlQg==
=CCzN
-----END PGP SIGNATURE-----

--fuHrU8yFPMu7b9nu--