Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 14:47:58 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Moti Haimovski <mhaimovski@habana.ai>
CC:     <gregkh@linuxfoundation.org>, <david.m.ertman@intel.com>,
        <ogabbay@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] make AUXILIARY_BUS config selection clearer
Message-ID: <20230606-aspirate-evident-00b27a98a718@wendy>
References: <20230606133528.197335-1-mhaimovski@habana.ai>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="uHq986Popr/Gh4ku"
Content-Disposition: inline
In-Reply-To: <20230606133528.197335-1-mhaimovski@habana.ai>
Precedence: bulk

--uHq986Popr/Gh4ku
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Moti,

On Tue, Jun 06, 2023 at 04:35:28PM +0300, Moti Haimovski wrote:
> Add a display string and a help section to the config AUXILIARY_BUS
> section under the "Generic Driver Options" menu in order to make its
> selection clearer.

I am a wee bit confused, since it is not explicitly mentioned here, why
is this now going to be user visible/selectable? What was wrong with the
drivers that needed it selecting it?

Thanks,
Conor.

>=20
> Signed-off-by: Moti Haimovski <mhaimovski@habana.ai>
> ---
>  drivers/base/Kconfig | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index 6f04b831a5c0..e1caac1d9a58 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -2,7 +2,16 @@
>  menu "Generic Driver Options"
> =20
>  config AUXILIARY_BUS
> -	bool
> +	bool "Support for auxiliary bus"
> +	help
> +	  The auxiliary bus driver provides a way to export an interface
> +	  for another subsystem to drive, implement a common intersection
> +	  of functionality or split a function into child-devices
> +	  representing sub-domains of functionality where each auxiliary
> +	  device represents a part of its parent functionality (usually)
> +	  driven by another driver.
> +
> +	  If unsure, say Y.
> =20
>  config UEVENT_HELPER
>  	bool "Support for uevent helper"
> --=20
> 2.25.1
>=20

--uHq986Popr/Gh4ku
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZH85DgAKCRB4tDGHoIJi
0t5AAP0bTTjHQ7O3y57NL+qc5ttrvsyuHiwjgeWw6dBey3/ZVQEA53tEP14yxKtq
EuyAnK4BJvQhOGn5H17ry0vM6tXJ1gk=
=BjK9
-----END PGP SIGNATURE-----

--uHq986Popr/Gh4ku--