Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <jassisinghbrar@gmail.com>, <mathieu.poirier@linaro.org>,
        <mturquette@baylibre.com>, <sboyd@kernel.org>,
        <quic_eberman@quicinc.com>, <quic_mojha@quicinc.com>,
        <loic.poulain@linaro.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-remoteproc@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <quic_srichara@quicinc.com>, <quic_sjaganat@quicinc.com>,
        <quic_kathirav@quicinc.com>, <quic_anusha@quicinc.com>,
        <quic_poovendh@quicinc.com>, <quic_varada@quicinc.com>,
        <quic_devipriy@quicinc.com>
Subject: Re: [PATCH V2 01/13] dt-bindings: remoteproc: qcom: Add support for multipd model
References: <20230521222852.5740-1-quic_mmanikan@quicinc.com>
        <20230521222852.5740-2-quic_mmanikan@quicinc.com>
        <7940c743-815f-f864-d015-43d7e916ecfa@linaro.org>
        <a1456f62-d0a7-d5ec-b379-db1b6035c89c@quicinc.com>
        <d187eafb-4a80-9479-d063-3a01b47d8efa@linaro.org>
        <feb0d11d-0930-d0b8-ab6e-cf477bbf114b@quicinc.com>
Date:   Tue, 06 Jun 2023 16:49:40 +0300
In-Reply-To: <feb0d11d-0930-d0b8-ab6e-cf477bbf114b@quicinc.com> (Manikanta
        Mylavarapu's message of "Tue, 6 Jun 2023 17:41:00 +0530")
Message-ID: <87edmoitu3.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Manikanta Mylavarapu <quic_mmanikan@quicinc.com> writes:

>>>>> +
>>>>> +    properties:
>>>>> +      compatible:
>>>>> +        enum:
>>>>> +          - qcom,ipq5018-wcss-ahb-mpd
>>>>> +          - qcom,ipq9574-wcss-ahb-mpd
>>>>> +          - qcom,ipq5018-wcss-pcie-mpd
>>>>
>>>> Keep rather alphabetical order (so both 5018 together).
>>>>
>>>> I also do not understand these at all. Why adding bus type to
>>>> compatible? This rarely is allowed (unless it is PCIe controller within
>>>> soc).
>>>>
>>> IPQ5018 SOC has in-built PCIE controller. Here QDSP6 will bring up
>>> external(PCIE) and internal (AHB) wifi radio's. To separate AHB, PCIE
>>> radio's properties, i have added bus type to compatible.
>>
>> It's the same device - WCSS - right? We do not create multiple nodes and
>> compatibles for the same devices. Bus suffixes are almost never parts of
>> compatibles.
>
>
> No it's not the same device. WCSS on inside IPQ5018 and WCSS attached
> via pcie to IPQ5018. Here QDSP6 managing both WCSS's.
>
> So for better clarity i will use attached SOC ID in compatible.
> Below are the new compatible's.
>
> - qcom,ipq5018-wcss-mpd //IPQ5018 internal radio
> - qcom,ipq9574-wcss-mpd	//IPQ9574 internal radio
> - qcom,qcn6122-wcss-mpd //IPQ5018 attached radio

What mandates that there's just one QCN6122 device attached to PCI?
Assuming fixed PCI configurations like that makes me worried.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches