Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <89201790-6578-8066-b6de-4834ea19463e@intel.com>
Date:   Tue, 6 Jun 2023 15:24:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3 0/1] gro: decrease size of CB
Content-Language: en-US
To:     Richard Gobert <richardbgobert@gmail.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <lixiaoyan@google.com>,
        <lucien.xin@gmail.com>, <alexanderduyck@fb.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230601160924.GA9194@debian>
 <3f6cd784-767e-02e3-0c30-c0dda12e51ab@intel.com>
 <20230605135821.GA8361@debian>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <20230605135821.GA8361@debian>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVFhK1N2RXR6WFZTbklFYmNmOXBmUGNOV1NiVmljQmZQQWk5MlRjME5Rb3I0?=
 =?utf-8?B?RHlBbTJsSEdxMzJRQjJPbTBYTE1KOXZ0S2M1T2RORjl1QnFlQTQvVmU0cXdC?=
 =?utf-8?B?YjRhaGNvYzBLM0g1TG9Wdm5Xc0o5a0RIcjlLaFRmQzRKandGRVhQQTE2WDZn?=
 =?utf-8?B?S2MxWldMdkFmNnFqaTF1VW53OHJkSmNnQmNwM0sxOFpZSDh2aTlpWFdDQjJp?=
 =?utf-8?B?b0o3WXZZOE9WVTFEeUtJNjM0NEpJVHVsWmJ4WGdkNjljbGV6aHk5NWxvS1NM?=
 =?utf-8?B?SEltSi9UNzhHcVNNanYrbjllNDR3N0I5ck9DWXN6eklHTFFnZ0V1NjZNamlI?=
 =?utf-8?B?NnlHYzdEY05vWHM1WkVIS0JXYmlyZDR2M0hzdGZEL2dQdUhRQkFRNXRXS2NP?=
 =?utf-8?B?MGhsQnBXcUwrV1p5T2J0UjhUNXdrRkwxQ3pjRFNKZFYwRG5xSStqZDZHVllT?=
 =?utf-8?B?b2xsc3VoN1NyQ0FqNjkyNyt0ZUJRcHJsd1RnWnpGRHZMT2huWGQzWGtaV29p?=
 =?utf-8?B?KzBKTmtPWkFYNVl4RThzbVc1dzJjZGE0L1hqcFlrU2FwVmVkVXVqMW44NTNW?=
 =?utf-8?B?dzNhNlV0V2hXQUhicGNyNTRTS0FLbEwwNm9EbzhUTnV4a0hhMGowaURtNlRY?=
 =?utf-8?B?RFBQQThDUnNETGhvN3g1Vno4bFMzT2dMb09LdWtwWkZ6N0xYODV1YjhKc2NJ?=
 =?utf-8?B?OWx0cVNxanhOWkVlRkZHa0N1TkFXejJQMjRTSi9YQ08zVkJGUTI4NHZsVUxq?=
 =?utf-8?B?aDRFUkdyT1pFZ0VBNGJZTkhSUEJRTnBML3FtbVpPOTJkS0FCOVBUNWZqL2Ft?=
 =?utf-8?B?Q28wbTVoYzFybEFCd1YvOE8yOVcvVHdWOWl6dDBpdU94M01ObkJpYmNHM20x?=
 =?utf-8?B?SnRTQ3A1MlROUjZETjNlSDRSemlDSjBGakJsWmswZG40NlVNZXRvMU5KV0ty?=
 =?utf-8?B?Zm85MmhXS0NxakhhVm95RlJoQkZPY09JSHJaSUE2WEVDMHpZUVA5M3IySVVs?=
 =?utf-8?B?WGR4bnlEV011eXBuMFh6MzJpOTNURXowb1ZERUo2YmVEdnB3enIxUE5EaWhh?=
 =?utf-8?B?bno4VUJlVE1xQVFQMTNaS0djY3puNUJWSFFmdEE4NjhnTXRJM2ZKMmxFN21Y?=
 =?utf-8?B?ZTdkUlJsc1NwZ2JqandCSHdsdmxYeWRSQjcrSG4rMWhFMjJnSXEyUjRyakVi?=
 =?utf-8?B?eVBTVVBjRDl0cDlaeXVhRTFsenFoQ2xQcDMrbUtteWhMY2hqU2ZsSkxXTk1U?=
 =?utf-8?B?T09oblZvVWNlK0pER0VlaUZocE1TUzVremtDSEdOYmZQdnlPc0cvYnpPUlgw?=
 =?utf-8?B?WU5GSEhCRmtUcG13SW43UnJneXBlTUZXbUVINGFsTU9BcXBJaXNDc2dFYnpZ?=
 =?utf-8?B?RWtPa0dXK2djZHkwWHJoM21jRjZ3TWRhK3BYWTRMemIvaE1IYWlJN1lHZ0VN?=
 =?utf-8?B?OFZPY2w1Wm1VK0dFRkdYNFJiVnJORllha29VTE1tVEVBa0hSTTJrWTVkV1N1?=
 =?utf-8?B?MThoNHZ6OVNYSnRNQTVONWZkNmZ4YlRVU3lHZ2dSZXFxRE9uQU12cm5HR2lP?=
 =?utf-8?B?QXJrbU5OM1BOU0VEMUx2VEpydDZYOGhNbkVVaU1RcVJFRHZadjEzUGE2dWd4?=
 =?utf-8?B?U3ZKMG9hV0p5bHdNdkNDQkNFV0ZxdnlycmhMSXBJTkdFdkQwa3FoMkE3R1VK?=
 =?utf-8?B?ZnVHZzhkdEhxMlJ4YlVvd0tSajN4UnFnUENPbHBWTzFoTGR0VkhON1g5WVVm?=
 =?utf-8?B?YkpGS05TeVVHbVhVcWtwbTVzandvRW1TT2tJZFI5djNPU24zTncyNzNId0kr?=
 =?utf-8?B?U3gxdnk4UTFJbFNwMHRrMGw1RU5HMTVFSHJDcFZUVStrNVc1dnhGYlNsMU5l?=
 =?utf-8?B?Ukg2bE9aamxjdE9GMm84ZExBbzNycHZXQU4wSEpqTGVzV0Z5SW1EcFZzR0Fm?=
 =?utf-8?B?QUNySzEwRVZFMk1NUnJJc2NNM2tEWFhGWVJFUUNCaFFTS1ZKZFFNWldKTFpy?=
 =?utf-8?B?dE5rVSt3enJJcVJWV3dtS1lsb3dWeVpqVTNhcEt6VkRYeW1Ed0trNWt6ZnI5?=
 =?utf-8?B?VWVDS3FqNlR4SUxGbExGYzNiTnQ1M24reVZSRWlZVGZkNjJNT25tcFBQbVda?=
 =?utf-8?B?WWlGQ2UyVWN5TkZuT3JrMDh5dTdZOG4wM3dpY2t1ZHhtYWd0L25aeHJFS09M?=
 =?utf-8?B?Qmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d21bb6c-376b-4844-cefa-08db669196f9
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 13:26:09.4544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C0/0APax1Twk6OA8RYAMQoU7VqDKmxi/neYeWVOR2jSR8eTds8F99gw/RccYjUdTc9F8vBOcGzQ8+OLl3h/oL3M7eKxhq35gRO0q3m7cfzk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5810
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Richard Gobert <richardbgobert@gmail.com>
Date: Mon, 5 Jun 2023 15:58:23 +0200

>> I hope you've checked that there's no difference in object code with and
>> w/o `inline`? Sometimes the compilers do weird things and stop inlining
>> oneliners if they're used more than once. skb_gro_reset_offset() is
>> marked `inline` exactly due to that =\
> 
> Checked on standard x86-64 and arm64 gcc compilers.
> Would you check any other cases?
I'd say it's enough, so no problem. Sometimes some odd things happen,
but you can never predict all of them.
I can't give Reviewed-by now that it has been already applied :D Had a
long weekend and all that. But the change is really good.

Thanks,
Olek