Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230511-tps65219-add-gpio-support-v4-0-b5d6a764d722@baylibre.com>
 <20230511-tps65219-add-gpio-support-v4-1-b5d6a764d722@baylibre.com>
 <ZHXZBCwk6tTu8gjY@surfacebook> <e487f966-aafb-7d21-935d-b1d0ac7c21ac@baylibre.com>
In-Reply-To: <e487f966-aafb-7d21-935d-b1d0ac7c21ac@baylibre.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 6 Jun 2023 17:36:14 +0300
Message-ID: <CAHp75Vfu0V_nqy-0tdOM31onZn-P+mGDXJO5CnC4GkuVqYvvdQ@mail.gmail.com>
Subject: Re: [PATCH v4 1/2] gpio: tps65219: add GPIO support for TPS65219 PMIC
To:     jerome Neanne <jneanne@baylibre.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Tony Lindgren <tony@atomide.com>, Lee Jones <lee@kernel.org>,
        khilman@baylibre.com, msp@baylibre.com, francesco@dolcini.it,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-omap@vger.kernel.org,
        Jonathan Cormier <jcormier@criticallink.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 6, 2023 at 3:45=E2=80=AFPM jerome Neanne <jneanne@baylibre.com>=
 wrote:
> On 30/05/2023 13:07, andy.shevchenko@gmail.com wrote:
> > Tue, May 30, 2023 at 09:59:59AM +0200, Jerome Neanne kirjoitti:

...

> >> Datasheet describes specific usage for non standard GPIO.
> >> Link: https://www.ti.com/lit/ds/symlink/tps65219.pdf
> >
> > Can you convert this to be a Datasheet tag? Currently even Link is *not=
* a tag
> > because there must be no blank lines in the tag block.
> >
> >> Co-developed-by: Jonathan Cormier <jcormier@criticallink.com>
> >> Signed-off-by: Jonathan Cormier <jcormier@criticallink.com>
> >> Signed-off-by: Jerome Neanne <jneanne@baylibre.com>
> >
> I misinterpreted this comment. I looked at wrong examples but I think I
> understand now that the right usage is to have all the tags grouped
> together into one block which is delimited by blank lines before and
> after the whole block.

(Note, there is no "after", tag block is the last in the commit message)

> I'll then do this and put all the Datasheet/Link into the tag block.
> Stop putting Links inside the commit message right after I refer to it.
> https://www.kernel.org/doc/html/latest/process/5.Posting.html#patch-forma=
tting-and-changelogs

--=20
With Best Regards,
Andy Shevchenko