Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 16:04:43 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Moti Haimovski <mhaimovski@habana.ai>
Cc:     Conor Dooley <conor.dooley@microchip.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "david.m.ertman@intel.com" <david.m.ertman@intel.com>,
        "ogabbay@kernel.org" <ogabbay@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] make AUXILIARY_BUS config selection clearer
Message-ID: <20230606-sushi-clunky-8e816f5b206d@spud>
References: <20230606133528.197335-1-mhaimovski@habana.ai>
 <20230606-aspirate-evident-00b27a98a718@wendy>
 <AM9PR02MB7706888212798FE0CC8213D6D152A@AM9PR02MB7706.eurprd02.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="3we3bV80r3awbsJU"
Content-Disposition: inline
In-Reply-To: <AM9PR02MB7706888212798FE0CC8213D6D152A@AM9PR02MB7706.eurprd02.prod.outlook.com>
Precedence: bulk


--3we3bV80r3awbsJU
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 06, 2023 at 02:50:21PM +0000, Moti Haimovski wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> > On Tue, Jun 06, 2023 at 04:35:28PM +0300, Moti Haimovski wrote:
> > > Add a display string and a help section to the config AUXILIARY_BUS
> > > section under the "Generic Driver Options" menu in order to make its
> > > selection clearer.
> >=20
> > I am a wee bit confused, since it is not explicitly mentioned here, why=
 is this
> > now going to be user visible/selectable? What was wrong with the drivers
> > that needed it selecting it?

(please don't top post)

>  Noting is wrong with the drivers =F0=9F=98=8A
>=20
> I've stumbled that issue when trying to figure-out how to manipulate the =
auxiliary-bus selection
> Via "make menuconfig"
> The issue is that with the current Kconfig when you run " make menuconfig=
" and enter the
> Device Drivers --->     Generic Driver Options --->   Sub-menu then there=
 is no mentioning of
>  the Auxiliary bus although it is the first entry in drivers/base/Kconfig=
 that this menu is presenting.
> So, the user has no idea that this option exists and no way to manipulate=
 it via menconfig.

That's the point of how it currently is though, no?
We don't allow users to set the option, but rather any device driver
that needs it, selects it.
That way, a person configuring their kernel for some hardware just needs
to enable the drivers for their hardware and knowledge of kernel
internals is not needed.

Is there a particular driver, perhaps in drivers/accel, that does not
select the option, which is why you are trying to set it yourself?

Cheers,
Conor.

> My commit makes this option "visible" by adding the short description in =
the "bool" line
> and , while at it, adding a short description for the sake of future gene=
rations.
> No functionality nor default values were altered.

> > >
> > > Signed-off-by: Moti Haimovski <mhaimovski@habana.ai>
> > > ---
> > >  drivers/base/Kconfig | 11 ++++++++++-
> > >  1 file changed, 10 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index
> > > 6f04b831a5c0..e1caac1d9a58 100644
> > > --- a/drivers/base/Kconfig
> > > +++ b/drivers/base/Kconfig
> > > @@ -2,7 +2,16 @@
> > >  menu "Generic Driver Options"
> > >
> > >  config AUXILIARY_BUS
> > > -	bool
> > > +	bool "Support for auxiliary bus"
> > > +	help
> > > +	  The auxiliary bus driver provides a way to export an interface
> > > +	  for another subsystem to drive, implement a common intersection
> > > +	  of functionality or split a function into child-devices
> > > +	  representing sub-domains of functionality where each auxiliary
> > > +	  device represents a part of its parent functionality (usually)
> > > +	  driven by another driver.
> > > +
> > > +	  If unsure, say Y.
> > >
> > >  config UEVENT_HELPER
> > >  	bool "Support for uevent helper"
> > > --
> > > 2.25.1
> > >

--3we3bV80r3awbsJU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZH9LCwAKCRB4tDGHoIJi
0vX6AP9/NyNe1fyjqCokekCcjpV4dKKOAydB2/cskrWlxwBVBgEAp0FJn83ZrE4N
4Ev7fSyaFMJazT0d91h/Nx+5OpjUtgg=
=hRaY
-----END PGP SIGNATURE-----

--3we3bV80r3awbsJU--