Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp7286983rwd; Tue, 6 Jun 2023 08:40:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5rMPAlPQTyKXGV/GGhPNgTKb0CNruXElXwxGg+FJeqrjO+gAAvoM78dsBwMLCcOzNU/HI6 X-Received: by 2002:a05:6214:f26:b0:62b:53b0:70b0 with SMTP id iw6-20020a0562140f2600b0062b53b070b0mr3511760qvb.31.1686066012962; Tue, 06 Jun 2023 08:40:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686066012; cv=none; d=google.com; s=arc-20160816; b=ZfOAtQkliIIles976dvP87mcndrbqIIbH9ou8WaaIIDo1JzM3QCoyW6ftSYzbO3vgl GYMlq0v2nY0SHhRqsdP42ZCNW/njUSNEK/sEzWxHjx5iPhVAuLfMNAKe/aYZqKS3B6qQ q2Y8mvMZz0wp9Shf6dPzdVt6Ugu7wQUpR9cLQTuYF7E6arfIpQTIvs29MeVFomGAgHaq Yz9kY/DZofSSOvp/yn902EzNsAbBFlcvE8Pa8S39KyELkOk9fmjCjbWmpbty6u9/8qHn /HSh9IxgXRhQwS2XQxusWzns84pytGT4Ed5acz0wzpNKZFak5AOKP0mjMvwZ15DDhZHp iAfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=yLrFPj4YCkNrkAGMm7kARS2Wc6D5VcmWcYHngAysUi0=; b=ZmHlH51fyPtCFNa9Uzs2fUSsZZnURBgpCeEeqW0VbF+0715nG9X9bALMomLJovfano cmiJb//IgpEKmdG5wcf3TNRmdHpiE7ZS84Qs0cnVwE3IXBTPAFZDUG+IHQvShecfNrF7 cMHuYXa54PAJpnlXvisviWHfFZbXx/qaJO7TMyjOTOqYakCITQdpkKn0JhRm8MYmJfz4 ZlhivIKhcSaHH8wGxZrl7kZNYjVg2tKcWwoliCbqrqAcH8uzMKxh7Eh2MJBhsPITBFgq pKmgYRKN9+jX+BQzbL6IBKA9GVDuupsnynX51kiedB2eKqIDBkn1UzOUovBG9C+mFt34 cC0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GRl5JEma; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t3-20020a05622a148300b003f530fda2cdsi6624676qtx.62.2023.06.06.08.39.57; Tue, 06 Jun 2023 08:40:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GRl5JEma; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233480AbjFFPA4 (ORCPT + 99 others); Tue, 6 Jun 2023 11:00:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237570AbjFFPAw (ORCPT ); Tue, 6 Jun 2023 11:00:52 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5254F199A; Tue, 6 Jun 2023 08:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686063632; x=1717599632; h=date:from:to:subject:message-id:references:mime-version: in-reply-to; bh=Wlt2kIy2P85sLJKYJcYLugIw7E4/N60edZHtxt3m85U=; b=GRl5JEmaL42TojDnT2ogGotMuBqFe2i+QXkA5R9q2NaqeVo2eLzKrx/w WLr6dr2+veTEFt/AdiAfJypKIaw0yOIaJ6Uk6uIw5vRnE4HKgdZO21fxx nOKg91idLQ8Jh2s/sLRTbrEyWRlB1z5wd1nfiQq1Rqd+ym+vfal0e8EfB 2LyNEJt+iUD/JKzznCqUidNs/jv2zsQSRxKE5iZOAVaWi7gJSWOl2C8yR ja08Qabfk3HjLeuyCB5BJ0WjdYA9Efzgt+6p8u07urMAzV5YxWTN4c0IT IyiY64WMD2oOC6DfuqMbUjeNonhYQfAaqrLd7EcdHVxKLtHMLBbffiPDp Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10733"; a="337052481" X-IronPort-AV: E=Sophos;i="6.00,221,1681196400"; d="scan'208";a="337052481" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2023 07:58:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10733"; a="955791278" X-IronPort-AV: E=Sophos;i="6.00,221,1681196400"; d="scan'208";a="955791278" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 06 Jun 2023 07:58:37 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1q6Y8q-001gP3-1g; Tue, 06 Jun 2023 17:58:36 +0300 Date: Tue, 6 Jun 2023 17:58:36 +0300 From: Andy Shevchenko To: Jens Axboe , Greg Kroah-Hartman , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/9] pktdvd: Clean up the driver Message-ID: References: <20230310164549.22133-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310164549.22133-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 10, 2023 at 06:45:40PM +0200, Andy Shevchenko wrote: > Some cleanups to the recently resurrected driver. Anybody to pick this up, please? > v2: > - added tags (Greg) > > Andy Shevchenko (9): > pktcdvd: Get rid of custom printing macros > pktcdvd: replace sscanf() by kstrtoul() > pktcdvd: use sysfs_emit() to instead of scnprintf() > pktcdvd: Get rid of pkt_seq_show() forward declaration > pktcdvd: Drop redundant castings for sector_t > pktcdvd: Use DEFINE_SHOW_ATTRIBUTE() to simplify code > pktcdvd: Use put_unaligned_be16() and get_unaligned_be16() > pktcdvd: Get rid of redundant 'else' > pktcdvd: Sort headers > > drivers/block/pktcdvd.c | 525 +++++++++++++++++------------------ > include/linux/pktcdvd.h | 1 - > include/uapi/linux/pktcdvd.h | 1 + > 3 files changed, 257 insertions(+), 270 deletions(-) > > -- > 2.39.1 > -- With Best Regards, Andy Shevchenko