Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp7305066rwd; Tue, 6 Jun 2023 08:55:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5FQdPVH/v/kdfmWUhqmi/zNb0jeH3gT7Mt7heeEtOFZu1uLO6Duydq1swyHxhNetIP3iLz X-Received: by 2002:a17:90a:30d:b0:259:9824:5cce with SMTP id 13-20020a17090a030d00b0025998245ccemr2740371pje.18.1686066950479; Tue, 06 Jun 2023 08:55:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686066950; cv=none; d=google.com; s=arc-20160816; b=vULSpASsqMHW+zgSZyTN44iH+t7blFOvWKGbAnsRJCysbXJF88J/pdUNazVhDw+AMX TEDIpyVVocSbvK2BjIOZOA3ITDPRREMGZAHp3WRWjwsHjoP6saHRD/Y8kBUlCXm1mytg 2FiVZb1UgrLuD7tmSKjRwjUCnN4oS4qvsiJmK5GvMt6E99vFNCosi1OSVAcLEwW9GNrC xu1MS7LIVhKx7AyaHsalB4YErv2rk63V3qIRUudd9NCWC+Y1WYzEedZXJ5QryrxRic8H 9Nozdv3ONAxtOdHpOJAbwfoG6Porn05k75EGqfsyZJragd0grf2tQOTEjJFwh3TAJNJV 8jXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=zIRZuOqdc1wbgXJlnttVCJmlBEYYHdfUu9cmmFB8VxI=; b=nkv/cyXnZKIWZKBYg8vn07dd4t0vbyFkQsEk+9UKI6rVRrp95OvKNWzZ4br7LF4LEl IPbiX1k2HOPg2o++SOyuuW/UcWWndROfcQId7qHmy97bZ1F8HjUivt7/e0Nh2nhBWD9r F4/0E7mOZOFUN3fjvPvU4lfo+S8p53CFf9sYujuSgdrn7m3jITLip7cWFVs2WHtUdPUE MmCFP0x/aStaSyEErkgnCNfxXpNCcW111dLIg5FX9Ies5I1GoUVt78A9ZLqbbWzPXu/k 8fBdjTUNVyc3HsFivbFyyC/TDC1H/q9GhgJacJtautj3leN1/IgXeksJb4LMjgllp4W+ gHXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=MLYden4P; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lk14-20020a17090b33ce00b002533a4c9ed9si8336046pjb.21.2023.06.06.08.55.38; Tue, 06 Jun 2023 08:55:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=MLYden4P; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236500AbjFFPqE (ORCPT + 99 others); Tue, 6 Jun 2023 11:46:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236713AbjFFPp5 (ORCPT ); Tue, 6 Jun 2023 11:45:57 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B661110F9 for ; Tue, 6 Jun 2023 08:45:49 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 470E0219EB; Tue, 6 Jun 2023 15:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686066348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zIRZuOqdc1wbgXJlnttVCJmlBEYYHdfUu9cmmFB8VxI=; b=MLYden4PysPezLPwrVom0z5h5s95w2GwZow9JKezerxq2xCF7YQMZPeqFUAi+KVCizPfc2 hZwhajDMwcbvl4NjtmuFaPmJCxOu73+5Vj1SA50ECcPISp3DHfkI3oSGOQE0zMK5VmUrTn RZ4MD2roba8ViLEiKxjUaLuSeoVhHLQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686066348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zIRZuOqdc1wbgXJlnttVCJmlBEYYHdfUu9cmmFB8VxI=; b=ULrI3S/cmX13oY3UQO9BrjqTNsERUYy1MVZRjyqCIv68tBuQqOtw+WTqDUu36RxKtqu8w3 M4kWjrbq1vmbK/Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1FDA313776; Tue, 6 Jun 2023 15:45:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yprpBqxUf2TmJwAAMHmgww (envelope-from ); Tue, 06 Jun 2023 15:45:48 +0000 Date: Tue, 06 Jun 2023 17:45:47 +0200 Message-ID: <877csgfvbo.wl-tiwai@suse.de> From: Takashi Iwai To: Chris Chiu Cc: perex@perex.cz, tiwai@suse.com, sbinding@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Enable 4 amplifiers instead of 2 on a HP platform In-Reply-To: <20230606145747.135966-1-chris.chiu@canonical.com> References: <20230606145747.135966-1-chris.chiu@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Jun 2023 16:57:47 +0200, Chris Chiu wrote: > > In the commit 7bb62340951a ("ALSA: hda/realtek: fix speaker, mute/micmute > LEDs not work on a HP platform"), speakers and LEDs are fixed but only 2 > CS35L41 amplifiers on SPI bus connected to Realtek codec are enabled. Need > the ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED to get all amplifiers working. > > Signed-off-by: Chris Chiu Applied now with the manual addition of Fixes tag. At the next time, please don't forget to put the proper Fixes tag if you know the commit to fix. thanks, Takashi