Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 16:49:46 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Sunil V L <sunilvl@ventanamicro.com>
Cc:     linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Atish Patra <atishp@atishpatra.org>,
        Anup Patel <anup@brainfault.org>,
        Will Deacon <will@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v1 -next 2/2] RISC-V/perf: Use standard interface to get
 INTC domain
Message-ID: <20230606-scribe-discuss-b884605cb870@spud>
References: <20230605143512.707533-1-sunilvl@ventanamicro.com>
 <20230605143512.707533-3-sunilvl@ventanamicro.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="gwX9jHrHYHhC33x/"
Content-Disposition: inline
In-Reply-To: <20230605143512.707533-3-sunilvl@ventanamicro.com>
Precedence: bulk


--gwX9jHrHYHhC33x/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 05, 2023 at 08:05:12PM +0530, Sunil V L wrote:
> Currently the PMU driver is using DT based lookup to
> find the INTC node for sscofpmf extension. This will not work
> for ACPI based systems causing the driver to fail to register
> the PMU overflow interrupt handler.
>=20
> Hence, change the code to use the standard interface to find
> the INTC node which works irrespective of DT or ACPI.
>=20
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> ---
>  drivers/perf/riscv_pmu_sbi.c | 17 ++---------------
>  1 file changed, 2 insertions(+), 15 deletions(-)
>=20
> diff --git a/drivers/perf/riscv_pmu_sbi.c b/drivers/perf/riscv_pmu_sbi.c
> index 4f3ac296b3e2..0bc491252a44 100644
> --- a/drivers/perf/riscv_pmu_sbi.c
> +++ b/drivers/perf/riscv_pmu_sbi.c
> @@ -739,7 +739,6 @@ static int pmu_sbi_setup_irqs(struct riscv_pmu *pmu, =
struct platform_device *pde
>  {
>  	int ret;
>  	struct cpu_hw_events __percpu *hw_events =3D pmu->hw_events;
> -	struct device_node *cpu, *child;
>  	struct irq_domain *domain =3D NULL;
> =20
>  	if (riscv_isa_extension_available(NULL, SSCOFPMF)) {
> @@ -756,20 +755,8 @@ static int pmu_sbi_setup_irqs(struct riscv_pmu *pmu,=
 struct platform_device *pde
>  	if (!riscv_pmu_use_irq)
>  		return -EOPNOTSUPP;
> =20
> -	for_each_of_cpu_node(cpu) {
> -		child =3D of_get_compatible_child(cpu, "riscv,cpu-intc");
> -		if (!child) {
> -			pr_err("Failed to find INTC node\n");
> -			of_node_put(cpu);
> -			return -ENODEV;
> -		}
> -		domain =3D irq_find_host(child);
> -		of_node_put(child);
> -		if (domain) {
> -			of_node_put(cpu);
> -			break;
> -		}
> -	}
> +	domain =3D irq_find_matching_fwnode(riscv_get_intc_hwnode(),
> +					  DOMAIN_BUS_ANY);

This riscv_get_intc_hwnode stuff is horrific, but that's besides the
point.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

>  	if (!domain) {
>  		pr_err("Failed to find INTC IRQ root domain\n");
>  		return -ENODEV;
> --=20
> 2.34.1
>=20

--gwX9jHrHYHhC33x/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZH9VmgAKCRB4tDGHoIJi
0oFHAQCK0+LA4Hkdi2DZBS7TOsIy0vK07SpAap5peSAzvtbB9AD9HXu6oqENThnH
LWiUD5Y9PW0nx9C+Y9alXKaylYBWPwk=
=BJKN
-----END PGP SIGNATURE-----

--gwX9jHrHYHhC33x/--