Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp7335728rwd; Tue, 6 Jun 2023 09:16:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6axgfnF1s5Wm1vXOPZiYu2fTGRIJsTE3lCKG/lSk+cqtmrH/fYps/MsKBsPS4UICfUTKSx X-Received: by 2002:ac8:5847:0:b0:3f6:9106:c1c8 with SMTP id h7-20020ac85847000000b003f69106c1c8mr141192qth.30.1686068184981; Tue, 06 Jun 2023 09:16:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686068184; cv=none; d=google.com; s=arc-20160816; b=IKmS1BVW2MKug5RrF9gyC3TfBdSplewkYV3aMgW5kTKSMPPV62ymXoy1Xr994yan91 ZuMKn+9V9+kg4yROpyNO78BNjfCGR2wpE1+kd0q2GmSsF2fqmrb6/cKnA9Azz7BUOp1N 0kKl7Fgm+md83IddVp/jOJ9pCOUQFwnRTkigaqFn6Y4L4oBj0s/KZzZZeF2JdYP/oWUH +h6jD3b1prwuAwpVt2pypd4cJgUQJCZWdx3LFUVH1Pp1UcyfzAqKwY4vsE7msT90dbrO 0h1Wj2+pGyK7iWxTApmuNSOmGdQTK3k0l5yvgcYkxlY7vXHPowSWxsQsH1MT0xBt6kE+ WIAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=iKv88zQy9AHjl6SvTcmIaQh0SxmCmmNMKI+rBZMxvLE=; b=vQWnko895URjmJ2cfYfaCR04jatjB7+fWhfuIiH4OFFtZpk8VVYYG9zF3maAXuFvfY xluoDGG/XuOrMeKU3juTjoNXKGSwwfjUTmlA8NFrBi8I2n2jf6HDoxGiCQ19oB85k4tE cAnQWLrBpKrfaWvP2C9y5bMS5bUq9JevZmaOdbVyDqGXeWeP4EKJvnEQiz/PmpfpJHAW DnDbA/IWK2bDA0ZwdyY/SEkjdGFqSNR2wz9hwtIPtZecgf9KvTy1MiTcHBlyqgBvc3ZB eZRtnpVt8+4mIm6jonbM7osYNd5hxvFfumJ9kQcSaO7SsaaDs3HKUQQF6Yph9ugHJX/v GBEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r19-20020ac85c93000000b003f0acbd88f4si6220017qta.470.2023.06.06.09.16.03; Tue, 06 Jun 2023 09:16:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237212AbjFFQLs (ORCPT + 99 others); Tue, 6 Jun 2023 12:11:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229866AbjFFQLq (ORCPT ); Tue, 6 Jun 2023 12:11:46 -0400 X-Greylist: delayed 2498 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 06 Jun 2023 09:11:45 PDT Received: from finn.localdomain (finn.gateworks.com [108.161.129.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D43D10D5; Tue, 6 Jun 2023 09:11:45 -0700 (PDT) Received: from 068-189-091-139.biz.spectrum.com ([68.189.91.139] helo=tharvey.pdc.gateworks.com) by finn.localdomain with esmtp (Exim 4.93) (envelope-from ) id 1q6YdK-0067n4-A9; Tue, 06 Jun 2023 15:30:06 +0000 From: Tim Harvey To: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Cc: Guenter Roeck , Jean Delvare , Tim Harvey Subject: [PATCH] hwmon: (gsc-hwmon) fix fan pwm temperature scaling Date: Tue, 6 Jun 2023 08:30:04 -0700 Message-Id: <20230606153004.1448086-1-tharvey@gateworks.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The GSC fan pwm temperature register is in centidegrees celcius but the Linux hwmon convention is to use milidegrees celcius. Fix the scaling. Fixes: 3bce5377ef66 ("hwmon: Add Gateworks System Controller support") Signed-off-by: Tim Harvey --- drivers/hwmon/gsc-hwmon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/gsc-hwmon.c b/drivers/hwmon/gsc-hwmon.c index 73e5d92b200b..1501ceb551e7 100644 --- a/drivers/hwmon/gsc-hwmon.c +++ b/drivers/hwmon/gsc-hwmon.c @@ -82,8 +82,8 @@ static ssize_t pwm_auto_point_temp_store(struct device *dev, if (kstrtol(buf, 10, &temp)) return -EINVAL; - temp = clamp_val(temp, 0, 10000); - temp = DIV_ROUND_CLOSEST(temp, 10); + temp = clamp_val(temp, 0, 100000); + temp = DIV_ROUND_CLOSEST(temp, 100); regs[0] = temp & 0xff; regs[1] = (temp >> 8) & 0xff; @@ -100,7 +100,7 @@ static ssize_t pwm_auto_point_pwm_show(struct device *dev, { struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); - return sprintf(buf, "%d\n", 255 * (50 + (attr->index * 10)) / 100); + return sprintf(buf, "%d\n", 255 * (50 + (attr->index * 10))); } static SENSOR_DEVICE_ATTR_RO(pwm1_auto_point1_pwm, pwm_auto_point_pwm, 0); -- 2.25.1