Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230602054527.290696-1-gongruiqi@huaweicloud.com> <20230606032844.GA628899@mail.hallyn.com>
In-Reply-To: <20230606032844.GA628899@mail.hallyn.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Tue, 6 Jun 2023 12:45:00 -0400
Message-ID: <CAHC9VhT8k87SdD4_JQFwXShwJeBb3KU7C+R5ABAOhDGvvC0X+w@mail.gmail.com>
Subject: Re: [PATCH] capability: erase checker warnings about struct __user_cap_data_struct
To:     "Serge E. Hallyn" <serge@hallyn.com>
Cc:     "GONG, Ruiqi" <gongruiqi@huaweicloud.com>,
        linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Wang Weiyang <wangweiyang2@huawei.com>,
        Xiu Jianfeng <xiujianfeng@huawei.com>, gongruiqi1@huawei.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jun 5, 2023 at 11:29=E2=80=AFPM Serge E. Hallyn <serge@hallyn.com> =
wrote:
> On Fri, Jun 02, 2023 at 01:45:27PM +0800, GONG, Ruiqi wrote:
> > Currently Sparse warns the following when compiling kernel/capability.c=
:
> >
> > kernel/capability.c:191:35: warning: incorrect type in argument 2 (diff=
erent address spaces)
> > kernel/capability.c:191:35:    expected void const *from
> > kernel/capability.c:191:35:    got struct __user_cap_data_struct [noder=
ef] __user *
> > kernel/capability.c:168:14: warning: dereference of noderef expression
> > ...... (multiple noderef warnings on different locations)
> > kernel/capability.c:244:29: warning: incorrect type in argument 1 (diff=
erent address spaces)
> > kernel/capability.c:244:29:    expected void *to
> > kernel/capability.c:244:29:    got struct __user_cap_data_struct [noder=
ef] __user ( * )[2]
> > kernel/capability.c:247:42: warning: dereference of noderef expression
> > ...... (multiple noderef warnings on different locations)
> >
> > It seems that defining `struct __user_cap_data_struct` together with
> > `cap_user_data_t` make Sparse believe that the struct is `noderef` as
> > well. Separate their definitions to clarify their respective attributes=
.
> >
> > Signed-off-by: GONG, Ruiqi <gongruiqi@huaweicloud.com>
>
> Seems ok.
>
> There's still so much noise in the make C=3D2 output even just for
> kernel/capability.c that I'm not sure it's worth it, but no
> objection.
>
> Acked-by: Serge Hallyn <serge@hallyn.com>

I'm guessing you would prefer if I pulled this via the LSM tree Serge?

FWIW, if that is ever the case for future patches, just add a note
when you ACK something and I'll pick it up.

--=20
paul-moore.com