Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 20:13:51 +0300
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Siddh Raman Pant <code@siddh.me>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Suraj Upadhyay <usuraj35@gmail.com>
Subject: Re: [PATCH v9 5/8] drm: Remove usage of deprecated DRM_ERROR
Message-ID: <20230606171351.GK25679@pendragon.ideasonboard.com>
References: <cover.1686047727.git.code@siddh.me>
 <247297c1171bc0ddbde0e90d33961fd5636caf0f.1686047727.git.code@siddh.me>
 <20230606144452.GE5197@pendragon.ideasonboard.com>
 <18891ac9112.109b85f8126467.5521217359687209203@siddh.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <18891ac9112.109b85f8126467.5521217359687209203@siddh.me>
Precedence: bulk

On Tue, Jun 06, 2023 at 10:36:25PM +0530, Siddh Raman Pant wrote:
> On Tue, 06 Jun 2023 20:14:52 +0530, Laurent Pinchart wrote:
> > Hi Siddh,
> > 
> > Thank you for the patch.
> 
> Anytime :)
> 
> > >       if (!crtcs || !modes || !enabled || !offsets) {
> > > -             DRM_ERROR("Memory allocation failed\n");
> > > +             drm_err(client->dev, "Memory allocation failed\n");
> > 
> > We could probably drop this message as memory allocation functions are
> > already vocal on failure, but that's a separate fix.
> 
> Okay. Should I send a patch at the end of the series removing the
> superfluous messages you pointed out in drm core?

That would be nice, thanks.

> > >       if (!drm_core_init_complete) {
> > > -             DRM_ERROR("DRM core is not initialized\n");
> > > +             drm_err(NULL, "DRM core is not initialized\n");
> > 
> > Could this use dev ?
> 
> No, the drm_device's dev pointer is assigned later. See line 621.
> 
> > >       if (!vma_offset_manager) {
> > > -             DRM_ERROR("out of memory\n");
> > > +             drm_err(dev, "out of memory\n");
> > 
> > Same here, I think the message could be dropped.
> 
> Okay.
> 
> > >       if (!ht->table) {
> > > -             DRM_ERROR("Out of memory for hash table\n");
> > > +             drm_err(NULL, "Out of memory for hash table\n");
> > 
> > Same.
> 
> Okay.
>  
> > With the commit message fixed as mentioned in the review of an earlier
> > patch in this series, and the issue in drm_dev_init() addressed if
> > needed,
> > 
> > Reviewed-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com>

-- 
Regards,

Laurent Pinchart