Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 19:20:18 +0200
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
CC:     <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <alexis.lothore@bootlin.com>,
        <thomas.petazzoni@bootlin.com>, Andrew Lunn <andrew@lunn.ch>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "Alexandre Torgue" <alexandre.torgue@foss.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Simon Horman <simon.horman@corigine.com>,
        "Russell King" <rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH net-next v3 4/5] net: altera_tse: explicitly disable
 autoscan on the regmap-mdio bus
Message-ID: <ZH9q0t7u2rJT48LT@boxer>
References: <20230606152501.328789-1-maxime.chevallier@bootlin.com>
 <20230606152501.328789-5-maxime.chevallier@bootlin.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230606152501.328789-5-maxime.chevallier@bootlin.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5B1QcoyM4W1dC3yLmC/ptSUMjq0JcslZdOC48pr4dOYyf7dVP2r3DJb8CHfE?=
 =?us-ascii?Q?JJ/E7YipvatGO8kVd6TwG1j3hmGVIv5mH3GtzK5SEPcMHhbzi3KU6VEDq0PM?=
 =?us-ascii?Q?pMOoKT/Qj/fdJNj9bkjqmN+HMtGQeDA0iooOgIzlyURz7wEguaag3NfcvALY?=
 =?us-ascii?Q?qRUkTu21q1tolhe84tu4Gs+hdUAnEJUv+ZhpHPMtp0GBgJMmJ9GORVWg01lD?=
 =?us-ascii?Q?YGbQSEPPNEqG1SOF8qYVsSS7J8w8U9CcIRonsU26Q/w9RjczdHE+GldQa60n?=
 =?us-ascii?Q?2/Tf0GjQ/6NWnf+Xe36xwJdNTdNXfCC4b+hNh23cg5QAwV+ImT9oV1s7LnQk?=
 =?us-ascii?Q?VE/lvxptkZhLmhKO7KroeUzBU7vEFGzmG0AFv/tg+zdaNBSCGJGcavOu7Lvk?=
 =?us-ascii?Q?EdvEvTHxHnHBC4APViMHUcKwyA2wGUUy1Fgy7SOlJIS3CVynLhBzgscPdjAW?=
 =?us-ascii?Q?2eT/dXJ1xdDHPMuSo+bhFMEFSSU6hw5j2dN6Ero5BIgf0wl6GQrzk2VoVOUW?=
 =?us-ascii?Q?NtUQXCyCxUhyJ3py+W/hV46tinAlNLlYOUlywB+ZXRHTBwQjC36JbYwz+lg2?=
 =?us-ascii?Q?2gsc+xq+/A6o8MqpGLAGepaMux5djh3GCTp+SU9a3UdwtenFEiY5932q9Ys2?=
 =?us-ascii?Q?+YiyzADQ2mv2J0/inXhs9qJ2yRUI3j3amU/ClThh1EmT9bX9NppNGT1Jxhmc?=
 =?us-ascii?Q?751Xqw6JBu7U2K7edPbiAp7QfbLzgCgBTy47qX7+Whikcom1AhaYBCSsgzvw?=
 =?us-ascii?Q?S+Dk4Iq+u0qCq81r2C2cnNY/Yp7WAWGdjvJiZMJT/pVcL74HQGuGWU+Mhm6j?=
 =?us-ascii?Q?fbcZLp3iDqu/pYGG4l7BaQEvUrNcsQEIwv34zzLNXDYKU+8H9dedNLmsWrXs?=
 =?us-ascii?Q?nilZMbwRJXnltnAaY1SuiwuZ427na2YJScH7Mo6etwTrUDes8+YRX4TLMmTy?=
 =?us-ascii?Q?Yrzf8qk/2MhMSZJ5peuBuWEcqQCZlw/1+YXGJEGj9LnIgzbAnX+Oyg8m4rnT?=
 =?us-ascii?Q?UGuh/fDtg5vhM5qmCEEnW2JHtk8EL9StyNInnoPAdxSjtEVutTXbtq1CHxsi?=
 =?us-ascii?Q?hJCrSkitBUsdB2hIBEvcuN74WunTjJi1p5yC2a19WsyH4CaOsZHxy4VmvwyJ?=
 =?us-ascii?Q?C2gilXuhvdk3eqFozXgLkRCnnx6lBF6MnyslfXAV5C1YzylW69/xNYShOMEx?=
 =?us-ascii?Q?pWd1wSvCAeWmM6+LFksCSaJqbkC66z8oRWmB0fZQJjZuOlCNGpFjN4omY4vl?=
 =?us-ascii?Q?cez28kZ/giTlO3r1IZcHL/xCKqf4cyLx/e3ILLkIiglEmd3efObOJ0hQV/EM?=
 =?us-ascii?Q?WOrsNGMWerCwg0lha3iwK1pcPaahdoYH7wIfNiBiZIL69VgZECL4jS3seMny?=
 =?us-ascii?Q?MNqVQrtErIN4vpRXPJBbrzYojZUcc70FjH+OMlWbFfuXUWgpA1qDixcbl02N?=
 =?us-ascii?Q?g4K9s2lygA1uTsf5EnmxXEmVYG7JISEZL3NwGw4a3XpBlnKeYylVzanAlc+6?=
 =?us-ascii?Q?4643n1AhE16+HRQjhlFyt5CoQOJsx6VPfuel3lN+03mQwesUhNizU6EDGE74?=
 =?us-ascii?Q?siSlVv2jngTMpEySrsch2/x+5ISpoM9iDttqqedQ7D6N5j24RRE2kHdJ7t2o?=
 =?us-ascii?Q?H/Mnb+kC3gpisAsfRqw7YYE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c1f5f7b5-fdf7-49db-537d-08db66b2522b
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 17:20:27.3682
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C+dpSIhcMPKurD5fXHrNeQjAkwFzW+i+iESXUhqZkLctOQPt42EYu1QI1mTbZLocF8U8O8nJljOid9lddrMDZZVLAesMoFBMZvuxzU+IxBc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6519
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 06, 2023 at 05:25:00PM +0200, Maxime Chevallier wrote:
> Set the .autoscan flag to false on the regmap-mdio bus, to avoid using a
> random uninitialized value. We don't want autoscan in this case as the
> mdio device is a PCS and not a PHY.
> 
> Fixes: db48abbaa18e ("net: ethernet: altera-tse: Convert to mdio-regmap and use PCS Lynx")
> Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> V2->V3 : New patch
> 
>  drivers/net/ethernet/altera/altera_tse_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index df509abcd378..b0cb94fe6247 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -1287,6 +1287,7 @@ static int altera_tse_probe(struct platform_device *pdev)
>  	mrc.regmap = pcs_regmap;
>  	mrc.parent = &pdev->dev;
>  	mrc.valid_addr = 0x0;
> +	mrc.autoscan = false;

ah so there was uninited value on mrc :) can you please zero this out in
one of the patches?

>  
>  	/* Rx IRQ */
>  	priv->rx_irq = platform_get_irq_byname(pdev, "rx_irq");
> -- 
> 2.40.1
> 
>