Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 19:16:53 +0200
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
CC:     <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <alexis.lothore@bootlin.com>,
        <thomas.petazzoni@bootlin.com>, Andrew Lunn <andrew@lunn.ch>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "Alexandre Torgue" <alexandre.torgue@foss.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net-next v3 1/5] net: altera-tse: Initialize the
 regmap_config struct before using it
Message-ID: <ZH9qBYo/vkkUR3R1@boxer>
References: <20230606152501.328789-1-maxime.chevallier@bootlin.com>
 <20230606152501.328789-2-maxime.chevallier@bootlin.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230606152501.328789-2-maxime.chevallier@bootlin.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q3NAjH2+i/MH0BxlC7zaXslF2cWCIMeOh50mjZgO3PkbRJ6Pm0RXeOaUZYJv?=
 =?us-ascii?Q?GJ8v/ht/gbhaPe8h4vfbqhCyVFiVvtBSLk6mk7m3hcJQdWS3NVxOpz/nAWxP?=
 =?us-ascii?Q?FRM0um+twnzgw3q3/dqrde9vVwQ6XGGvpReOMBEXSwNwOkVqBvQ/9Pi5jnFp?=
 =?us-ascii?Q?6dOSEM5yb1nbf/M67xjpw9TPzZYnkk3ATNIIEP8t4UkvzHpxWiGkx/SSzLEd?=
 =?us-ascii?Q?WY/B36D5a/+GT4SafPVM8jF/KBHky4LsieTCUtM/AkTabUjAyk/MXayNPuBP?=
 =?us-ascii?Q?XCaEeRsEXNrvzhmzf4sfSknraWOeoRiBW8DTsbZuojlDat2DuEF4i5tLO//A?=
 =?us-ascii?Q?VmKPWkIvXzr5TGVLSx5IWlc3FO5LBnp7m6l0ucjN7MS53qUkTF/0IXqOkvFN?=
 =?us-ascii?Q?mcLWX579/dOkyNdZUYkzkYfJWf6o41E7LKplxWaSZjLtBWZsxieWtKMCK+nu?=
 =?us-ascii?Q?RsdFn6KeHjcULtv9hcE1gD8bPHn1d6L8LkZ8AiiSP12qe+3UaVs44SxnBUrT?=
 =?us-ascii?Q?bFakhbY08woJIs2CDOGpntnfxnYOfbwxX7zEOm6W4LKMhurZvOoPIjrijvxU?=
 =?us-ascii?Q?P5yOIbU7NQcI9wnOi7KQzbQDn6MpK2V2AC+YV2dxtrVCxqaHUFoQ8w7crulM?=
 =?us-ascii?Q?OKg4JQU9EbbzMXj3MICv5C5dFQPgPcNnBciVlTLxfANl66qKlH05dLsACSLp?=
 =?us-ascii?Q?vN75RHFc/lNK5UpUriwC9OehUVXpwfv9nsKt7Pqg8MvXQbgwaeNCJj9EgAeg?=
 =?us-ascii?Q?y9qF2q39jET+HAyn3r63txFH2V0+X/pKdk3EWT7CTzaFBlc9DoVpnO65++eX?=
 =?us-ascii?Q?ttJN3waH7Hqdhi0mVI8J7f7v/Lf6YboxjxfQnNuxllrRKTSKu0XaaxpjGXHh?=
 =?us-ascii?Q?U3VTExS/FarRpOgrZTW9/JKTz644IG4GR+a15L7CyuSB97AIMD2ouYc9l+ny?=
 =?us-ascii?Q?tYCBlTmZme0lr3A0AwOiOdFXJ0xLyZ6X88fr0Y+XnCBODmuXK97SR6fGMrpQ?=
 =?us-ascii?Q?AYaUdXP/QWIbmyufnWn7MyLZDjjzVihnWdj5aqszrLgGEFDl/f18Ijt/zakH?=
 =?us-ascii?Q?sXXWxKm3saSm9ze9xO9TSMNZ80lHpx4nADw97XFB5KF3gX0BJ4g9/wJIzK+R?=
 =?us-ascii?Q?5KUU38Y3K0ENDBUVSGH1yicYQKWx9SPm262lbIkyhS0IYWkC63ut4nI8N4/M?=
 =?us-ascii?Q?0WoMEjhlnFdE25CM8UHutd9XzaVFXZzN8boCXPYNCdHLSwymmlEEe/SqJwZy?=
 =?us-ascii?Q?xwmTqtKkDKFkzkLRYCpHp2pjapfQNCJs5TntdquFo2E9thWtRJAvpNGu0y1c?=
 =?us-ascii?Q?yh92o6/vUzLDw6g4QUta9FoTz3d42/3z67GhZTbse665shg+8cmFv7vzFk+7?=
 =?us-ascii?Q?AV3MdkhdJlcaDbevNzTUHb1v6j+viI9g2CIB01k7MYso5aAfXf1ZKwCOlGet?=
 =?us-ascii?Q?ruk0Wcviu6gPX7zmY87HcHtYritTuYzlUTjyNNFUvaWti2hEnCpCXniSOWwV?=
 =?us-ascii?Q?Y71ebTsATDLSOlo/9xOnv0ZSD6dSd/D6OZNn5RaXgrKygx5yunDejxWFQx96?=
 =?us-ascii?Q?lFXAxs2UglMzEhE/3OSmsu1w5FLZ9IeANGjFqeIYZG2nZcR7FI91FfU1a0f/?=
 =?us-ascii?Q?tCuL1BBVtSZ/6e5tr68B/GA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 260afb38-9f0b-494a-c7ed-08db66b1dade
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 17:17:07.1701
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: znSM/rfNN4vbVtupqEKFHVn5XWBEjI1Hq2+1WEsdKXXwodPfCtgT5XJfXE0gUqQM93r0XIKEPBRf1fDTePA9rAsfyYcZILdigsC9dFjjRcM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6835
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 06, 2023 at 05:24:57PM +0200, Maxime Chevallier wrote:
> The regmap_config needs to be zeroed before using it. This will cause
> spurious errors at probe time as config->pad_bits is containing random
> uninitialized data.
> 
> Fixes: db48abbaa18e ("net: ethernet: altera-tse: Convert to mdio-regmap and use PCS Lynx")
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> V2->V3 : No changes
> V1->V2 : No changes
> 
>  drivers/net/ethernet/altera/altera_tse_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index d866c0f1b503..df509abcd378 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -1255,6 +1255,7 @@ static int altera_tse_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_free_netdev;
>  
> +	memset(&pcs_regmap_cfg, 0, sizeof(pcs_regmap_cfg));

i think it would be good to zero out mrc as well - in future someone might
expand this struct and you will have the same bug as you're fixing here.

>  	/* SGMII PCS address space. The location can vary depending on how the
>  	 * IP is integrated. We can have a resource dedicated to it at a specific
>  	 * address space, but if it's not the case, we fallback to the mdiophy0
> -- 
> 2.40.1
> 
>