Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Mekala, SunithaX D" <sunithax.d.mekala@intel.com>
To:     Tariq Toukan <ttoukan.linux@gmail.com>,
        Simon Horman <horms@kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
CC:     "Mishra, Sudhansu Sekhar" <sudhansu.mishra@intel.com>,
        "Kolacinski, Karol" <karol.kolacinski@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>,
        Dan Carpenter <dan.carpenter@linaro.org>
Subject: RE: [Intel-wired-lan] [PATCH net] ice: Don't dereference NULL in
 ice_gns_read error path
Thread-Topic: [Intel-wired-lan] [PATCH net] ice: Don't dereference NULL in
 ice_gns_read error path
Thread-Index: AQHZjxm1Bi4O93cuFUSVgyTDfYP+sq9sUC6AgA9zfiA=
Date:   Tue, 6 Jun 2023 17:20:37 +0000
Message-ID: <CO1PR11MB5028E9B124D8DA66D08F8560A052A@CO1PR11MB5028.namprd11.prod.outlook.com>
References: <20230525-null-ice-v1-1-30d10557b91e@kernel.org>
 <e1e3dea5-a393-180a-805a-a944ec778041@gmail.com>
In-Reply-To: <e1e3dea5-a393-180a-805a-a944ec778041@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zrm2X8xQ9W4BXoOte9UNWwDGvg1B+laEL1DY8JZcQn9gcEkro0ue3JKcqpPl?=
 =?us-ascii?Q?AS+H0uepYZ8YC5BTv6jlN0YrHVuMeL28DfyrA0rVcggfDIjZQuTW2GNKJzD+?=
 =?us-ascii?Q?gN/hOshdZLmOOhzt5/rpFFCvxa3SoYUXpyOcoOkFvRZCgmexken7hJzXRAGI?=
 =?us-ascii?Q?8qI/Es8luKql+dO+N0GhBbl0ljJfvJJgBet7JkiYfmfuUUNwUAYgxEz3K2Wo?=
 =?us-ascii?Q?6GdDP7ZR43BLe1An8VBmRzRDqpUjH2vv2BKAtormSgbHEBrxfgfVKU7AfMGy?=
 =?us-ascii?Q?GIHCP1eJl2B3YBs0+YzWzPOjUzidgJ7RaKgqdycOa5ZwJiqZh9rEPCJZDfIm?=
 =?us-ascii?Q?7fWXxNwusydn/gZ8bong1EMwY9eaTnB6YkKe+kE83/8LdyUO58iM8JX2mSQ7?=
 =?us-ascii?Q?nwQVcIh5Tv7RtylOaZ1D/cHrkOHHotyTTvRP8WdfnUpbkAi1xFOq8DygtdH0?=
 =?us-ascii?Q?3ewfyuKiG+u4fxwuQHX+xMHwfqnXfeTIym9DHtaWJM3U7OoHnEWA0lDHCVOi?=
 =?us-ascii?Q?sEXb/B0Nv+JkW0k8XK8yKjO4KUTLjgbTK+/yuU5AC4G3my6RK6xhYwoxfBNe?=
 =?us-ascii?Q?rC2QNptjBhM0spaWsYykkpik9uw9exlBYiwrDhhvpKwS54rFMR2QHTwLZVrL?=
 =?us-ascii?Q?GFnv6s6h+mEjFIfAyUsZqbHp9VVlqce3Eqbvdpx/PtL2pBugiQ0C9eqtakq0?=
 =?us-ascii?Q?CKvOWQsCe20/9Uw4Snyy5lkviRuaRtu1IAsF2i7vpH5nupWDG1xNeN46LJXN?=
 =?us-ascii?Q?EqwLj8yYszfyloDgQXdLeCcT+GUqBlDENcSpa6hUoHnvC5KgMVmsIMdMhyh+?=
 =?us-ascii?Q?M98n3MkPlNumZB5KE84wlm+5U+bVMTx+2D5aBmsC6T0Y6ypf035HMkdUYgmX?=
 =?us-ascii?Q?llkuToHKsj8KeaTdB4ziZDHHka+LZWCxOIZpYya8fVjx65cPpfUNGIfbb4fZ?=
 =?us-ascii?Q?eypemOdz1e3Ce1l7AXKOZ7eoBC6rz6/HHpwN5n/Y1xZNy8oBEeiQP9YQtK9q?=
 =?us-ascii?Q?XbHaVmQu6if8NW9yV06dWuyfAlKEE4ySMMgodx27ljWt3uhdQJ8cEsqeF03p?=
 =?us-ascii?Q?YdCDpn41QGQNmyq/ekb8bThHHzKLxsLPBSJtzPMddjdz0kc195aEf/ALd8xX?=
 =?us-ascii?Q?8+sp8b0/A8hr2QXKfuN3bAcUwcF5Kkx7GsCCq+j0mMvtpd7Kb3ByYICUQasS?=
 =?us-ascii?Q?bA/+uAAK51UZ3hcIxrCUwQ8M+vvQ2pPyCVa7wSdkSDYK7z+WUEs16iymT8vg?=
 =?us-ascii?Q?n7RYxp4UGIAqaqWgx7WB3WDeno6Kp1iUZtil6RUYz4t4nQnGeer6hMIEuWga?=
 =?us-ascii?Q?PTcoIm9/nDWhWHXVGHoYklzj12pfAcrfYjFuyTW5Ty2WKiCXXrOFeJSiqgpy?=
 =?us-ascii?Q?DO14JOtfq8Tji2HwilmFwBoUbnE0PK7cEE7ON0snmlq1ZhZDcVicd5J9/OZ7?=
 =?us-ascii?Q?iaY1d+c9IWf/QlE+/w/3D2KB/rQTDaBBsG4JW2vErcN6vFk+FwD4EpplJEXN?=
 =?us-ascii?Q?/km4cfhx7JgkFCIozPsIXz7LbeEwN/YV8cExtyT/dOadkhKP7jHsEFZG7wxb?=
 =?us-ascii?Q?jeuBr5KzyY8TMp4bXsOfsjUnGvo1cNNc6i0XPZBFG8soXAfWmnQvDZgwCd8d?=
 =?us-ascii?Q?aA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5028.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1676b40-747f-4354-0546-08db66b2589d
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2023 17:20:37.9697
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: g2p5u0+uHbptZ1BwRijxqHrzSaTbW5SexYD0R02nrAgI89RiQRDLFDrAIIjC2YlXt7/Yyo0QW2EHNaXqsnO5Vd2VkCRm3MfIDAZAXKyBkFE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5654
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of T=
ariq Toukan
> Sent: Friday, May 26, 2023 2:48 AM
> To: Simon Horman <horms@kernel.org>; Brandeburg, Jesse <jesse.brandeburg@=
intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>
> Cc: Mishra, Sudhansu Sekhar <sudhansu.mishra@intel.com>; Kolacinski, Karo=
l <karol.kolacinski@intel.com>; linux-kernel@vger.kernel.org; Eric Dumazet =
<edumazet@google.com>; intel-wired-lan@lists.osuosl.org; netdev@vger.kernel=
.org; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Da=
vid S. Miller <davem@davemloft.net>; Dan Carpenter <dan.carpenter@linaro.or=
g>
> Subject: Re: [Intel-wired-lan] [PATCH net] ice: Don't dereference NULL in=
 ice_gns_read error path
>
>
>
> On 25/05/2023 13:52, Simon Horman wrote:
>>  If pf is NULL in ice_gns_read() then it will be dereferenced in the=20
>> error path by a call to dev_dbg(ice_pf_to_dev(pf), ...).
>>
>>  Avoid this by simply returning in this case.
>>  If logging is desired an alternate approach might be to use pr_err()=20
>>  before returning.
>> =20
>>  Flagged by Smatch as:
>> =20
>>     .../ice_gnss.c:196 ice_gnss_read() error: we previously assumed=20
>>  'pf' could be null (see line 131)
> >
>>  Fixes: 43113ff73453 ("ice: add TTY for GNSS module for E810T device")
>>  Signed-off-by: Simon Horman <horms@kernel.org>
>>  ---
Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worke=
r at Intel)