Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 19:35:29 +0200
From:   "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To:     Moti Haimovski <mhaimovski@habana.ai>
Cc:     Conor Dooley <conor@kernel.org>,
        Conor Dooley <conor.dooley@microchip.com>,
        "david.m.ertman@intel.com" <david.m.ertman@intel.com>,
        "ogabbay@kernel.org" <ogabbay@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] make AUXILIARY_BUS config selection clearer
Message-ID: <2023060655-dictation-abrasion-5d44@gregkh>
References: <20230606133528.197335-1-mhaimovski@habana.ai>
 <20230606-aspirate-evident-00b27a98a718@wendy>
 <AM9PR02MB7706888212798FE0CC8213D6D152A@AM9PR02MB7706.eurprd02.prod.outlook.com>
 <20230606-sushi-clunky-8e816f5b206d@spud>
 <AM9PR02MB7706F1E489D4B54E9502D4B4D152A@AM9PR02MB7706.eurprd02.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <AM9PR02MB7706F1E489D4B54E9502D4B4D152A@AM9PR02MB7706.eurprd02.prod.outlook.com>
Precedence: bulk

On Tue, Jun 06, 2023 at 03:28:17PM +0000, Moti Haimovski wrote:
> 
> 
> > -----Original Message-----
> > From: Conor Dooley <conor@kernel.org>
> > Sent: Tuesday, 6 June 2023 18:05
> > To: Moti Haimovski <mhaimovski@habana.ai>
> > Cc: Conor Dooley <conor.dooley@microchip.com>;
> > gregkh@linuxfoundation.org; david.m.ertman@intel.com;
> > ogabbay@kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH v1] make AUXILIARY_BUS config selection clearer
> > 
> > On Tue, Jun 06, 2023 at 02:50:21PM +0000, Moti Haimovski wrote:
> > > > From: Conor Dooley <conor.dooley@microchip.com> On Tue, Jun 06,
> > 2023
> > > > at 04:35:28PM +0300, Moti Haimovski wrote:
> > > > > Add a display string and a help section to the config
> > > > > AUXILIARY_BUS section under the "Generic Driver Options" menu in
> > > > > order to make its selection clearer.
> > > >
> > > > I am a wee bit confused, since it is not explicitly mentioned here,
> > > > why is this now going to be user visible/selectable? What was wrong
> > > > with the drivers that needed it selecting it?
> > 
> > (please don't top post)
> > 
> > >  Noting is wrong with the drivers ????
> > >
> > > I've stumbled that issue when trying to figure-out how to manipulate
> > > the auxiliary-bus selection Via "make menuconfig"
> > > The issue is that with the current Kconfig when you run " make
> > menuconfig" and enter the
> > > Device Drivers --->     Generic Driver Options --->   Sub-menu then there is
> > no mentioning of
> > >  the Auxiliary bus although it is the first entry in drivers/base/Kconfig that
> > this menu is presenting.
> > > So, the user has no idea that this option exists and no way to manipulate it
> > via menconfig.
> > 
> > That's the point of how it currently is though, no?
> > We don't allow users to set the option, but rather any device driver that
> > needs it, selects it.
> > That way, a person configuring their kernel for some hardware just needs to
> > enable the drivers for their hardware and knowledge of kernel internals is
> > not needed.
> > 
> > Is there a particular driver, perhaps in drivers/accel, that does not select the
> > option, which is why you are trying to set it yourself?
> 
> No, nothing specific. Just saw it and thought it is an issue to address, 
> sent a private mail to the author (Dave Ertman <david.m.ertman@intel.com>)
> Who replied that he was unaware that it was a naked bool in the base/Kconfig file!
> And there is no reason that he is aware of for it to be that way.
> So, I've added it.

The reason is that as Conor says, it is not a user-selectable option, it
comes in by virtue of a driver that requires it enabling it, that's all.

thanks,

greg k-h