Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3279e4c3-2a26-9a77-0334-292fee0c0510@intel.com>
Date:   Tue, 6 Jun 2023 10:28:21 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] igb: fix hang issue of AER error during resume
To:     Aaron Ma <aaron.ma@canonical.com>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
References: <20230526163001.67626-1-aaron.ma@canonical.com>
Content-Language: en-US
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20230526163001.67626-1-aaron.ma@canonical.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVErYi96RXJIcUlmZ01iWGQ5VXdFd1ZFQjVva29qMkFiMzdCVExqYW9RU2xE?=
 =?utf-8?B?RGQ5RnhwWHlOWUdlcGlmTXI2d3U3VCsrYUNzQmJCQXhEcC9iN1hDTkZTSTBU?=
 =?utf-8?B?dnZkaDFVZ0RuK21YeGFzM0tZN3BxUVk3NzlWaHl3V1RMM1JZOWJ1U1dtZ2xt?=
 =?utf-8?B?L3l2UmFDdFVnMzFOOXhlNTRSSW4wVTN4S0ZMR29qMDRHTWFLd1drYTNHckR4?=
 =?utf-8?B?U0pENURMb29DZ1RGdW9vTE9BTTJENnhWYnk1cVNSSEVhZHU3R0l4d0RZRGtM?=
 =?utf-8?B?bVQ1VFBnL01kUWRaYU9GdjNWVUVKQU14MEQwdEtMWEt5elN0Tnc4T2tZRnQx?=
 =?utf-8?B?WngzUFUrRFk4T1FwZWYxWjl3YlhwdGxZZklSanFzak1kczZYYW9WTE9yeG9p?=
 =?utf-8?B?aE5tTm5HbXB4WUIrT0plSFJyMnZuMm5zSWV2S2lmdVNvS2xobGk4TGZvMXRR?=
 =?utf-8?B?WGpoeTh5UDRoL1F5UFhhTExlQkExVWZzSXIwUnRCTlpUWlVwL2dmaGhTdlNN?=
 =?utf-8?B?WEQrYmNZVWlJdDB4OUZHYmNqMmJ3aVp6MVJvS29lbkszbURjNFNCRjdka1kx?=
 =?utf-8?B?Vm9ib0kwclQ3T2dGWGxNUEt2YUxxVkRFUnNMdmlyS3RqcGFTQ2pEZm0xNitk?=
 =?utf-8?B?aTVSR3lJbUZJMTBuL2tLZ055VkNlOFd2ejJMc3kwK3BzekFmREhKdGI0eFBB?=
 =?utf-8?B?d2VhWHVuTVdDdnNoWU90RU9scHgwME92TzVnUlpjcmQvYkVKU3ozK0tueHNN?=
 =?utf-8?B?dEVGUHFzd2J0emp5ZDdXb2JjbFU4UXAwTXR1V2g1a0dJK0xWQVBDcThMNTZz?=
 =?utf-8?B?T21NZG5jKzFOZ0xLUm12aElsMzFGS3JIT0k1SDNLdm9rV2FxZHJYMlcvSEFj?=
 =?utf-8?B?UTNyQ2Z4V0ZqdEJZbmJ5NUpWcXNVdXVGcTBmTVpBMWNwc0d6NGl2UUR0cU9C?=
 =?utf-8?B?N0FRNmY1MG9jK3hPL0paNHFleDNRbktuKzh4UjNGcjBSVU4vckduUXQ3eXdr?=
 =?utf-8?B?R284MXhWNHFFM1Q5ZVJuWW1SSWlzZW9rNlNqaGFwU3J2VEMvK2JCYTNSU2pt?=
 =?utf-8?B?NU1jWHFYVis3ZDg5ZXdrQjhRVXF6UHVjM0dhcm4xNkFKQVJhVUphdWJCcnMz?=
 =?utf-8?B?MXlBMTdseWRVc3NNTTBhemtUTzRJenlURElVelJISU9CbGg0anFQbjBNN29F?=
 =?utf-8?B?U0lVVXJ1U3VoWEp6SEpESmh1QzJiRUprd0QzZXdvR2JmV2RpajF2WGhSYmxn?=
 =?utf-8?B?YzlBNi95QXpITTc2b0ZJT3NrK0F0a1pGQVh1TzNnL21nQTIzUG5DdDJ0RlpQ?=
 =?utf-8?B?MmNKV3BwZXRDZHJJRnlBTDN1Q3ZrUHNVWVpXeW9JTllCMmo0UWJWRkhUTFhK?=
 =?utf-8?B?aTV1TGZXMkoyWmg3YU1GUzVaczJVeUxhdERYTmNIR1QzMXpmenNaOVV4MlBF?=
 =?utf-8?B?em9xUFN0MTMwUDBnQkFRNGZwK3lnNUxJbGk1ZlZCaTV2R2M5MHltVXhibFVi?=
 =?utf-8?B?ZyswTExCU2MzN2F4Z3JJL1V6bk05UTkxczJockg3QWZMSUhTZldhSCs4dWJT?=
 =?utf-8?B?MDBidHpseWNaQUlsVzlVV2F1VWZXcTBEN2s0YnNhWjJBcXcxQjRESFJFRVpv?=
 =?utf-8?B?YWVKUnNlUEdWNDBMQlY4UkxxNWljVE5wUTZyKzEyTkFMUEZvNjdEZ1l1K0di?=
 =?utf-8?B?SWl2VmRMNmhPSkZxa1FLMUNYbUM4NjVuVEF2aGs4cU5wRlplYXB2a25aa3lG?=
 =?utf-8?B?N1RVRDFEUGJXMENjb2s4Y3JHNFU0UWJ4L0hNeW1aR0xzMDZMRFJ4V3V0OURo?=
 =?utf-8?B?YUJHVnA1OGVZcUlPeU15RDdIK2x5Uyt0UXB6Z0xDSmpacEliMFNPb3ZPQWNT?=
 =?utf-8?B?U2RYQmliWTArK2lyRzN5ZFpxOXkwZmRwQk1scGR0VElLazhOemJzOGgrTFU5?=
 =?utf-8?B?YTVnZnJ3RXN2cFMxY3lBR212a1p6VkZOcU90WnZJdStiNzZCSXE5b003bzhV?=
 =?utf-8?B?NUo0ckdJU05KY3VZRUpmaUR6a09jRk15Q0UrdWQ2bWVVL2krZkFkb0hxZm90?=
 =?utf-8?B?TjI5Rjltc2xLYytManlzdXN2dHJTR1NSajVJU1FDN0FQS0JYUWdjMWxhS1Ba?=
 =?utf-8?B?TThxZGF6RlQyUS85Z002UnJ0MmkwSDBzYWpFbjZldTJNWkRRZmtEME9Hamw3?=
 =?utf-8?B?YWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 436e400f-e1f6-44af-e7b1-08db66b36e9e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 17:28:24.6203
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QfBzzMtkuDj2T8cE+mXM/e7a883mwad0x4P5GwnPJ0KewKAfZY4V34yBcK/Ey0x8HsT5M1bKc8Bv6lsv26Mytwkr8KFdaZrZoS8mtupup6I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6518
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/26/2023 9:30 AM, Aaron Ma wrote:

Could you designate the target tree for the patch (net or net-next). I 
presume it's net...

> PCIe AER error_detected caused a race issue with igb_resume.
> Protect error_detected when igb is in down state.
> 
> Error logs:
> kernel: igb 0000:02:00.0: disabling already-disabled device
> kernel: WARNING: CPU: 0 PID: 277 at drivers/pci/pci.c:2248 pci_disable_device+0xc4/0xf0
> kernel: RIP: 0010:pci_disable_device+0xc4/0xf0
> kernel: Call Trace:
> kernel:  <TASK>
> kernel:  igb_io_error_detected+0x3e/0x60
> kernel:  report_error_detected+0xd6/0x1c0
> kernel:  ? __pfx_report_normal_detected+0x10/0x10
> kernel:  report_normal_detected+0x16/0x30
> kernel:  pci_walk_bus+0x74/0xa0
> kernel:  pcie_do_recovery+0xb9/0x340
> kernel:  ? __pfx_aer_root_reset+0x10/0x10
> kernel:  aer_process_err_devices+0x168/0x220
> kernel:  aer_isr+0x1b5/0x1e0
> kernel:  ? __pfx_irq_thread_fn+0x10/0x10
> kernel:  irq_thread_fn+0x21/0x70
> kernel:  irq_thread+0xf8/0x1c0
> kernel:  ? __pfx_irq_thread_dtor+0x10/0x10
> kernel:  ? __pfx_irq_thread+0x10/0x10
> kernel:  kthread+0xef/0x120
> kernel:  ? __pfx_kthread+0x10/0x10
> kernel:  ret_from_fork+0x29/0x50
> kernel:  </TASK>
> kernel: ---[ end trace 0000000000000000 ]---
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217446
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>

... which should have a Fixes: tag since this is bug fix.

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq

Thanks,
Tony