Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp7530078rwd; Tue, 6 Jun 2023 12:06:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Glxt1kDZaqz/aEUwE8gWvH3MJvhgSbilNKy4ZLnbEo9GMnWqrn+fBZwYd+0/Mtem2zqWs X-Received: by 2002:a05:6a00:b8d:b0:64e:bce9:3229 with SMTP id g13-20020a056a000b8d00b0064ebce93229mr3989860pfj.9.1686078376509; Tue, 06 Jun 2023 12:06:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686078376; cv=none; d=google.com; s=arc-20160816; b=TwBp7Ay/XQgoL3mppH3FonFxrvwh3Nx5FTeAl9X00RrbnZWgaO+TEBO5POCFbhnE4l OC2+GtRQIozKkbKarYorF9L+MWWceVGdbQkCFS5tNarztqBZnorKBCx2YlbOgwcEn8tu uIyMUD5zmOtl38SWDTesL1w+wO7SzQWW2t+9xGKCYke+/YupCT9Q96ZT5OUWenHLZj89 4aXuQLP+MVdtyQQyGOYWTz4PchuXo1cXOTD0QU4+l90RdqriXoZbdj2RSE9Njwps7j8N 8sXq1BmLOW3AtYVkZVv1riWv9BbVDSL+O1kvoXBS5/ixrM2kWaV/OnldTVEs0N7O1ZD8 wwrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-filter; bh=KyenbPXmihAvbpfjDuLbp/6mMOtj/AGfe8T4xRgkpoI=; b=N7QBXP67M+/F/0epHlaFJYlaGVwRWa6FQ7hiJAueX/iD/oP9dcj/nFW70E5OUHMRkr iNn5wE39wjx5G3k0/f+BqYzLPTGvRTSvq4U198qcwS+JxpRiUjzigOJCnUWbWSFTaOER IWW6Gj4Pi7+OxylKWkgJ+y9zDzIsZRuxAVKE3h+S6+1BoWVvq4+hwrDs1bpRGnX2ynCZ j6U9E1wxU1GrbbMysRc+KZJFIVLWFMDswINCp0MZR2TDLQyyLHOvDgjKfJECKACuqBQy jpinA0xxmW4IZ5QO2W/oEWpuMMIKSZ+/BKmEyZ8pcrK3C80BUuUFYL2PiVxhawHSymj7 Zm0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b="l+/n9Q1F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 19-20020a631753000000b0053474ec7245si7474733pgx.683.2023.06.06.12.06.03; Tue, 06 Jun 2023 12:06:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b="l+/n9Q1F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238934AbjFFSxh (ORCPT + 99 others); Tue, 6 Jun 2023 14:53:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239099AbjFFSxe (ORCPT ); Tue, 6 Jun 2023 14:53:34 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A165B10FA; Tue, 6 Jun 2023 11:53:30 -0700 (PDT) Received: from W11-BEAU-MD.localdomain (unknown [76.135.27.212]) by linux.microsoft.com (Postfix) with ESMTPSA id D34FB20BE490; Tue, 6 Jun 2023 11:53:29 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D34FB20BE490 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1686077610; bh=KyenbPXmihAvbpfjDuLbp/6mMOtj/AGfe8T4xRgkpoI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l+/n9Q1FTBT2G549Gke3wzZtakJkEehgn6BnaU13nD4PgzA+1GN/J4dxQHcXziVg4 Va/vYbqSCCZOwmWBpRaF8M+8U2yAZMfAPELSMxvA6Cjc55DB/VVt3vj+t5q6Bx013W DaWNlCQ/7mLYKpJlCEuV+fsBuNl30FYAJs+v8H1I= Date: Tue, 6 Jun 2023 11:53:22 -0700 From: Beau Belgrave To: sunliming Cc: mhiramat@kernel.org, rostedt@goodmis.org, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kelulanainsley@gmail.com Subject: Re: [PATCH v3 0/4] tracing/user_events: Add empty arguments events Message-ID: <20230606185322.GA86@W11-BEAU-MD.localdomain> References: <20230606062027.1008398-1-sunliming@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230606062027.1008398-1-sunliming@kylinos.cn> X-Spam-Status: No, score=-19.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 06, 2023 at 02:20:23PM +0800, sunliming wrote: > This series patches fix the incorrect trace record for empty arguments > events and add correspondent selftests. > > V3: > Improve modification descriptions to maintain consistent formatting > > v2: > Change "i->count" to "i->count !=0 " to prevent compiler optimization > Add correspondent selftests > > sunliming (4): > tracing/user_events: Fix the incorrect trace record for empty > arguments events > selftests/user_events: Add ftrace self-test for empty arguments events > selftests/user_events: Clear the events after perf self-test > selftests/user_events: Add perf self-test for empty arguments events > > kernel/trace/trace_events_user.c | 4 +- > .../selftests/user_events/ftrace_test.c | 33 ++++++++ > .../testing/selftests/user_events/perf_test.c | 82 +++++++++++++++++++ > 3 files changed, 117 insertions(+), 2 deletions(-) > > -- > 2.25.1 Thank you, this series looks good to me. Acked-by: Beau Belgrave Thanks, -Beau