Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Hawkins, Nick" <nick.hawkins@hpe.com>
To:     "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>
CC:     "Verdun, Jean-Marie" <verdun@hpe.com>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "brgl@bgdev.pl" <brgl@bgdev.pl>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "jdelvare@suse.com" <jdelvare@suse.com>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: RE: [PATCH v3 2/5] gpio: gxp: Add HPE GXP GPIO
Thread-Topic: [PATCH v3 2/5] gpio: gxp: Add HPE GXP GPIO
Thread-Index: AQHZmBjF4JEt/zYBEESMQ0szz/IlCK99gJKAgABZOsA=
Date:   Tue, 6 Jun 2023 18:51:47 +0000
Message-ID: <DM4PR84MB19278E9DD0BF34C570F714708852A@DM4PR84MB1927.NAMPRD84.PROD.OUTLOOK.COM>
References: <20230606014234.29491-1-nick.hawkins@hpe.com>
 <20230606014234.29491-3-nick.hawkins@hpe.com> <ZH76x6E9cbfrJHeu@surfacebook>
In-Reply-To: <ZH76x6E9cbfrJHeu@surfacebook>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6ccEA4RUEOa0wPjqYe1jHqF0Wv2ugSfGy+oorWxxGEgVZnXGYpRBEb5PLq8o?=
 =?us-ascii?Q?K3kbVL8jMmAkULyZ07RpVMYxINJS1OkQ9V4rqxygmZd1W6a5QYzlebtaTuet?=
 =?us-ascii?Q?kFgDmQC33frEI2TcDX2QFZGoi52SdI8xSfIGskcr/SKmYAHmNltq/ffz9saA?=
 =?us-ascii?Q?c8LoA940vk4R0XBNF4hR0OHIVrE9ZSSce0D2PZx2venToAZwsK/7kxzJ0SmU?=
 =?us-ascii?Q?1D2vn+V0V7Q0BGI/I6U7wcnC3v0qMsy4p3kwICVEXS8biQjMVIrpYxdD6n54?=
 =?us-ascii?Q?a9cQobxFUIG/5TNpXxkO0rfT/DoE2Jc8gwB2YHn698bZudxLtcEvJCKYDBWu?=
 =?us-ascii?Q?FXPw8fzn14fAMtWjWjOfkcIah0Q0k8oSaZdSUT2gx3XjUvtHxCO7XhhLc52z?=
 =?us-ascii?Q?/XZTU1liviAoFRR7/E0qJbY6xgX6Z1wzonnjTyt9DtAeY2WKTEQNLRy4Cw/Z?=
 =?us-ascii?Q?8tnaeK904WqhucLOLIBAGwRE8XRMskww3wGCXPdLWRPsJMojZxNi0nyTQuBy?=
 =?us-ascii?Q?k9cEeO8EtTDeXLdQbgclC69dwzvq+vO56BzTuwyNG01Mt/kwq4tqB+BtDkK5?=
 =?us-ascii?Q?rv3aHwSMWrKwYQSmziAlyy3N/uLDHU2EwQgbulO2qnB+M8D6/VGpYnsr3h17?=
 =?us-ascii?Q?V7H3DfBSoHvJ2lV7VJIHusfUcxZF+WKmpaCYvChnHTPC+RkfEiTIsZnQpnDW?=
 =?us-ascii?Q?1W38menF+uIS2ommYgj1b+yYVu7lntvC11mtFn3JpIDbnxFwVPHAmdOZ8WYx?=
 =?us-ascii?Q?OBAyr4v6XAWJvruu4jQalbGPAZmsyHivg2orMR/1crurIFgBujykvcCYgDCb?=
 =?us-ascii?Q?nfpSfK4V4tp9rZNBk5w2/EktU59TYSTjOhyjhhXk9uyAAxxqiSB9EgRjGafW?=
 =?us-ascii?Q?C5BQw2JgmMYWE4TjvwPYiH6kj56Uo+kFaxATBRVcdkIKIXXC99Tthz84NfpS?=
 =?us-ascii?Q?mFSvpB9xWPVMX4n+bM43ddpMMuliMa9VTOLdYTdP311PVaCAus1mqeAoIILT?=
 =?us-ascii?Q?MbigM1M6E/auVM2XZTTOu8R8uhkYG4/tSy/7Ecuyb8RTjEqFXiJJexCNmHuB?=
 =?us-ascii?Q?J6njDLcrNswTMwdOQUOtKBarKIJsIIitOrXnfoG+I1RZePkkQlvS6ed8YEqu?=
 =?us-ascii?Q?wee7DKTW0FpC8d1aMXHpEZw6bB/pAPfSOSoc44TyMfDrGbIOVZWNiekI25dS?=
 =?us-ascii?Q?RZ67KZDclYTpB0IaIjGxkaYQLSsL1iv19BKQABwzZ3OHhwwg/yclTQoFgwAv?=
 =?us-ascii?Q?nCkj7S+C2oOccXKptbKY4GiP2NFY2Lf6GGdCN0F/Ln+uTVOJHu9uhsn2OJis?=
 =?us-ascii?Q?AIxPOakGOZB+Z5ErikdazA4HckjVtZWpx96JSU75VcuQta7yfSQAaSoTyTbl?=
 =?us-ascii?Q?SyNrFy2LjQnvRct7njH1AgCdgamBNNikLWyb8tA99+dbsI6uHWcmO9o85wv9?=
 =?us-ascii?Q?UE2ePNe+GpsFwDE4KFRK8+9Eu6np8+bitw36+Vn2wwkkiDHb//FGc78AseIe?=
 =?us-ascii?Q?GokeCnc5DZLWmwJwoaa9WGsRsyCdiRfFB00Db7XcDT8dZxZNuqH3rvcPPk3C?=
 =?us-ascii?Q?yOQ+COgXx5uxaBRViu1co9FxIP+YmkP+x3bGO8lY?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR84MB1927.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b8b0349-4427-4997-a17e-08db66bf146e
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2023 18:51:47.0509
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c/cGzu7Nn9Jo4e/m5hMaVKH20dBRpbLCFru9EQkTa1SRmEus4iqskNWt7b5ybSGHnG0x0T5e+Z66mGzXxKiMDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1732
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: 0v47d4oTxYSbMX54-GAkOwB-j2nLTKlB
X-Proofpoint-GUID: 0v47d4oTxYSbMX54-GAkOwB-j2nLTKlB
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-06_14,2023-06-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0
 mlxlogscore=658 bulkscore=0 spamscore=0 mlxscore=0 suspectscore=0
 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2305260000 definitions=main-2306060161
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy,

Thanks for the feedback. I have a question below:

> > +	base =3D devm_platform_ioremap_resource_byname(pdev, reg_name);
> > +	if (IS_ERR(base))
> > +		return ERR_CAST(base);
> > +
> > +	regmap_config.name =3D reg_name;
> > +
> > +	return devm_regmap_init_mmio(&pdev->dev, base, &regmap_config);

> Why are you not using gpio-regmap?

Is there are good example or previous commit you would recommend
looking at that shows how to convert from regmap to gpio-regmap?
Later in the code I am using regmap_read and regmap_update_bits
with large differences in offset registers, and not so much a
contiguous block.

Thank you for the review and assistance!

-Nick Hawkins