Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp7545543rwd; Tue, 6 Jun 2023 12:20:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5g5KST6EK7+Mpy1APmy2m5psK9FdTKOIYBiftadiBgvHwTE0makB0hTsbzonLuJRUr9XP6 X-Received: by 2002:a05:622a:11c4:b0:3f5:3991:97a5 with SMTP id n4-20020a05622a11c400b003f5399197a5mr886354qtk.54.1686079237212; Tue, 06 Jun 2023 12:20:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686079237; cv=none; d=google.com; s=arc-20160816; b=SG6H4EAPj51Nophk/D5Ti3vZpkzHhfpLB1EBVWNX9brVSj6rTpawo3mXjVmXtY4PAn 1HNux40gHVCOHg7xo+7q6SN/c8fhAMm7/R+wGhSA+sqjKeg++BdJb9w9giSF1TAXLwt5 DC1SwIH/HC5mV+pjEAJENJ4/dQPybw+EQA3g1B+yQ447MOd6hjJIGTeQ165vja3xf8xa eqhe6h7aVObZpTvUA41YpXSjBPwUoodTgNHefNawhmxnaFQmF01ArrJFcEonIF6DknyK PchGgBpXiUdjftIIOfiijyQN1TJ/fs+UIuAtPHQOgJI6ORogZwC6qOQWxDzS5zQCCMZb 0EwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=Z5L89tB8wkQBFqziHGie36QGbrdPo8qwmA+HXjQV+vM=; b=WakYuCwVSIyP8jKZtmbH/Kg55JIyXRjDPndllWZQozy9iFX6Go5QeFzq4WZFODFFSA acU31TAvuGacrEYo/LNs84jq6Isnn4iATTi/W2Iaq4QK5DllnYIx5av3NOCzkqRB+0l2 h1GbaWQuUfSOr4G/D+ATxCqmtnJYy5nZ8T/cuGOasUSvibRotsppYkjK7EBUAFGAul/V FjN7ST7AjIJI4+zakpO6ekyZE28y91DR2DEUEJyTU7sgzynQCs31hwdIeR1t3wq81mRa DRnZ255kYCyGXuyThu7k6K0PuRBmr5hsAwt+w55DAMs/ey18Wq70JsCdfYhNlt1ySd64 tI8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Oubagn6l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s31-20020a05622a1a9f00b003f9a7707278si2652406qtc.64.2023.06.06.12.20.22; Tue, 06 Jun 2023 12:20:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Oubagn6l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239193AbjFFTPj (ORCPT + 99 others); Tue, 6 Jun 2023 15:15:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239792AbjFFTPV (ORCPT ); Tue, 6 Jun 2023 15:15:21 -0400 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99384E54 for ; Tue, 6 Jun 2023 12:15:19 -0700 (PDT) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-565aa2cc428so60644857b3.1 for ; Tue, 06 Jun 2023 12:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686078919; x=1688670919; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Z5L89tB8wkQBFqziHGie36QGbrdPo8qwmA+HXjQV+vM=; b=Oubagn6lNYCvFolZHgBbvAxTse+fxYO7QOc8PsA9iZP9e2t8ETUtUWYpW1X4aol5Pp py6kevZaycKSmSBo4Z6ISBISiqD/7iIAwBWyBerIW3RreJJ9HEAvuTJFC1L1gIxClE8B Zo1Jho7S8zqD4w+aESDk8wwKPZczPNjCqaahODZegcGR0bAXcfGkhfpy0GiU9nZoxYH5 3tSmdOg9aItl0cd9p5EIa1kuQY2vPS7IZIU1+jsUKFLETbT+lwkEGP2w54vB26myg4Sn aFZsKajhIoQKKCk8+V/q1rcIuw5atboBqOS6WM8DoES2EgCSQ+vS7fzVbSeDtG9bQjao +WFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686078919; x=1688670919; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z5L89tB8wkQBFqziHGie36QGbrdPo8qwmA+HXjQV+vM=; b=SUbYaNw/0vEllS4yqyfGtFzr7XmiSH1oqkwaM75X6jyvg/D4o+x0Wqc1VmMeAKuZTE G2Lu8oE6XaqszUxyAJomwMUyxtyRafE9+rh/4RjFViASsfpigJIZ/jKVE6eibCtmayFu MFZtJHKcMhFNGmKt4uaeyyUp0mAATCcebLsn6WUnMl/7N6cCl+6WkNRIdWHCH/IM7zNp ljdvqu6bMM8KBc6Y2g5VWAPa+HRfNsBaJpxFJJqE6DP2ZwP87H6glaOJ7Nhb46jprLpo HkXQZeQN/vxRTQmEP38NRhZiSaabwYnw7etpbmjZ72PR4ShpUu2KWKxQTqP23LHwN211 VL3w== X-Gm-Message-State: AC+VfDyALDMl0HDIpC6mT+aV2MrYS2AULDxgg8yDmHa5HHBPVlx9zamZ vS+Ig4za2SiNdvMLT5qx0z8ABkGnhKeUQ1Ydiwl2nw== X-Received: by 2002:a81:52d3:0:b0:561:e565:3678 with SMTP id g202-20020a8152d3000000b00561e5653678mr2718930ywb.11.1686078918837; Tue, 06 Jun 2023 12:15:18 -0700 (PDT) MIME-Version: 1.0 References: <20230430-nokia770-regression-v4-0-9b6dc5536b17@linaro.org> <20230430-nokia770-regression-v4-1-9b6dc5536b17@linaro.org> In-Reply-To: From: Linus Walleij Date: Tue, 6 Jun 2023 21:15:07 +0200 Message-ID: Subject: Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes To: Christophe JAILLET Cc: Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Thomas Bogendoerfer , Dmitry Torokhov , Mark Brown , Bartosz Golaszewski , Andreas Kemnade , Helge Deller , Ulf Hansson , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-input@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mmc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 4, 2023 at 5:44=E2=80=AFPM Christophe JAILLET wrote: > > + /* Asserts RESET */ > > + gpiod_set_value(md->reset, 1); > > Hi, > > should this also be done in the probe if mipid_detect() fails? It's a nice bonus but surely not urgent or necessary. > If yes, please also look at [1], that I've just sent, which introduces > an error handling path in the probe. Looks good to me. Reviewed-by: Linus Walleij Yours, Linus Walleij