Return-Path: <linux-kernel-owner+w=401wt.eu-S1757163AbXJOHNV@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757163AbXJOHNV (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Oct 2007 03:13:21 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753724AbXJOHNO
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 15 Oct 2007 03:13:14 -0400
Received: from frosty.hhs.nl ([145.52.2.15]:35229 "EHLO frosty.hhs.nl"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753393AbXJOHNN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Oct 2007 03:13:13 -0400
Message-ID: <47130F16.3000706@hhs.nl>
Date: Mon, 15 Oct 2007 08:56:22 +0200
From: Hans de Goede <j.w.r.degoede@hhs.nl>
User-Agent: Thunderbird 2.0.0.6 (X11/20070926)
MIME-Version: 1.0
To: Jim Cromie <jim.cromie@gmail.com>
CC: Linux kernel <linux-kernel@vger.kernel.org>,
       LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [ patch .24-rc0 0/5 ] SuperIO locks coordinator
References: <4712F4D4.4050707@gmail.com>
In-Reply-To: <4712F4D4.4050707@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Anti-Virus: Kaspersky Anti-Virus for MailServers 5.5.2/RELEASE, bases: 15102007 #409386, status: clean
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1942
Lines: 60

Jim Cromie wrote:
> this patchset (on hwmon-git) re-introduces superio_locks module, 
> previously RFC'd here, where I 'borrowed' another thread..
> 
> http://marc.info/?l=linux-kernel&m=115821759424601&w=2
> 
> The module shares out slots/shared-reservations containing
> a mutex, so that multiple modules can coordinate access to
> the sio-port.
> 
> Im crossposting - LKML for more reviewers, lm-sensors for
> folks with the hardware and (perhaps) more interest.
> 
> If its not too late, please consider for 2.6.24-rc0
> 
> 01 - adds superio_locks module
> 
> User-drivers specify the sio-port characteristics they can support
> device-ids, sio-port-addrs, enter & exit sequences, etc in 
> a struct superio_search (in __devinit, preferably). 
> 
> superio_find() then searches existing slots/shared-reservations 
> for a matching sio-port, and returns it if found. 
> Otherwize it probes port-addrs, specified by find() user, 
> and makes and returns a new reservation.
> 
>     superio_find()	finds and reserves the slot, 
> 			returned as ptr or null
>     superio_release()	relinguishes the slot (ref-counted)
> 
> Once theyve got the reservation in struct superio * gate 
> (as named in patches 2-5) they *may* use
> 
>     superio_lock(gate)
>     superio_enter/exit(gate)
>     superio_inb/w(gate, regaddr),
>     superio_outb/w(gate, regaddr, val)
> 
> or they can do it themselves with inb/outb, by using gate->sioaddr, etc.
> 

<snip>

> 
> - Hans, I think Ive added all your suggestions, thanks.
> 

Your welcome, at a first look over things look pretty sane now. I'm willing to 
do a full review of this, but first I would like to see some more input from 
others.

Regards,

Hans

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/