Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 20:57:08 +0200
From:   Guillaume Nault <gnault@redhat.com>
To:     Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: POSSIBLE BUG: selftests/net/fcnal-test.sh: [FAIL][FIX TESTED] in
 vrf "bind - ns-B IPv6 LLA" test
Message-ID: <ZH+BhFzvJkWyjBE0@debian>
References: <b6191f90-ffca-dbca-7d06-88a9788def9c@alu.unizg.hr>
 <ZHeN3bg28pGFFjJN@debian>
 <a379796a-5cd6-caa7-d11d-5ffa7419b90e@alu.unizg.hr>
 <ZH84zGEODT97TEXG@debian>
 <48cfd903-ad2f-7da7-e5a6-a22392dc8650@alu.unizg.hr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <48cfd903-ad2f-7da7-e5a6-a22392dc8650@alu.unizg.hr>
Precedence: bulk

On Tue, Jun 06, 2023 at 08:07:36PM +0200, Mirsad Goran Todorovac wrote:
> On 6/6/23 15:46, Guillaume Nault wrote:
> > diff --git a/net/ipv6/ping.c b/net/ipv6/ping.c
> > index c4835dbdfcff..f804c11e2146 100644
> > --- a/net/ipv6/ping.c
> > +++ b/net/ipv6/ping.c
> > @@ -114,7 +114,8 @@ static int ping_v6_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
> >   	addr_type = ipv6_addr_type(daddr);
> >   	if ((__ipv6_addr_needs_scope_id(addr_type) && !oif) ||
> >   	    (addr_type & IPV6_ADDR_MAPPED) ||
> > -	    (oif && sk->sk_bound_dev_if && oif != sk->sk_bound_dev_if))
> > +	    (oif && sk->sk_bound_dev_if && oif != sk->sk_bound_dev_if &&
> > +	     l3mdev_master_ifindex_by_index(sock_net(sk), oif) != sk->sk_bound_dev_if))
> >   		return -EINVAL;
> >   	ipcm6_init_sk(&ipc6, np);
> 
> The problem appears to be fixed:
> 
> # ./fcnal-test.sh
> [...]
> TEST: ping out, vrf device+address bind - ns-B loopback IPv6                  [ OK ]
> TEST: ping out, vrf device+address bind - ns-B IPv6 LLA                       [ OK ]
> TEST: ping in - ns-A IPv6                                                     [ OK ]
> [...]
> Tests passed: 888
> Tests failed:   0
> #
> 
> The test passed in both environments that manifested the bug.
> 
> Tested-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>

Thanks. I'll review and post this patch (probably tomorrow).

> However, test on my AMD Ubuntu 22.04 box with 6.4-rc5 commit a4d7d7011219
> has shown additional four failed tests:
> 
> root@host # grep -n FAIL ../fcnal-test-4.log
> 90:TEST: ping local, VRF bind - VRF IP                                           [FAIL]
> 92:TEST: ping local, device bind - ns-A IP                                       [FAIL]
> 116:TEST: ping local, VRF bind - VRF IP                                           [FAIL]
> 118:TEST: ping local, device bind - ns-A IP                                       [FAIL]
> root@host #
> 
> But you would probably want me to file a separate bug report?

Are these new failures? Do they also happen on the -net tree?

> Best regards,
> Mirsad
>