Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 21:41:57 +0200
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     <wei.fang@nxp.com>
CC:     <claudiu.manoil@nxp.com>, <vladimir.oltean@nxp.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: enetc: correct the indexes of highest and 2nd
 highest TCs
Message-ID: <ZH+MBdlRAybwqFo8@boxer>
References: <20230606084618.1126471-1-wei.fang@nxp.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230606084618.1126471-1-wei.fang@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CFrs1Ls/jbGlp2182UPwCEDHV498T8/0DQcQ4/XK/AGkR7zKdgpDC+mLUSLb?=
 =?us-ascii?Q?+ipffilSniDvreU7H4TiDPpun9z1AVC1Oe7Rk3KsZdVuhAYWmJozTaokEDxZ?=
 =?us-ascii?Q?Et7cvvzx/FQdywzSd15Gh2PdS71BxE9n8LdN7YO5UN8XGe6vuHz8LARF5wvx?=
 =?us-ascii?Q?FqqFeCtpDtyOFUi05QcSlAoHIRo1TG5TWhUb074B6a2Hjjk641J1v3I3kQAo?=
 =?us-ascii?Q?JsUion/02zyagwTjb3jP8vigReQ0KTUPceyum5apNIQiR9Bm0mj8PfMXAxB6?=
 =?us-ascii?Q?c4ZyNp/35dvBb4RnD0RtFvlY049PyKzJ2BxJLwRLCYkt0T4mZ7OzFpXMYrx9?=
 =?us-ascii?Q?Kw8QGhkIMQ6QEMjf0a8YP4IE4LEG/o4KxsugwAMz1jk2MVKSW/OOL0pCDPlV?=
 =?us-ascii?Q?UtWSJaLZ7jH7As8ph5g1swDwUkxbhiBivw8n38hPMBvdDadG8faapsE9AaX8?=
 =?us-ascii?Q?EACRyBLWJ6aiAGAcZurVb5rIAKDV4GkkwdcZ2gLcC9+VmCDCRqQ/YXVDbzSB?=
 =?us-ascii?Q?y4/apActsl4ceEQArklMgw6g37znPL3vinQR1nD9UbXzE4Qf4PTkPeR+A+iG?=
 =?us-ascii?Q?7CJJ4E791eE4E/gUT21EcOQrbxa4tSm8lUyx2jItm7GFryG0erxV/sJ3ZpFw?=
 =?us-ascii?Q?KrDCJJULM8FfaNc/C5HC8fz8y63xRFaBeX7oD8GuPlZusp31K5eh7ydtASul?=
 =?us-ascii?Q?yXTUkTDa9K736fi2di9LzEYA2QNUYn38UwcYYgz64O7PQPLZCiLmjXGHnmXo?=
 =?us-ascii?Q?qjZ3mepi+sjKPm9qrWUDNJfyFxzKhYPi2GeWst5WvIbZIvyeqAdiba0sTzSL?=
 =?us-ascii?Q?aJLsjnpIvTf+JZXPTGqbvECXCrXXazNQpKXH8Tua1pUgrImVsSxEmz26SZmR?=
 =?us-ascii?Q?8weSzGLNvmCkZec79eaYb8Zr6WnM57kYA1p1ZRlfWi7G9iibbtnlE5y1y3y6?=
 =?us-ascii?Q?HJ2JKydA58X6ROBC1A9LV/GTulbm/TFdfF9UpuECnTz2KkGnZebWB5c4VgtU?=
 =?us-ascii?Q?vgyVZ0qLj1qnNfxSJEHUa/wA7Y0N220yGgz6tRuagv139SWYk6BMeARLdkY+?=
 =?us-ascii?Q?yCuzKDy3ZEJZsKIGtpgxa0VXquIi+BLyivUn4fcArtICJA1GsE6CpgyxWP5W?=
 =?us-ascii?Q?3eataacs9Svz0OVyWUuzUkeO9CeFcKZZ4s9wpIJ9clPEqw73P1aN003k3V5t?=
 =?us-ascii?Q?X49gEIWdhunF0gYe2WqmmK2kfPU7PebbKHMfPVorkIlZ1LQMiAg/yLEiasXO?=
 =?us-ascii?Q?yIHYVCd8EPFs6ijJhPRBhfH58ItANs89rSFvsdgvmCR+DuuPW/HlZ/JNEqdt?=
 =?us-ascii?Q?V4oyJLmHqqyv652cyGhoJTNmj7D1180g3uTEU0ziaDNdoA1SJVLc9fuFrlH2?=
 =?us-ascii?Q?vWIwehNYJSf2Vposfz6j7MMU7I0433AQy6Jp+2JO82NAw36IHUUTrPZf2jeu?=
 =?us-ascii?Q?ItCS3mBFZIIH2M0TGCU0BCU17z79olkRJiV14q3v3sVf2g6QcxwjM6xzObOi?=
 =?us-ascii?Q?n79m7pWXEW0dD6A0QJz4gR9PocuMZgfuNBZgWdVnlJ+WMup9+fA8+iphTcDq?=
 =?us-ascii?Q?n85CypjAtSZUP64qdlif/HA1E429fu9dJpiJcndbq4kcBfGmHOYROOBRcuY/?=
 =?us-ascii?Q?NvoCC712Q5m5qqGcQ0sh/R0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 708726ff-5abb-4423-b67e-08db66c61f17
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 19:42:11.6682
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xXvl3P5CdU7b5ZT+5uY6m6K5ngakgOJV8HiJWkh3XlJ994FVnNGv0GQyELipr4you9qrMDNqXfI7zNShk9OkE0+q9+6YpbS8gQp1WaqzBi8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8574
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 06, 2023 at 04:46:18PM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>

if you are a sender then you could skip line above.

> 
> For ENETC hardware, the TCs are numbered from 0 to N-1, where N
> is the number of TCs. Numerically higher TC has higher priority.
> It's obvious that the highest priority TC index should be N-1 and
> the 2nd highest priority TC index should be N-2.
> However, the previous logic uses netdev_get_prio_tc_map() to get
> the indexes of highest priority and 2nd highest priority TCs, it
> does not make sense and is incorrect. It may get wrong indexes of
> the two TCs and make the CBS unconfigurable. e.g.
> $ tc qdisc add dev eno0 parent root handle 100: mqprio num_tc 6 \
> 	map 0 0 1 1 2 3 4 5 queues 1@0 1@1 1@2 1@3 2@4 2@6 hw 1
> $ tc qdisc replace dev eno0 parent 100:6 cbs idleslope 100000 \
> 	sendslope -900000 hicredit 12 locredit -113 offload 1
> $ Error: Specified device failed to setup cbs hardware offload.
>   ^^^^^

newlines between commit message and example output would improve
readability. tc commands are awful to read by themselves :P

Please describe in the commit message what is the actual fix.

> 
> Fixes: c431047c4efe ("enetc: add support Credit Based Shaper(CBS) for hardware offload")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
>  drivers/net/ethernet/freescale/enetc/enetc_qos.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
> index 83c27bbbc6ed..126007ab70f6 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
> @@ -181,8 +181,8 @@ int enetc_setup_tc_cbs(struct net_device *ndev, void *type_data)
>  	int bw_sum = 0;
>  	u8 bw;
>  
> -	prio_top = netdev_get_prio_tc_map(ndev, tc_nums - 1);
> -	prio_next = netdev_get_prio_tc_map(ndev, tc_nums - 2);
> +	prio_top = tc_nums - 1;
> +	prio_next = tc_nums - 2;
>  
>  	/* Support highest prio and second prio tc in cbs mode */
>  	if (tc != prio_top && tc != prio_next)
> -- 
> 2.25.1
> 
>