Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ec58af39-9c97-2032-585a-6dbaa890206f@meta.com>
Date:   Tue, 6 Jun 2023 15:49:05 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.2
Subject: Re: [PATCH 2/2] [v3] bpf: fix bpf_probe_read_kernel prototype
 mismatch
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Song Liu <song@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>
Cc:     Arnd Bergmann <arnd@arndb.de>, stable@vger.kernel.org,
        John Fastabend <john.fastabend@gmail.com>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Yonghong Song <yhs@fb.com>, KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Kumar Kartikeya Dwivedi <memxor@gmail.com>,
        Dave Marchevsky <davemarchevsky@fb.com>,
        Delyan Kratunov <delyank@fb.com>,
        Joanne Koong <joannelkoong@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Roberto Sassu <roberto.sassu@huawei.com>, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
References: <20230602135128.1498362-1-arnd@kernel.org>
 <20230602135128.1498362-2-arnd@kernel.org>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <20230602135128.1498362-2-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGlXditFbnhXbWJOMDRMaHg2ZStleGNIZitWSXRDOEpsbzFHcXMzRFVQaFM0?=
 =?utf-8?B?RERNdEJleWVZanA1QlJ2bysrRWpUZm1NZFZjdUE5OEFhYVR3YzBmOHBqc1pE?=
 =?utf-8?B?MVZpWDVzWFM4Y29WV243TVNvcDJSTkp6QWQ4TXo5T1o5aDJvS1RQams2MzUz?=
 =?utf-8?B?WmFPVk80ZW8zQXFPNTFmSVlRNk1WOCtoZlJIaWptMFNVN1A2VW5FQXllZzlU?=
 =?utf-8?B?ZllWLzQxWndnQVNqdTlQa3JPdTNmUDZuVVRLeHFERVE0ei9oUmdweTNid1pI?=
 =?utf-8?B?anhITGo5RElGaCsrYklYaFd4T1BrV0xvWFpUQ3FuMkJMdjlSQXQ0ZU5SVHJN?=
 =?utf-8?B?aTlCaE02c1Ztb0p5U205aUlIOVBhMHBNc1grY212RklPUmNwVTBDRGxISFNK?=
 =?utf-8?B?RkNNVzhGZ0NOUnFqanRiSi9uWGRvL2xuSnZtR1ZKVnhiOU41dE5lVWQ5cEtL?=
 =?utf-8?B?S1NXUTNqOWFkVS9YWkZyQjBYSnFGRVFtd0VYclRDU08vTTJ1YVBaZk1TV3h5?=
 =?utf-8?B?UVc2OFYwc3hlZ2F0a1pSQnlHZTJGSVNUQ045R1FGZE5IaEFnMWRzNHpHaU9C?=
 =?utf-8?B?K3NYOWZXcHB6L21WMzdTUThSd2JTdlpZRTEyZ0ZnV0hRVlhuamdEL09DV0dU?=
 =?utf-8?B?SFNCYzNFUUNtSlJEbXYyemtkTmxMeVljOVVwVGRoaDRSK1pRRExkV0t2T2ZP?=
 =?utf-8?B?YUlkREpWM2RDeTBMay9CRS9XMFlsa05mL0RUQlZjRHpMNGRnNVRnTTJVRWdp?=
 =?utf-8?B?Nk1LOHB0Y0V2WjRBVk9wbjFxUmFaSnRxRnlWSEVzS0M4NGU4aWROdC85WmJH?=
 =?utf-8?B?QTBaV0RPTy96VFBsMDdnaGNoWmhVM0JWd1YxYXRZeDQxZElFRnhPTVdvbFZs?=
 =?utf-8?B?N25LamVmUDRkMFdyWEY4VUZwNkltR255QTR3QzRkKzNuL1Y3NDJ2R25pcGsw?=
 =?utf-8?B?UU55NytJSkdsVkc4bjVoSlBxTzBIZHE3L3RmR1hIaHRKTkNKS1o3THV0clpu?=
 =?utf-8?B?ZzRYdTdhRWpybldGS3lTOVlQSUpkUktiRVJBR2Uwei8zY2dndnd1Yk1CZEto?=
 =?utf-8?B?SFV5Z2hHMjhLblVjSXNwcDlqK3F5cXNjNTlQV2FkSUR1Z3dFdXN2anJRMnB5?=
 =?utf-8?B?N0NCc0EzYlZlSFFaanQxZGJJcTJOY0w3QU5HeTZxSVhqRyt6b1FuenVYSDBV?=
 =?utf-8?B?Y1hhaXluUTVUMFpXSDhDb3I5N0lOaGpUdGp4TGs1TmtiN3RwT0ZUa2lhWU9p?=
 =?utf-8?B?MnhWWkpZRnNiNkRwL0tQaFdoK2N6Z3kyM1RaaHNTYm5KREUzTTQ3aFZSREJv?=
 =?utf-8?B?L09Vd3ZYOHdaNVB3QjFzNFd3Mk9FUWZEZHhIQ1UrclUvZlZvV2RBL2VYbDli?=
 =?utf-8?B?ZWtKb0ptZ3J3Y1J1M3RITzYvUVdYQ1E1Y0s2SzIrNG0xOGpCd25yTmtvb2Y0?=
 =?utf-8?B?VUgzRDlVVWR2WHBKalRSTmZTYlB0eUNJbDlJa01sbHY5K2ZVRnVlTHl6eUly?=
 =?utf-8?B?di9TcGt3KzBPMjRkKzlyMTR0cEw1VWxrUHRPUDhXL3FBNDFVRUhEK0lMYVhW?=
 =?utf-8?B?OUdlUXhoMTBYbXYvVURaL2I0eEI3WU80QUIvU2hUNXBWanh4eXlaY2UxT2NH?=
 =?utf-8?B?SVhFZ1E0MXZybHJzdVY5eFZSSG1DQmRkcUNHUVRYSGZTQ2tGUTYwQkZJR0Rk?=
 =?utf-8?B?QjNtM25FYnZBS0xrWVJUc3JuaEhDTEYyNHNWQTg1R25pOUhJbkJ5M0psWWRm?=
 =?utf-8?B?anNycTF5a1lUeDZqcDFDejZjTis0Z3NXY1RWSEExL01sSGQ2ajk5bXo5Lyt6?=
 =?utf-8?B?SC9CMUEvckdFV2FzSkNzeU9xR1NmZy81Yis4RkdEallaeTNtWlI3WGE2aFNo?=
 =?utf-8?B?bCtYSncvMWptNFNOWitTTGl2cE1BdWdDMUdONXc5ODNtMjhNbEpOTmk3T3Qz?=
 =?utf-8?B?NjhPTVdYSXVsb3l1cGo0dGxPNnE0UWlpWmNUcFlqOWVPSDd2dHF0VG9KQnZv?=
 =?utf-8?B?TXdOaFUvVjk4eVgwM0FMZGMrSS8rZjdSRENtU1UyUDUyaWtxRDFSMUV1YktY?=
 =?utf-8?B?Um83dW1GMEk1VFIyZWpWbTNpOEsrUEZ0NFR5clRNaXhRSFRkNkoweVdXODlF?=
 =?utf-8?B?SmRGNFg1VytvNGR0V1ZvT2FNUlp3cm5oczJoRXhIUmF6VEE0dkNLSGtkQkEv?=
 =?utf-8?B?Snc9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b312cdd3-1c88-4941-d613-08db66e03d30
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2023 22:49:09.0138
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YuqZgFYkjdo40uH0eNR98Am1SW+1Aymfrkz0sQunUnvYi9zKibnb7z4nxQSNo/5/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR15MB4586
X-Proofpoint-GUID: y1FJtwYZeb6m1ISP4oY-BPV_LC5CUCwZ
X-Proofpoint-ORIG-GUID: y1FJtwYZeb6m1ISP4oY-BPV_LC5CUCwZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-06_16,2023-06-06_02,2023-05-22_02
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/2/23 6:50 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> bpf_probe_read_kernel() has a __weak definition in core.c and another
> definition with an incompatible prototype in kernel/trace/bpf_trace.c,
> when CONFIG_BPF_EVENTS is enabled.
> 
> Since the two are incompatible, there cannot be a shared declaration in
> a header file, but the lack of a prototype causes a W=1 warning:
> 
> kernel/bpf/core.c:1638:12: error: no previous prototype for 'bpf_probe_read_kernel' [-Werror=missing-prototypes]
> 
> On 32-bit architectures, the local prototype
> 
> u64 __weak bpf_probe_read_kernel(void *dst, u32 size, const void *unsafe_ptr)
> 
> passes arguments in other registers as the one in bpf_trace.c
> 
> BPF_CALL_3(bpf_probe_read_kernel, void *, dst, u32, size,
>              const void *, unsafe_ptr)
> 
> which uses 64-bit arguments in pairs of registers.
> 
> Change the core.c file to only reference the inner
> bpf_probe_read_kernel_common() helper and provide a prototype for that,
> to ensure this is compatible with both definitions.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Yonghong Song <yhs@fb.com>