Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: ie3994620:Fastmail
Date:   Wed, 7 Jun 2023 01:45:43 +0300
From:   "Kirill A. Shutemov" <kirill@shutemov.name>
To:     "Huang, Kai" <kai.huang@intel.com>
Cc:     "sathyanarayanan.kuppuswamy@linux.intel.com" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] x86/tdx: Explicitly include <linux/errno.h> in
 <asm/tdx.h>
Message-ID: <20230606224543.a4jex2dmn43dvze4@box.shutemov.name>
References: <20230606034000.380270-1-kai.huang@intel.com>
 <c84707e6-4f74-dc89-6243-63a72e86c62b@linux.intel.com>
 <df89f1c66059e717e9a66e314da24f939cc3eabc.camel@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <df89f1c66059e717e9a66e314da24f939cc3eabc.camel@intel.com>
Precedence: bulk

On Tue, Jun 06, 2023 at 10:17:53PM +0000, Huang, Kai wrote:
> On Tue, 2023-06-06 at 06:10 -0700, Sathyanarayanan Kuppuswamy wrote:
> > 
> > On 6/5/23 8:40 PM, Kai Huang wrote:
> > > Currently, in <asm/tdx.h> tdx_kvm_hypercall() simply returns -ENODEV
> > > when TDX guest isn't enabled in the Kconfig w/o having <linux/errno.h>
> > 
> > Maybe you can explicitly say "CONFIG_INTEL_TDX_GUEST is not enabled"
> 
> It also can be disabled by !CONFIG_KVM_GUEST.

Borislav has already fixed it during unaccepted memory patchset
application. He used <asm/errno.h>, not <linux/errno.h>.

See [1] and [2].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=75d090fd167acab4d7eda7e2b65729e877c0fd64
[2] https://lore.kernel.org/all/20230606161606.GDZH9bxhrGnFkaLl2A@fat_crate.local

-- 
  Kiryl Shutsemau / Kirill A. Shutemov