Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 21:14:22 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     "Tian, Kevin" <kevin.tian@intel.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>
Subject: Re: [PATCH v2 01/11] iommu: Add new iommu op to create domains owned
 by userspace
Message-ID: <ZH/L3ucGnzHf5kqf@nvidia.com>
References: <20230511143844.22693-1-yi.l.liu@intel.com>
 <20230511143844.22693-2-yi.l.liu@intel.com>
 <BL1PR11MB5271B553140BB729AF4389AB8C7C9@BL1PR11MB5271.namprd11.prod.outlook.com>
 <ZGfDrRDI50oGih2r@Asurada-Nvidia>
 <BN9PR11MB52766A760580E6FBB995A33F8C419@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZG2fVj41GgosR1dk@Asurada-Nvidia>
 <BN9PR11MB5276F1410A11ED631CE6824F8C419@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZG681VohNlw2vvLD@Asurada-Nvidia>
 <ZH897AGywGVbt51Z@nvidia.com>
 <ZH+McCPS14Wc25JL@Asurada-Nvidia>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZH+McCPS14Wc25JL@Asurada-Nvidia>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7yOOPTv1w2vdvzWZHBeokUCmNyHjqbHKB2TEoTYADJvuQV0riJ8e8c/5WwQY?=
 =?us-ascii?Q?L01tSSEOUTwPkXvmTq0i/5L/1zIa6nSojmUYXWy4INjYhC9vu5Gdt3MNvy96?=
 =?us-ascii?Q?C6cgTKSC7mXFg7vrIE/yBEN7JFfiiwKV4XbEhxoX+bZAeVPS/5ZWYjHuZBcJ?=
 =?us-ascii?Q?9dZTyXHSFlvlZQ5UhT05G+m7bof/UBcvhd2xoXpzB6AFv00b8IJjG2x08k21?=
 =?us-ascii?Q?poICBQC61GDwWTz5Ylz+Xit41BxT8gZ8qSoEgHzv74fIpD30XS8TIy+g18hW?=
 =?us-ascii?Q?XzG477xY8iU6WJtXdukNlWXDElifXLOqepCdpj36xDEuwBxcbAp8lrPy9WQp?=
 =?us-ascii?Q?dv+ZVhGA5Lf41vmoYNZZbhvEfIoUKEAWMuFo4eCcrpQy0F8LNR0qxc01TZqV?=
 =?us-ascii?Q?T3o531lMIpRIvqv6lz/2l0rqKKGrJgD/miIrfoqEAZG/OwCH/Ir542Ss+dwR?=
 =?us-ascii?Q?AHlf9oqBAAhvuGjWMOtfiL2rRaPgCd5AHmH3v1wCLoO/LMmD0MfZaAlkt+7d?=
 =?us-ascii?Q?3gjsgxaAYp5no67KUMQoXl6h0kOfNBcU1IZntBbiIf1jBtxEP6C/I0nzOwvX?=
 =?us-ascii?Q?OIzATH/NmFroxQ68dmsdENXMLteqSpQfiOYrT6E8WoGwHO+IWA12I9iX9218?=
 =?us-ascii?Q?YwDiKfxbT737GkbjBooJvb01zj222Hz2smDrAYU3mBaBtfhcXNYTzaXvTE86?=
 =?us-ascii?Q?fGWW+wnfKr9gR0xfGz0Tp1vQfrLGQs0qCq6bgG4sD50PaNO/SCcvMH/29qDE?=
 =?us-ascii?Q?1xdicKJfiBtgabKTduLpM/+5eYphcOnRgDJZzdcXa2WWZqdlRSyYdp4EgEbJ?=
 =?us-ascii?Q?iL3rUjVrfX6q83WkfiU9gDiiTwx1P4QuVjJkzXg9xM/JlJ1PQOxV9UF2O47m?=
 =?us-ascii?Q?MZKbnhAhnGVCwluDEu93WRVfrw0wz14UWbGEEXXEmzzLCdvmCBppSz3B8XzN?=
 =?us-ascii?Q?q9CxRJitM8NUPHiaK42iQt/hQxwbviWxe1XODe8T6i70dXWTyrZ9E2pDkgIm?=
 =?us-ascii?Q?2ZAiAdH1aMLHzTn+BVQxTgBs9+cnd3NKW2NbFEn0FHiZoA2AwESQB6nWjQko?=
 =?us-ascii?Q?xMNJsQKywMim/9/JvcI2HRVsEazrfPb8RSYg9p9LvKlS+OLKJJU9pwKcP3oK?=
 =?us-ascii?Q?EWGzhPZ1ilN2saepXfOFCpROxcp7jvhlwDsHrsLx7pfOuLars4jGhzJi3fv2?=
 =?us-ascii?Q?ERNcm7fg5aJ7fJvBit+saWkhiXL8rjjttCAuwZaAggCI8mP9g4OF5p26kV46?=
 =?us-ascii?Q?tRzwyzpB54sSHhca6DfaaWWHIWgFnpm7sT3mi+VLIPjhCIg49x+NaX3LqiU/?=
 =?us-ascii?Q?eu44K3EAe26Wrzf7XIWEgdQmd0Ybg2Vv562ptMMpD9q/HlMmv0L4ssFzYtik?=
 =?us-ascii?Q?IJdqw4EZ0cQhM2z65Z+DwaeZL2VHdibbl038EZ3X9TptO9uAzSwJXE1lslnN?=
 =?us-ascii?Q?TsTJetv2pE+fOHWXeT3WZlcj29yLzd7/dY8X0z0YKnhzhmM+URQY9MxtvjdM?=
 =?us-ascii?Q?ooFR+dvwn+dQSumEZetkXHVWuxmRcz76hyuOcLgjl6s+vj1ra+cLJsoIW37f?=
 =?us-ascii?Q?ONXF/ApQ/ZE+U11lR5kLZ4I1WIejh1+Zp3oxOzSP?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3e8bb80-0e25-4fa5-4484-08db66ec267c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5859.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 00:14:24.8589
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3omhVmm3xYprW3zEkmvMsgp4vHL7xJktoJGc6Eq0HW5QVkvRXJOVwxSt8cdVhLqU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7344
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 06, 2023 at 12:43:44PM -0700, Nicolin Chen wrote:
> On Tue, Jun 06, 2023 at 11:08:44AM -0300, Jason Gunthorpe wrote:
> > On Wed, May 24, 2023 at 06:41:41PM -0700, Nicolin Chen wrote:
> > 
> > > Upon a quick check, I think we could. Though it'd be slightly
> > > mismatched with the domain_alloc op, it should be fine since
> > > iommufd is likely to be the only caller.
> > 
> > Ideally the main op would return ERR_PTR too
> 
> Yea. It just seems to be a bit painful to change it for that.
> 
> Worth a big series?

Probably not..

Jason