Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp121217rwd; Tue, 6 Jun 2023 19:44:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6kUpsXXybsQtbHi0CRx6D9bvQWOxu6BL60iiIGQLO71mbm0V/hbxpp0bgpp5dH7GGp4RjW X-Received: by 2002:a05:6870:d2a9:b0:19f:16fc:3c51 with SMTP id d41-20020a056870d2a900b0019f16fc3c51mr3504053oae.9.1686105894094; Tue, 06 Jun 2023 19:44:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686105894; cv=none; d=google.com; s=arc-20160816; b=nfwqKlWR1I7QpyMU2ajGbOGhgTHBA8iXSQOVpz+TOU24NPRsFhqW7hUG7iCnQ3Evlg 6ApsQ5yPd16e5tjRlE2RDmT911KWjRLRo42dxpxlocTjXGZ+juZwkCiLH5BoLhu5jPEJ akiQng8jNauPIaIt49O8KRL9MaqRJwyPsjqQuF3tH41DjImeNI29Hn67Dp8ReenHcJk2 AJy99bQpec+Kckd1WPjD9u1VWTkyDfLgMHW62kLMbmozrPmi43TF4dxzB47LUnXjiymd 4X/Ny5HJCw3hLVoeFA0zGIPjnCeTbDKfJq+o8cM8geXkpqCjq5N56Daa0RzjAswKQUMw IPGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=MvQMWZ87hMXQli98UrNMt7KmZjl0+wQlzr53QMHdM5Q=; b=TKDQaxNPbh8fhQwtmVieDR/RRephU5dxL28XA5Uol6pYcKtl1l+fb8M+lyyBbGlHQV OtCJuGQR/cZ0H8fQgU09PZ64kM2la2ZFqv4watSCD9wEzqseSr9uYm3sT1A1gSAhHR1q FkU+spN19SyzIC5Jo/6VJT8FtvziTHBNV62NsnXvH0IEeMdl8S8nrWyL0tT6cMBwizFl yNpdPwkQX28Fbbz3xYfqzm6xdV2cS1vVlYo6EqpSb95R7L6mgDBtnmMIvtIOjJd2zAFn aANBP/bWetS3Ni1Ga/y/5KNdRREFyCPok9SQYDw9wSQV8e0IjFytxXS7WN/b0pLY+Eje iVqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bk13-20020a056a02028d00b0053fb8af618asi8374587pgb.267.2023.06.06.19.44.41; Tue, 06 Jun 2023 19:44:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240636AbjFGCFt (ORCPT + 99 others); Tue, 6 Jun 2023 22:05:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240103AbjFGCFs (ORCPT ); Tue, 6 Jun 2023 22:05:48 -0400 Received: from cstnet.cn (smtp80.cstnet.cn [159.226.251.80]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 611C410F0 for ; Tue, 6 Jun 2023 19:05:47 -0700 (PDT) Received: from ed3e173716be.home.arpa (unknown [124.16.138.125]) by APP-01 (Coremail) with SMTP id qwCowAB3fxfr5X9kQYTMDA--.6398S2; Wed, 07 Jun 2023 10:05:33 +0800 (CST) From: Jiasheng Jiang To: hyun.kwon@xilinx.com, laurent.pinchart@ideasonboard.com, airlied@gmail.com, daniel@ffwll.ch, michal.simek@amd.com Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] drm: xlnx: zynqmp_dpsub: Add missing check for dma_set_mask Date: Wed, 7 Jun 2023 10:05:29 +0800 Message-Id: <20230607020529.22934-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: qwCowAB3fxfr5X9kQYTMDA--.6398S2 X-Coremail-Antispam: 1UD129KBjvdXoWrKr1ktr1rJw47WF1xArWrZrb_yoWDWFc_Kr 1UCFyDXF4DAr1vqrsrCrySyr92k395XrZYvFs7Ka4FqryUGrnxX3y7ZFZ09r4DZ3W7ArWD X3WjgrZxJrWIkjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcxFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc2xSY4AK67AK6r4U MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr 0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0E wIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJV W8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAI cVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbpwZ7UUUUU== X-Originating-IP: [124.16.138.125] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add check for dma_set_mask() and return the error if it fails. Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem") Signed-off-by: Jiasheng Jiang --- drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c index bab862484d42..068413be6527 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c @@ -227,7 +227,9 @@ static int zynqmp_dpsub_probe(struct platform_device *pdev) dpsub->dev = &pdev->dev; platform_set_drvdata(pdev, dpsub); - dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); + ret = dma_set_mask(dpsub->dev, DMA_BIT_MASK(ZYNQMP_DISP_MAX_DMA_BIT)); + if (ret) + return ret; /* Try the reserved memory. Proceed if there's none. */ of_reserved_mem_device_init(&pdev->dev); -- 2.25.1