Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Jun 2023 19:42:54 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     David Hildenbrand <david@redhat.com>
Cc:     John Hubbard <jhubbard@nvidia.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        Shuah Khan <shuah@kernel.org>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Jens Axboe <axboe@kernel.dk>, Peter Xu <peterx@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH v1 2/3] selftests/mm: gup_longterm: new functional test
 for FOLL_LONGTERM
Message-Id: <20230606194254.5e26642b28dfbd0e198d24e8@linux-foundation.org>
In-Reply-To: <e099e2c1-322c-0a64-0f5b-5da621fedca1@redhat.com>
References: <20230519102723.185721-1-david@redhat.com>
        <20230519102723.185721-3-david@redhat.com>
        <ea3548ae-de27-fb67-5b2a-34aca006005c@nvidia.com>
        <e099e2c1-322c-0a64-0f5b-5da621fedca1@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 6 Jun 2023 09:10:22 +0200 David Hildenbrand <david@redhat.com> wrote:

> On 06.06.23 08:23, John Hubbard wrote:
> > On 5/19/23 03:27, David Hildenbrand wrote:
> > ...
> >> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
> >> index 23af4633f0f4..95acb099315e 100644
> >> --- a/tools/testing/selftests/mm/Makefile
> >> +++ b/tools/testing/selftests/mm/Makefile
> >> @@ -34,6 +34,7 @@ LDLIBS = -lrt -lpthread
> >>   
> >>   TEST_GEN_PROGS = cow
> >>   TEST_GEN_PROGS += compaction_test
> >> +TEST_GEN_PROGS += gup_longterm
> > 
> > Hi David,
> > 
> > Peter Xu just pointed out that we need a .gitignore entry for
> > gup_longterm [1]. That logically belongs in this patch, I think.
> 
> Yes, although I don't care if it's in a follow-up patch (we're talking 
> testcases after all).
> 
> @Andrew can you include that hunk in that patch or do you want a resend?

I added this:

From: Andrew Morton <akpm@linux-foundation.org>
Subject: selftests-mm-gup_longterm-new-functional-test-for-foll_longterm-fix
Date: Tue Jun  6 07:41:28 PM PDT 2023

update .gitignore for gup_longterm, per Peter

Cc: David Hildenbrand <david@redhat.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Jason Gunthorpe <jgg@nvidia.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 tools/testing/selftests/mm/.gitignore |    1 +
 1 file changed, 1 insertion(+)

--- a/tools/testing/selftests/mm/.gitignore~selftests-mm-gup_longterm-new-functional-test-for-foll_longterm-fix
+++ a/tools/testing/selftests/mm/.gitignore
@@ -39,3 +39,4 @@ local_config.h
 local_config.mk
 ksm_functional_tests
 mdwe_test
+gup_longterm
_