Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230602073442.1765-1-angus.chen@jaguarmicro.com>
 <CACGkMEtCr-LGVH9QJRaMJ2VF3fyDX2zEVwOSJtb-gB_VtSTV2A@mail.gmail.com> <SG2PR06MB342012C05627EA6456EF59B18552A@SG2PR06MB3420.apcprd06.prod.outlook.com>
In-Reply-To: <SG2PR06MB342012C05627EA6456EF59B18552A@SG2PR06MB3420.apcprd06.prod.outlook.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Wed, 7 Jun 2023 10:11:04 +0800
Message-ID: <CACGkMEsWkyMOUmnFks9C73BMZB3i86Kg0ig745N3OjJs35PAuw@mail.gmail.com>
Subject: Re: [PATCH] vp_vdpa: Check queue number of vdpa device from add_config
To:     Angus Chen <angus.chen@jaguarmicro.com>
Cc:     "mst@redhat.com" <mst@redhat.com>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 6, 2023 at 2:19=E2=80=AFPM Angus Chen <angus.chen@jaguarmicro.c=
om> wrote:
>
> Hi,Jason.
>
> > -----Original Message-----
> > From: Jason Wang <jasowang@redhat.com>
> > Sent: Monday, June 5, 2023 2:54 PM
> > To: Angus Chen <angus.chen@jaguarmicro.com>
> > Cc: mst@redhat.com; virtualization@lists.linux-foundation.org;
> > linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH] vp_vdpa: Check queue number of vdpa device from
> > add_config
> >
> > On Fri, Jun 2, 2023 at 3:35=E2=80=AFPM Angus Chen <angus.chen@jaguarmic=
ro.com>
> > wrote:
> > >
> > > When add virtio_pci vdpa device,check the vqs number of device cap
> > > and max_vq_pairs from add_config.
> > >
> > > Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> > > ---
> > >  drivers/vdpa/virtio_pci/vp_vdpa.c | 11 +++++++++--
> > >  1 file changed, 9 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c
> > b/drivers/vdpa/virtio_pci/vp_vdpa.c
> > > index 281287fae89f..4bf1ab637d32 100644
> > > --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> > > +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> > > @@ -478,7 +478,7 @@ static int vp_vdpa_dev_add(struct vdpa_mgmt_dev
> > *v_mdev, const char *name,
> > >         struct device *dev =3D &pdev->dev;
> > >         struct vp_vdpa *vp_vdpa =3D NULL;
> > >         u64 device_features;
> > > -       int ret, i;
> > > +       int ret, i, queues;
> > >
> > >         vp_vdpa =3D vdpa_alloc_device(struct vp_vdpa, vdpa,
> > >                                     dev, &vp_vdpa_ops, 1, 1, name,
> > false);
> > > @@ -491,7 +491,14 @@ static int vp_vdpa_dev_add(struct vdpa_mgmt_dev
> > *v_mdev, const char *name,
> > >         vp_vdpa_mgtdev->vp_vdpa =3D vp_vdpa;
> > >
> > >         vp_vdpa->vdpa.dma_dev =3D &pdev->dev;
> > > -       vp_vdpa->queues =3D vp_modern_get_num_queues(mdev);
> > > +       queues =3D vp_modern_get_num_queues(mdev);
> > > +       if (add_config->mask &
> > BIT_ULL(VDPA_ATTR_DEV_NET_CFG_MAX_VQP)) {
> > > +               if (add_config->net.max_vq_pairs > queues / 2)
> > > +                       return -EINVAL;
> > > +               queues =3D min_t(u32, queues, 2 *
> > add_config->net.max_vq_pairs);
> >
> > Looks like you want to mediate the max_vqp here, but what happens:
> >
> > 1) harware have 4 queue paris
> > 2) vp_vdpa cap it into 2 queue pairs
> > 3) guest may still try to enable 4 queue paris
> >
> Yes=EF=BC=8Cyou are right=EF=BC=8Cthis situation can occur.
> > For 3), the kernel needs to mediate the control virtqueue which seems n=
ot
> > easy.
> >
> > How about simply starting from failing if the provisioned #qp is not
> > equal to the one that hardware has?
> Ok,You mean we just check it in vp_vdpa or check it in all other vdpa net=
 drivers?

vp_vdpa only, since in some other kind of parents, #qps could be provisione=
d.

Thanks

> >
> > Thanks
> >
> > > +       }
> > > +
> > > +       vp_vdpa->queues =3D queues;
> > >         vp_vdpa->mdev =3D mdev;
> > >
> > >         device_features =3D vp_modern_get_features(mdev);
> > > --
> > > 2.25.1
> > >
>