Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp167868rwd; Tue, 6 Jun 2023 20:44:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ49uFoKACZ1Pk8vIZQB8SAuyyuy9RlwtjW03vZfcrN5e47ZDcmL4As4xE6LGl1KOfgY0/X+ X-Received: by 2002:a9d:6b18:0:b0:6af:9c61:c0e3 with SMTP id g24-20020a9d6b18000000b006af9c61c0e3mr4063785otp.29.1686109456726; Tue, 06 Jun 2023 20:44:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686109456; cv=none; d=google.com; s=arc-20160816; b=NqAXT0Ody93+I5N25fz8Y7/9S78hWfW5FLRpnjZrcEAU/kE3oUrp399elGtPbt1DZ1 dQtTBcO+2U4eaQn5U7aZNyu7VQsNK8lZ5nxr3e8MAx0JyohHDeNnnLJEAUDmSV8d5CGH VHH64Fp+SwUgDKHRNxrCYoGG9z87wIPmgNDY+5niT9ImHVsIsIyOBT4Qc7VbzB2fzm80 f6Bp0aH+uqIeBwmFP0X0ij93Ctty8edPLvwTdwcH9QGByFvA/zIknMN6OBerZCDfEfmg Ax0B/5s/dO9fr0NeYWNEXfAAN7Q3JS/xp1llDVznlIxI/gAewFPLqrWD9P/WLMBU6LA2 BWJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Kdi0VITwdsq0zrcUf8UPyfClsJWxZuLZLNF90I1VccE=; b=TjSAcMRCHsZ6/vAi2B6aeXIdyGrgYEjrEQw6NWJ7SLuE+h4iXYnM3y4mnIEBzJSaO1 YknfbZ9nb3kKKFNyFRbiX6Tm5owC+rSYoejex/5AuNMl1WU9kaP6kSPSKpFPV2kSeXVF UI6FjbT97sgPLPwW3sOGxfqOYgTWHadl7/Fox3u/M7HTrgie+nHblSSllAe2KwSJN9jf F3GgrvBN7a5dpeERSHkP10Z1t8Xsd7ESkDx22BmeY6Tu/Bz6Pk5XUjBOalbhhkIGzcME +R/EhrBUDWQCfhAQTp3C7m1bG2iFBi4345VZq9OOmi0Boj14SxFs2VHkCiJaPcAC5008 AafQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t2-20020aa79462000000b0063b7b7712a5si8037314pfq.304.2023.06.06.20.44.04; Tue, 06 Jun 2023 20:44:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240734AbjFGCVJ (ORCPT + 99 others); Tue, 6 Jun 2023 22:21:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234730AbjFGCVI (ORCPT ); Tue, 6 Jun 2023 22:21:08 -0400 Received: from cstnet.cn (smtp80.cstnet.cn [159.226.251.80]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DBCA1990 for ; Tue, 6 Jun 2023 19:21:05 -0700 (PDT) Received: from ed3e173716be.home.arpa (unknown [124.16.138.125]) by APP-01 (Coremail) with SMTP id qwCowAC3vg6H6X9kIU3ODA--.1995S2; Wed, 07 Jun 2023 10:20:57 +0800 (CST) From: Jiasheng Jiang To: vkoul@kernel.org, zhangfei.gao@marvell.com, leoy@marvell.com, zhouqiao@marvell.com Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] dmaengine: mmp_tdma: Add missing check for dma_set_mask Date: Wed, 7 Jun 2023 10:20:53 +0800 Message-Id: <20230607022053.32696-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: qwCowAC3vg6H6X9kIU3ODA--.1995S2 X-Coremail-Antispam: 1UD129KBjvdXoWrKr48KF1DJF4Uur4ftFW5ZFb_yoWfAFXEgr y0vFW8WFyDAF40qF4Ikr1ayryFkrn0qr9xWF1kKa4fZry5JrZxWayUZF1kGr4UZ34UCr4U Cr4j9rW3G3WxCjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbckFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Cr 1j6rxdM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkIecxEwVAFwVW8 JwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r 1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij 64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr 0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF 0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUHWlkUUUUU= X-Originating-IP: [124.16.138.125] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add check for dma_set_mask() and return the error if it fails. Fixes: c6da0ba8dfc8 ("dmaengine: mmp_tdma: add mmp tdma support") Signed-off-by: Jiasheng Jiang --- drivers/dma/mmp_tdma.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c index d49fa6bc6775..99cf4f7cd50b 100644 --- a/drivers/dma/mmp_tdma.c +++ b/drivers/dma/mmp_tdma.c @@ -717,7 +717,10 @@ static int mmp_tdma_probe(struct platform_device *pdev) tdev->device.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST; tdev->device.descriptor_reuse = true; - dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)); + ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)); + if (ret) + return ret; + platform_set_drvdata(pdev, tdev); ret = dmaenginem_async_device_register(&tdev->device); -- 2.25.1