Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To:     Yuezhen Luan <eggcar.luan@gmail.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCHv3 net] igb: Fix extts capture value
 format for 82580/i354/i350
Thread-Topic: [Intel-wired-lan] [PATCHv3 net] igb: Fix extts capture value
 format for 82580/i354/i350
Thread-Index: AQHZlWXKuTcjSmZgKEqKPC14KBkuPK9+s1mA
Date:   Wed, 7 Jun 2023 03:23:07 +0000
Message-ID: <BL0PR11MB31227A1BAF9FEADFC6913836BD53A@BL0PR11MB3122.namprd11.prod.outlook.com>
References: <20230602070422.1808-1-eggcar.luan@gmail.com>
In-Reply-To: <20230602070422.1808-1-eggcar.luan@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GxqTLBry/gMtCxbbH3/KUafXII8H5H5eGtXN5ez+0OJDE/hbHu+y6aD84nUt?=
 =?us-ascii?Q?KMAe08BM8qFvvMm4uH3fah8xeIj1h4dnmZm6Fd2mYbXIWNADZwZCvhiRji5n?=
 =?us-ascii?Q?5Y++ABM74R2w02N7jv0Ke3hMSDjt7skA6pfoePN2YcksLh3Apw/LU3ObGOGM?=
 =?us-ascii?Q?h7arg+kK9Q0mcfk3Y0sD37LyXwmYxNK2myb0C5IRSbFYlZojciGUi3aD/r/y?=
 =?us-ascii?Q?/BZfHY2dVHdm26l2mTD3LKBMI3EGbwOcJFzYb2ma5hecAfM1CxZa5lEvRtU7?=
 =?us-ascii?Q?s4rSyP2V5w3QFadbPeJS9D4prJOZNyKFtj5pkhcgMn2UGnH4lAckYyV91keP?=
 =?us-ascii?Q?z+D0uhEbjiZxmxyfyv1moX16szJIOrFeV9mpm7GRqnmLtBG07+0L6cBFKGRN?=
 =?us-ascii?Q?Tmlgyw3VSjJq3kRPZafgLtaAosCpz8mwA0wwC1nQPOB21iNDFVcIGX+VegQe?=
 =?us-ascii?Q?lR4Tmfmgq1dRRuhrhmD7dUOIwNic3pwF+r1HOOGTZFp1mzcYzh8BhtxrM/XX?=
 =?us-ascii?Q?K5ZQkDzQhQL2PpWNumopWvZ2o4lAKw7JoJFadpGORcR5n3kaef8zIzg9dsBI?=
 =?us-ascii?Q?OFt6RFWqvuZTrDVlb7MM2b/oYjqVjQXkLAUd0sWrBj6VcoEf23FfpuGFdk2e?=
 =?us-ascii?Q?PdJBB/dOI4RaepjoaJVQRhwm7SplJ5/u7Qu4jv8eESW3iKFfoen981Gz3vCW?=
 =?us-ascii?Q?4ArUImJsqEBrUVrW/g4WuurDwbtC1lUNFHZv6LtQ6BTkt9dx60X7KHSYvBqU?=
 =?us-ascii?Q?H8IqONljVzkP7/aH8hqzYsGKWdYyyt70Bdk25ECk68LLRqWwVHUBxM71LDoF?=
 =?us-ascii?Q?7kcjGhOpBZb1QpUKegYA+eWrXHX7wFJB5jntIKCyzhgoWBwryRoEF1/KPXHh?=
 =?us-ascii?Q?2y2TyLSeLGZCBZxLJQuCTxR+OYzOt3DSSYISwVGZ0zjaTlea1Y8n2+sDyHnZ?=
 =?us-ascii?Q?eUZxu+IY4PJ04aHACnLlR/ZLko+uGQlCIKRulwl8NjqvytpvPncYtXZFoGWX?=
 =?us-ascii?Q?0ZhFf2MGtXwnup18jL4fe2vpz/pgBgbun4eq82NpPynpF5DLKz78HjbWIvWu?=
 =?us-ascii?Q?LLSvpRUYuId8R6WRn7KT3xzMZ3EAUdiltzxkbV89wd8DsewMGjNEfQGJEvFv?=
 =?us-ascii?Q?DyF0smYbLHl0qitU+poQFGtkoUng8AnJXyNCJ6V3UnmE/yq/RaPBVPqoi75M?=
 =?us-ascii?Q?wtrAjdRdkTHBge1Wnb3lT+B/n9XjrRZlIUXgiVK9sVDzn9mXrNRBV8dfKrLl?=
 =?us-ascii?Q?OinZlHIWUsQv9yCWvSWoT2rWHpiGZQJa0UvuF1CyukUcHOJMXNIOseqbA8BU?=
 =?us-ascii?Q?R4YpKv1N4vuMaPiamhjb5E4WDBaR40kLTFP/Dzh6+66CjS04W4pF4XqbKhcd?=
 =?us-ascii?Q?/02Uv32RjXLG/KGjsvmMh0iAvU9HbrJxzI8CGzSiq1gSaS1Fo7duA3m9TaeS?=
 =?us-ascii?Q?Lnf3ZQFsoeC+vJcIITquTYySMq2B9UK3FS32oKrQDNVoHRhtSJPL4eI2vQz4?=
 =?us-ascii?Q?xRW85yA51KQE03pYKumaVIBbxfGvWip3wo4fpVM42sxtJdidjqRrsvErPJuP?=
 =?us-ascii?Q?AZ8vBbIrlpNtxNw1tvYoqPpS3YYQLIuiLjvTofjlodVz//yQCvQ7vw0H+VS3?=
 =?us-ascii?Q?2g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3122.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3bed40e-cdf4-44d1-58db-08db6706832d
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2023 03:23:07.1083
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0u+tPneWk3Sq9/m340jPwL5al5jqgzRmyBwrqt+3pkNyqvds/mUb3dxVdW57oDo5v7XyFFcNTZba/XysxNt1GUjvIFGvqrEIo3dYPKfaiSdCK2gpQ+Wn10hkKSBcIF/X
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5080
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Y=
uezhen Luan
> Sent: Friday, June 2, 2023 12:34 PM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <an=
thony.l.nguyen@intel.com>; davem@davemloft.net; edumazet@google.com; kuba@k=
ernel.org; pabeni@redhat.com
> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-kerne=
l@vger.kernel.org; Yuezhen Luan <eggcar.luan@gmail.com>
> Subject: [Intel-wired-lan] [PATCHv3 net] igb: Fix extts capture value for=
mat for 82580/i354/i350
>
> 82580/i354/i350 features circle-counter-like timestamp registers that are=
 different with newer i210. The EXTTS capture value in AUXTSMPx should be c=
onverted from raw circle counter value to timestamp value in resolution of =
1 nanosec by the driver.
>
> This issue can be reproduced on i350 nics, connecting an 1PPS signal to a=
 SDP pin, and run 'ts2phc' command to read external 1PPS timestamp value. O=
n i210 this works fine, but on i350 the extts is not correctly converted.
>
> The i350/i354/82580's SYSTIM and other timestamp registers are 40bit coun=
ters, presenting time range of 2^40 ns, that means these registers overflow=
s every about 1099s. This causes all these regs can't be > used directly in=
 contrast to the newer i210/i211s.
>
> The igb driver needs to convert these raw register values to valid time s=
tamp format by using kernel timecounter apis for i350s families. Here the i=
gb_extts() just forgot to do the convert.
>
> Fixes: 38970eac41db ("igb: support EXTTS on 82580/i354/i350")
> Signed-off-by: Yuezhen Luan <eggcar.luan@gmail.com>
> ---
> V2 -> V3: Add 'Fixes' tag, and add 'net' tag in patch title
> V1 -> V2: Fix typo in the source code, and add detailed explanation
>
> drivers/net/ethernet/intel/igb/igb_main.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)